mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Cc: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Subject: [PATCH 15/15] staging: rtl8723bs: Remove function pointer disable_interrupt
Date: Sat,  5 Oct 2024 22:33:58 +0200	[thread overview]
Message-ID: <fee97dadc88bbdaebd82c99d0b6106d58315bd85.1727966761.git.philipp.g.hortmann@gmail.com> (raw)
In-Reply-To: <cover.1727966761.git.philipp.g.hortmann@gmail.com>

Remove function pointer disable_interrupt and use
DisableInterrupt8723BSdio directly to increase readability.

Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
---
 drivers/staging/rtl8723bs/hal/hal_intf.c     | 3 +--
 drivers/staging/rtl8723bs/hal/sdio_halinit.c | 1 -
 drivers/staging/rtl8723bs/include/hal_intf.h | 1 -
 3 files changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/hal_intf.c b/drivers/staging/rtl8723bs/hal/hal_intf.c
index 716eefdf8ce2..11d75b1b1ea9 100644
--- a/drivers/staging/rtl8723bs/hal/hal_intf.c
+++ b/drivers/staging/rtl8723bs/hal/hal_intf.c
@@ -151,8 +151,7 @@ void rtw_hal_enable_interrupt(struct adapter *padapter)
 
 void rtw_hal_disable_interrupt(struct adapter *padapter)
 {
-	if (padapter->HalFunc.disable_interrupt)
-		padapter->HalFunc.disable_interrupt(padapter);
+	DisableInterrupt8723BSdio(padapter);
 }
 
 u8 rtw_hal_check_ips_status(struct adapter *padapter)
diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
index 91aac5d1c23e..a64b28bee019 100644
--- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
+++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
@@ -1259,7 +1259,6 @@ void rtl8723bs_set_hal_ops(struct adapter *padapter)
 
 	rtl8723b_set_hal_ops(pHalFunc);
 
-	pHalFunc->disable_interrupt = &DisableInterrupt8723BSdio;
 	pHalFunc->check_ips_status = &CheckIPSStatus;
 	pHalFunc->SetHwRegHandler = &SetHwReg8723BS;
 	pHalFunc->GetHwRegHandler = &GetHwReg8723BS;
diff --git a/drivers/staging/rtl8723bs/include/hal_intf.h b/drivers/staging/rtl8723bs/include/hal_intf.h
index 3b35bc30ae37..5b52b0fd95f0 100644
--- a/drivers/staging/rtl8723bs/include/hal_intf.h
+++ b/drivers/staging/rtl8723bs/include/hal_intf.h
@@ -162,7 +162,6 @@ enum hal_intf_ps_func {
 typedef s32 (*c2h_id_filter)(u8 *c2h_evt);
 
 struct hal_ops {
-	void (*disable_interrupt)(struct adapter *padapter);
 	u8 (*check_ips_status)(struct adapter *padapter);
 	void (*set_channel_handler)(struct adapter *padapter, u8 channel);
 	void (*set_chnl_bw_handler)(struct adapter *padapter, u8 channel, enum channel_width Bandwidth, u8 Offset40, u8 Offset80);
-- 
2.43.0


      parent reply	other threads:[~2024-10-05 20:34 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-05 20:33 [PATCH 00/15] staging: rtl8723bs: Remove function pointers starting with hal_init Philipp Hortmann
2024-10-05 20:33 ` [PATCH 01/15] staging: rtl8723bs: Remove function pointer hal_init Philipp Hortmann
2024-10-05 20:33 ` [PATCH 02/15] staging: rtl8723bs: Remove function pointer hal_deinit Philipp Hortmann
2024-10-05 20:33 ` [PATCH 03/15] staging: rtl8723bs: Remove function pointer free_hal_data Philipp Hortmann
2024-10-05 20:33 ` [PATCH 04/15] staging: rtl8723bs: Remove function pointer init_xmit_priv Philipp Hortmann
2024-10-05 20:33 ` [PATCH 05/15] staging: rtl8723bs: Remove function pointer free_xmit_priv Philipp Hortmann
2024-10-05 20:33 ` [PATCH 06/15] staging: rtl8723bs: Remove function pointer init_recv_priv Philipp Hortmann
2024-10-05 20:33 ` [PATCH 07/15] staging: rtl8723bs: Remove function pointer free_recv_priv Philipp Hortmann
2024-10-05 20:33 ` [PATCH 08/15] staging: rtl8723bs: Remove function pointer dm_init Philipp Hortmann
2024-10-05 20:33 ` [PATCH 09/15] staging: rtl8723bs: Remove function pointer dm_deinit Philipp Hortmann
2024-10-05 20:33 ` [PATCH 10/15] staging: rtl8723bs: Remove function pointer read_chip_version Philipp Hortmann
2024-10-05 20:33 ` [PATCH 11/15] staging: rtl8723bs: Remove function pointer init_default_value Philipp Hortmann
2024-10-05 20:33 ` [PATCH 12/15] staging: rtl8723bs: Remove function pointer intf_chip_configure Philipp Hortmann
2024-10-05 20:33 ` [PATCH 13/15] staging: rtl8723bs: Remove function pointer read_adapter_info Philipp Hortmann
2024-10-05 20:33 ` [PATCH 14/15] staging: rtl8723bs: Remove function pointer enable_interrupt Philipp Hortmann
2024-10-05 20:33 ` Philipp Hortmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fee97dadc88bbdaebd82c99d0b6106d58315bd85.1727966761.git.philipp.g.hortmann@gmail.com \
    --to=philipp.g.hortmann@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®