From: Michal Simek <monstr@monstr.eu>
To: Valentin Schneider <valentin.schneider@arm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/9] microblaze: entry: Remove unneeded need_resched() loop
Date: Tue, 24 Sep 2019 12:30:01 +0200 [thread overview]
Message-ID: <feebf264-a311-9777-cd9b-5d227e8f6d3c@monstr.eu> (raw)
In-Reply-To: <20190923143620.29334-6-valentin.schneider@arm.com>
On 23. 09. 19 16:36, Valentin Schneider wrote:
> Since the enabling and disabling of IRQs within preempt_schedule_irq()
> is contained in a need_resched() loop, we don't need the outer arch
> code loop.
>
> Signed-off-by: Valentin Schneider <valentin.schneider@arm.com>
> Cc: Michal Simek <monstr@monstr.eu>
> ---
> arch/microblaze/kernel/entry.S | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/arch/microblaze/kernel/entry.S b/arch/microblaze/kernel/entry.S
> index 4e1b567becd6..de7083bd1d24 100644
> --- a/arch/microblaze/kernel/entry.S
> +++ b/arch/microblaze/kernel/entry.S
> @@ -738,14 +738,9 @@ no_intr_resched:
> andi r5, r5, _TIF_NEED_RESCHED;
> beqi r5, restore /* if zero jump over */
>
> -preempt:
> /* interrupts are off that's why I am calling preempt_chedule_irq */
> bralid r15, preempt_schedule_irq
> nop
> - lwi r11, CURRENT_TASK, TS_THREAD_INFO; /* get thread info */
> - lwi r5, r11, TI_FLAGS; /* get flags in thread info */
> - andi r5, r5, _TIF_NEED_RESCHED;
> - bnei r5, preempt /* if non zero jump to resched */
> restore:
> #endif
> VM_OFF /* MS: turn off MMU */
>
Looks reasonable and also tested on HW. I expect you want me to take it
via microblaze tree that's why applied.
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs
next prev parent reply other threads:[~2019-09-24 10:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-23 14:36 [PATCH v2 0/9] entry: preempt_schedule_irq() callers scrub Valentin Schneider
2019-09-23 14:36 ` [PATCH v2 1/9] sched/core: Fix preempt_schedule() interrupt return comment Valentin Schneider
2019-09-27 8:10 ` [tip: sched/urgent] " tip-bot2 for Valentin Schneider
2019-09-23 14:36 ` [PATCH v2 2/9] c6x: entry: Remove unneeded need_resched() loop Valentin Schneider
2019-09-23 14:36 ` [PATCH v2 3/9] csky: " Valentin Schneider
2019-09-23 16:55 ` Guo Ren
2019-09-23 14:36 ` [PATCH v2 4/9] h8300: " Valentin Schneider
2019-09-23 14:36 ` [PATCH v2 5/9] microblaze: " Valentin Schneider
2019-09-24 10:30 ` Michal Simek [this message]
2019-09-24 10:48 ` Valentin Schneider
2019-09-23 14:36 ` [PATCH v2 6/9] RISC-V: " Valentin Schneider
2019-10-09 0:51 ` Paul Walmsley
2019-09-23 14:36 ` [PATCH v2 7/9] sh: " Valentin Schneider
2019-09-23 14:36 ` [PATCH v2 8/9] sh64: " Valentin Schneider
2019-09-23 14:36 ` [PATCH v2 9/9] xtensa: " Valentin Schneider
2019-11-14 18:17 ` Max Filippov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=feebf264-a311-9777-cd9b-5d227e8f6d3c@monstr.eu \
--to=monstr@monstr.eu \
--cc=linux-kernel@vger.kernel.org \
--cc=valentin.schneider@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®