From: Alexander Lobakin <aleksander.lobakin@intel.com>
To: Kal Cutter Conley <kal.conley@dectris.com>
Cc: "Björn Töpel" <bjorn@kernel.org>,
"Magnus Karlsson" <magnus.karlsson@intel.com>,
"Maciej Fijalkowski" <maciej.fijalkowski@intel.com>,
"Jonathan Lemon" <jonathan.lemon@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Alexei Starovoitov" <ast@kernel.org>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Jesper Dangaard Brouer" <hawk@kernel.org>,
"John Fastabend" <john.fastabend@gmail.com>,
netdev@vger.kernel.org, bpf@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xsk: Add missing overflow check in xdp_umem_reg
Date: Thu, 9 Mar 2023 17:30:53 +0100 [thread overview]
Message-ID: <feee2aad-6834-da69-a154-c1e0e21d12b7@intel.com> (raw)
In-Reply-To: <CAHApi-=C3ym23bBQ2h8BOyOfUtYXs9eZNG0Z8G2zfPeaEQWeRg@mail.gmail.com>
From: Kal Conley <kal.conley@dectris.com>
Date: Wed, 8 Mar 2023 19:49:29 +0100
>> The code is fine to me.
>> Please resubmit with the fixed subject and expanded commit message.
>> I'd also prefer that you sent v3 as a separate mail, *not* as a reply to
>> this thread.
>
> Done. I used "bpf" in the subject as you suggested, however I am a bit
> confused by this. Should changes under net/xdp generally use "bpf" in
> the subject?
"bpf" when it's a fix (better to have some real repro, otherwise purely
hypothetical fix can be considered a bpf-next material), "bpf-next" when
it's an improvement / new stuff etc.
Also please don't forget to manually add all the folks who reviewed your
previous versions / were participating in the threads for previous
versions, otherwise they can miss the fact that you posted a new revision.
>
> Thanks,
> Kal
Thanks,
Olek
prev parent reply other threads:[~2023-03-09 16:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-07 17:23 Kal Conley
2023-03-07 17:47 ` Alexander Lobakin
2023-03-07 18:58 ` Kal Cutter Conley
2023-03-08 13:32 ` Alexander Lobakin
2023-03-08 10:51 ` Kal Conley
2023-03-08 15:33 ` Alexander Lobakin
2023-03-08 18:49 ` Kal Cutter Conley
2023-03-09 16:30 ` Alexander Lobakin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=feee2aad-6834-da69-a154-c1e0e21d12b7@intel.com \
--to=aleksander.lobakin@intel.com \
--cc=ast@kernel.org \
--cc=bjorn@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=jonathan.lemon@gmail.com \
--cc=kal.conley@dectris.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®