From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 78708156F54 for ; Tue, 24 Dec 2024 10:35:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735036528; cv=none; b=nDTWgd1Cy4nrB6ZfWUL8bnjcPavU1S/fV/RkwZ2uwCFtlczDup+Sq03ilBofkZQBd8jD/l91a9grUTHkARgBZlQT61kV4a5uhURl0rBrlUw4GoAF+o5VLntGcFfsjbD22Y3AnwlOhVcgkw9IA8AVvMf8plRY6eieTt9vMnDXPdk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735036528; c=relaxed/simple; bh=1keLCnQ9I9C8qhal2WJv16cjf5G0iXLQzxvv4oMAPmM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=froFVieHYUI0SmPYoY6ZPeK9tTybHnWrXTwN5if4SbJbNfXv8XRTDVzHK38Tn8dQT2w9Nj3sg/BVlH0oXw0KrSt1YPi2kAVSdQIxz4mfCUXNebdvBXjwCd2hGWsryJPdCgoROL891Y5T/WC5XLxtGufijCNHsUyZtlxBZMr1WYI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=grimberg.me; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=grimberg.me Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-385f07cd1a4so3172356f8f.1 for ; Tue, 24 Dec 2024 02:35:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735036525; x=1735641325; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=j/pA54kXaVlMpPLAY6bEeTkG7mL6qyW4U3X8jyQcC3w=; b=Sp6ItRglrD5fTb8qOc3xv7KKL7ZyJ7nA5R01URr68NCNx+zmA8+yCuMKNmG7enb+zG 48sTd62hN2tTLbg4fOijXHHiH9ARcVWm3Srzse0UWMKgs/9NAoP6QMTeYi9RoKNF5raS Qcz5Q/fH8IxtX/Q2yFOWuWdfDGUrpA1Vbh0JL9qsGJX9fT/B+TT083U2SZuc7mIGBMPE MquORMvaND2dhw4twrJbElNsbExYFl8s8H07aHmRvd0YtjrTy+IiULjOUCOz2oHsmDCd BB5tL1VPhCsbjfYHa4i1RBZ1B/gBc3Sc3CX/EdQ05RrXIU1IUbwiH6Ob5hwGdQggZN0k r0Ig== X-Forwarded-Encrypted: i=1; AJvYcCUtoG2FaiC53qWBRRLk5EkPtVB0n8uvOmiPr4YyGRlhh5YMUgaXOk7Muhfehlqkwf5DfPv+8Id8IyiqE3c=@vger.kernel.org X-Gm-Message-State: AOJu0YwXSBr/ZLtsR6ntGxeypoVqT1M4IvOtFGP2LNKPWS2wtbvqztzC BsDm7mm2B2CIyXeBx4uZ25AJq0kQlneM9kC7U/q3PDkkawHojGUx X-Gm-Gg: ASbGncsgCD6DWu2nm2EgvkQvVMPuml3qDG+y8h2vSmwWHeiQXKpWOtvsOdZuFk2Q9R0 BF+imsn4t9735nqnSx3mLXrA55hoxCW5pOp+cTEi5yJd0u5JmLrhkDk7pI9Nw9EOVvLWloD4E6x OZnN4o9CsFtMIkZf2NKFmGNbZVRb97TGJqj6N8U4cWE7vhzsbUYkPFOZpmFtok+BcYBsVv9fXsE 37JzFVG8xiQGkiher0Xqk4bKDpiHivCsG8tOz8Bt3ZUuZOsne3W7x6Vyhpk2ROPhI9Bo0TY7kYa yRvbX0TlhHAUEw133mdUuLs= X-Google-Smtp-Source: AGHT+IGjlMBBQ5mbUvWJxLS9WOsVAgGr6Ok1wKVYmx1si3IW/8zJlisQvLwdqqP5YevFYkuP3B/CBA== X-Received: by 2002:a05:6000:1ac8:b0:385:e8ce:7483 with SMTP id ffacd0b85a97d-38a221e1fe1mr13473685f8f.4.1735036524644; Tue, 24 Dec 2024 02:35:24 -0800 (PST) Received: from [10.50.4.206] (bzq-84-110-32-226.static-ip.bezeqint.net. [84.110.32.226]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a1c89e375sm14014339f8f.73.2024.12.24.02.35.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Dec 2024 02:35:24 -0800 (PST) Message-ID: Date: Tue, 24 Dec 2024 12:35:23 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/3] nvme: handle connectivity loss in nvme_set_queue_count To: Daniel Wagner , Hannes Reinecke Cc: Daniel Wagner , James Smart , Keith Busch , Christoph Hellwig , Paul Ely , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org References: <20241129-nvme-fc-handle-com-lost-v3-0-d8967b3cae54@kernel.org> <20241129-nvme-fc-handle-com-lost-v3-3-d8967b3cae54@kernel.org> Content-Language: en-US From: Sagi Grimberg In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 17/12/2024 10:35, Daniel Wagner wrote: > On Fri, Nov 29, 2024 at 12:10:33PM +0100, Hannes Reinecke wrote: >>> + /* >>> + * It's either a kernel error or the host observed a connection >>> + * lost. In either case it's not possible communicate with the >>> + * controller and thus enter the error code path. >>> + */ >>> + if (status < 0 || status == NVME_SC_HOST_PATH_ERROR) >>> return status; >>> /* >>> >> Hmm. Maybe checking for NVME_SC_DNR, too? > if no one complains I'll update the check to: > > if (status < 0 || (status > 0 && (status & NVME_STATUS_DNR)) || > status == NVME_SC_HOST_PATH_ERROR) > return status; > > okay? Why do we care about the DNR? are you going to retry based on it?