From: Krzysztof Kozlowski <krzk@kernel.org>
To: Rosen Penev <rosenp@gmail.com>, linux-usb@vger.kernel.org
Cc: "Florian Fainelli" <florian.fainelli@broadcom.com>,
"Hauke Mehrtens" <hauke@hauke-m.de>,
"Rafał Miłecki" <zajec5@gmail.com>,
"Broadcom internal kernel review list"
<bcm-kernel-feedback-list@broadcom.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"moderated list:BROADCOM BCM5301X ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCHv3 0/2] usb: bcma: control VBUS via a regulator
Date: Fri, 25 Sep 2026 08:54:33 +0200 [thread overview]
Message-ID: <feeed1f5-0e82-4b6f-8640-f38f3a892d20@kernel.org> (raw)
In-Reply-To: <20260924233831.127617-1-rosenp@gmail.com>
On 25/09/2026 01:38, Rosen Penev wrote:
> bcma-hcd currently drives the USB power line by grabbing the
> undocumented "vcc-gpio" property from the controller node and poking
> it through gpiolib. Besides relying on a non-standard binding, this
> cannot work on boards such as the NETGEAR R7000 and R8000 where one
> chipcommon GPIO powers both the USB2 and USB3 cores: the two
> controllers each request that GPIO exclusively, so the second one
> fails with -EBUSY and its port stays dead.
>
> Instead, switch the driver to the standard regulator interface and
> express the power rails as regulator-fixed nodes bound to the
> chipcommon GPIOs. The regulator core reference-counts enable/disable
> requests, letting both controllers share one GPIO without conflicts.
Please use standard email subjects, so with the PATCH keyword in the
title. `git format-patch -vX` helps here to create proper versioned
patches. Another useful tool is b4. Skipping the PATCH keyword makes
filtering of emails more difficult thus making the review process less
convenient.
Almost all your patches for months now do everything to escape my filters.
Best regards,
Krzysztof
prev parent reply other threads:[~2026-09-25 6:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-24 23:38 Rosen Penev
2026-09-24 23:38 ` [PATCHv3 1/2] usb: bcma: add regulator support Rosen Penev
2026-09-24 23:38 ` [PATCHv3 2/2] ARM: dts: broadcom: model USB VBUS power with regulator-fixed Rosen Penev
2026-09-25 6:54 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=feeed1f5-0e82-4b6f-8640-f38f3a892d20@kernel.org \
--to=krzk@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=florian.fainelli@broadcom.com \
--cc=gregkh@linuxfoundation.org \
--cc=hauke@hauke-m.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh@kernel.org \
--cc=rosenp@gmail.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®