From: Sandipan Das <sandipan.das@amd.com>
To: Ian Rogers <irogers@google.com>
Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
x86@kernel.org, peterz@infradead.org, mingo@redhat.com,
acme@kernel.org, mark.rutland@arm.com,
alexander.shishkin@linux.intel.com, jolsa@kernel.org,
namhyung@kernel.org, adrian.hunter@intel.com, tglx@linutronix.de,
bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com,
eranian@google.com, ananth.narayan@amd.com,
ravi.bangoria@amd.com, santosh.shukla@amd.com
Subject: Re: [PATCH 6/6] perf vendor events amd: Add Zen 4 memory controller events
Date: Thu, 20 Jul 2023 10:53:03 +0530 [thread overview]
Message-ID: <fef0492b-60c3-70ea-c7f1-370bf2734fc3@amd.com> (raw)
In-Reply-To: <CAP-5=fX1NQzus3MQapmBrdgEhDG4+XmawgytfugHHOKD0E-COg@mail.gmail.com>
On 7/19/2023 9:42 PM, Ian Rogers wrote:
> On Tue, Jul 18, 2023 at 11:58 PM Sandipan Das <sandipan.das@amd.com> wrote:
>>
>> Make the jevents parser aware of the Unified Memory Controller (UMC) PMU
>> and add events taken from Section 8.2.1 "UMC Performance Monitor Events"
>> of the Processor Programming Reference (PPR) for AMD Family 19h Model 11h
>> processors. The events capture UMC command activity such as CAS, ACTIVATE,
>> PRECHARGE etc. while the metrics derive data bus utilization and memory
>> bandwidth out of these events.
>>
>> Signed-off-by: Sandipan Das <sandipan.das@amd.com>
>
> Acked-by: Ian Rogers <irogers@google.com>
>
>> ---
>> .../arch/x86/amdzen4/memory-controller.json | 101 ++++++++++++++++++
>> .../arch/x86/amdzen4/recommended.json | 84 +++++++++++++++
>> tools/perf/pmu-events/jevents.py | 2 +
>> 3 files changed, 187 insertions(+)
>> create mode 100644 tools/perf/pmu-events/arch/x86/amdzen4/memory-controller.json
>>
>> diff --git a/tools/perf/pmu-events/arch/x86/amdzen4/memory-controller.json b/tools/perf/pmu-events/arch/x86/amdzen4/memory-controller.json
>> new file mode 100644
>> index 000000000000..55263e5e4f69
>> --- /dev/null
>> +++ b/tools/perf/pmu-events/arch/x86/amdzen4/memory-controller.json
>> @@ -0,0 +1,101 @@
>> +[
>> + {
>> + "EventName": "umc_mem_clk",
>> + "PublicDescription": "Number of memory clock cycles.",
>> + "EventCode": "0x00",
>> + "PerPkg": "1",
>> + "Unit": "UMCPMC"
>
> nit: Why use UMCPMC and then rewrite to amd_umc, why not just use "amd_umc" ?
>
I followed the convention that has been historically used for AMD uncore PMUs e.g.
the "Unit" for amd_df is "DFPMC" and for amd_l3 is "L3PMC". I do agree that its
simpler to use the same naming so will change this. If you prefer, I can send out
a separate patch to change the unit naming for amd_df and amd_l3.
- Sandipan
next prev parent reply other threads:[~2023-07-20 5:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-19 6:55 [PATCH 0/6] perf/x86/amd: Add " Sandipan Das
2023-07-19 6:55 ` [PATCH 1/6] perf/x86/amd/uncore: Refactor uncore management Sandipan Das
2023-07-19 6:55 ` [PATCH 2/6] perf/x86/amd/uncore: Use rdmsr if rdpmc is unavailable Sandipan Das
2023-07-19 6:55 ` [PATCH 3/6] x86/cpuid: Add smp helper Sandipan Das
2023-07-19 7:28 ` Peter Zijlstra
2023-07-19 7:37 ` Sandipan Das
2023-07-19 7:29 ` Thomas Gleixner
2023-07-19 7:35 ` Sandipan Das
2023-07-19 11:50 ` Thomas Gleixner
2023-07-19 11:59 ` Sandipan Das
2023-07-19 6:55 ` [PATCH 4/6] perf/x86/amd/uncore: Add group exclusivity Sandipan Das
2023-07-19 6:55 ` [PATCH 5/6] perf/x86/amd/uncore: Add memory controller support Sandipan Das
2023-07-19 6:55 ` [PATCH 6/6] perf vendor events amd: Add Zen 4 memory controller events Sandipan Das
2023-07-19 16:12 ` Ian Rogers
2023-07-20 5:23 ` Sandipan Das [this message]
2023-07-20 15:50 ` Ian Rogers
2023-07-21 5:15 ` Sandipan Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fef0492b-60c3-70ea-c7f1-370bf2734fc3@amd.com \
--to=sandipan.das@amd.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=ananth.narayan@amd.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=eranian@google.com \
--cc=hpa@zytor.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@amd.com \
--cc=santosh.shukla@amd.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome