From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A726F1E49B for ; Tue, 4 Jun 2024 13:35:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717508107; cv=none; b=Acfj89hIHHlN+hF89yIObT60NB2XstqD1b8xTksvuDP+7tdUsJXqVKsv4cPOACWWtfWlNb/dE8WwenvwRmOvLPhgetQ8hNnQ5bFPnRyFhNTgqXNpoPsuVP5U4pj26p5dvjvolC0zqM5PEFons9b2F3WjgpDVWZILht5thqD/JSg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717508107; c=relaxed/simple; bh=nasLksMnEw6MDMxJWquEaeLC3q+0uBOVSFCqlL1Rmpk=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=nH0FHbFaZ0VxLyrGeGzrDi2ZvEhxxhCQxTexhaO9Tvms3o44WDVzl/zs6+9mWfZN7X2OhT76jN2v/MLL+pXiBFyff2kE6NSR5tP9UPWUpXXqI4swxXhw0iaMZASYzxXIAPlGD92c4B7qpcLvhVJF6v3vYTe9CTRnToSBORdXIFI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=KmVmPJq2; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="KmVmPJq2" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4549Z73C016553; Tue, 4 Jun 2024 13:34:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 0jLLALqVjeVkMMFDpHFOvuM2e8qb7uiNDJQSP8rJQr4=; b=KmVmPJq2ve0blTRm li6vKgX3qkuUC0EKIW5Qe/KSGd3cJ0duLDkUXaWmDkkv01koWULxZ7jm4Zqep0oV NxtlHoFB0bcmL9uBS82+4d1De8oRKkGfYDnkBAZJ2R+EF9nRPKiaWmFM7FBy16YF 8kbFGeLNd+adz7EBPh3ekdJDJTuIXbVq685j/k0jVJqcoLBThoBU5/opdW/JNshD 9gDvFw+n+ObaJt+LbsOkgJvASUjdVnSqciR4nOpeev1PsEHkOxTyILFMwX17AdJM rveoBzf8N8E5vcntVHxnaf3LZH3kbv0XDHgsZN5vusFQvoxrRNv4zpRQRzRVVElW fIkG0g== Received: from nalasppmta02.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3yfw59pkkx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 04 Jun 2024 13:34:42 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 454DYejQ013553 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 4 Jun 2024 13:34:40 GMT Received: from [10.81.24.74] (10.49.16.6) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Tue, 4 Jun 2024 06:34:40 -0700 Message-ID: Date: Tue, 4 Jun 2024 06:34:38 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 12/22] wifi: ath11k: Use iommu_paging_domain_alloc() Content-Language: en-US To: Lu Baolu , Joerg Roedel , Will Deacon , Robin Murphy , Jason Gunthorpe , Kevin Tian CC: Yi Liu , David Airlie , Daniel Vetter , Kalle Valo , Bjorn Andersson , Mathieu Poirier , Alex Williamson , , Jason Wang , Thierry Reding , Jonathan Hunter , Mikko Perttunen , , , References: <20240604015134.164206-1-baolu.lu@linux.intel.com> <20240604015134.164206-13-baolu.lu@linux.intel.com> From: Jeff Johnson In-Reply-To: <20240604015134.164206-13-baolu.lu@linux.intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nalasex01b.na.qualcomm.com (10.47.209.197) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: 2pYV50EsBSx6DhkRfDuE1hUfut1Z7Ulg X-Proofpoint-ORIG-GUID: 2pYV50EsBSx6DhkRfDuE1hUfut1Z7Ulg X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-06-04_05,2024-06-04_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 malwarescore=0 spamscore=0 lowpriorityscore=0 priorityscore=1501 suspectscore=0 adultscore=0 clxscore=1011 mlxlogscore=999 bulkscore=0 phishscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2405170001 definitions=main-2406040108 On 6/3/24 18:51, Lu Baolu wrote: > An iommu domain is allocated in ath11k_ahb_fw_resources_init() and is > attached to ab_ahb->fw.dev in the same function. > > Use iommu_paging_domain_alloc() to make it explicit. > > Signed-off-by: Lu Baolu Acked-by: Jeff Johnson > --- > drivers/net/wireless/ath/ath11k/ahb.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath11k/ahb.c b/drivers/net/wireless/ath/ath11k/ahb.c > index ca0f17ddebba..a469647719f9 100644 > --- a/drivers/net/wireless/ath/ath11k/ahb.c > +++ b/drivers/net/wireless/ath/ath11k/ahb.c > @@ -1001,10 +1001,10 @@ static int ath11k_ahb_fw_resources_init(struct ath11k_base *ab) > > ab_ahb->fw.dev = &pdev->dev; > > - iommu_dom = iommu_domain_alloc(&platform_bus_type); > - if (!iommu_dom) { > + iommu_dom = iommu_paging_domain_alloc(ab_ahb->fw.dev); > + if (IS_ERR(iommu_dom)) { > ath11k_err(ab, "failed to allocate iommu domain\n"); > - ret = -ENOMEM; > + ret = PTR_ERR(iommu_dom); > goto err_unregister; > } >