From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 330D214A60C for ; Wed, 17 Dec 2025 20:32:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766003579; cv=none; b=LvyVxqbe0RwItb5Rddw2SYP7580Yz8abfsLifWZwFgyZ6RYE+DFznDZAB37clLi6ctkIucyKyxN1d0ovNuwN4T7f+0OV1nVlT/m7UsD65s92XoEJsy2VqzK/aAl0ESBgK87tTTu8qHGEPKCs/gji5bFsTW1lg7IQ1GMVhueBpss= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766003579; c=relaxed/simple; bh=aUNMUHIIoASXlei+fwcpCBA75RzFdLQiQYCADrUkTkY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bclRMjcU0osnI6vosQ64MpzhYEo4RTVM1lZZj/uxNgVv14bRl1GoS1cwc/9Z+DEWEenUG8D/rqJiIvBZtZLhNMijdM6eNBcUsxyjMgfChmnuReUkCKcBmHTAM7kafdh5UawVDTrLhhS6sXJOsM49DBhWJzT2Ip82KBrRAaJSaU0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mBwyOI3o; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mBwyOI3o" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-477b91680f8so60691215e9.0 for ; Wed, 17 Dec 2025 12:32:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766003574; x=1766608374; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jQt3q086rvOT4nnXw3lmARg1LijJJEzAF5b58emB02A=; b=mBwyOI3oPTSDUcrcMfRBNOGh6kqEQsi4nakzRDtcTL5mMmQogVox6JLTiTsj7lSd2w cgmSaN5j5cZCOAwWzwl+CLkG7quIyzVSTJzNGG9a512rbyzBOQlkakAx5upBbYqwErtg GzdjvIzXP0W2vnGeh0PzpS5/s4kaRsEKg8V/CO58eFhfUQ8+hOfFw101finPWDL1jj/K RfgM88/4zE+nyRv3yGoX/fq1vcB2miyImaRH0Q58MvWPvclBIcFaBpiRRds6anTGvZeI tVGho9Usx5HzUAIwWkYkcob1jfsqMwN9w8REQ2OCgyEHUkszdukj/88SotKzgCHTpwXU zqfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766003574; x=1766608374; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jQt3q086rvOT4nnXw3lmARg1LijJJEzAF5b58emB02A=; b=ANn/9xYVxZvx2NZHE57BETuqLamMb8f9t4JmRfQZs0GH/XEIQnc94i62nxVxHj8uM2 6cAo0hDa4SXcJLKbvyUBDIlqIQlKNoeq6OJ2Rwp5yB0z5AupDfOwwSIaAPAokBR0z9c8 tQhoMRuAU2F475pJYNZhWaUQBK6QjGz3hmJaTRvaa86rS3sWmx63hdj6Oubm+e0qm8TO HRuF+UYVia6mnu/B7Cer9yhD1kod9jDDYIZ7phPWMeiRUTxGJGQBxfb2clDSqm4DN6Aj 8j5XhzlvQqvB5pwCHRuhA4Dnu2bmQDLHfMTGQnwQ1xBTUDeqDY6PHsRWv4BQm03D1d+o INxw== X-Forwarded-Encrypted: i=1; AJvYcCWeIlImZtMt46Vxkrs+FJUdUD/LKyXD2S2G4PYmJvDlpwibfiC2pbkIgrKnE/uhTf6/eSL2HYg+BK/wOs8=@vger.kernel.org X-Gm-Message-State: AOJu0YzCJFtwWuWVxecaXlYPSD84M0pr06FwX3v8OIV6SMWeFqAEGdX4 oJHscI/D2fTks+6lIpGMNxViO/C4RrAjOVY6AKI7FyeQB7HHI9Itzzv4 X-Gm-Gg: AY/fxX6E6rVoJXPZPQeEQGJ2q9dt1adtPGVlDnj2zXZ8MIkXbQSSGlxd37wnFSy16Jf Rr8DitnOoyHZgu7lUo/5PfP6PkEusMZWfdqDNpzuxGWyMA5ZVZBl3EUZBRERSwjuoQ4Ob4JU9J4 Bl/eWA+NuHQ2d28DATkJSW1ivCtQANQy83R79Hfwel9pa28WGBZCZPQMeuSdPi3VD4WQxlOaO2c epoQ+aPSsnW12ZKDBEbe6lLg0zLYN66Ax9guqRN6WlYpllJMo6JSzxWj4IIxbptVHFYEGafEYiT n5Y3NVCriAmVGE4PnXpf6w8tqyaKU3TXZfiLSrvEKhlYCn/nJSjGcoeHZ0U6+j7Qnz4x4k/uy9p LrxQzKs6f6AIRYKNYuB0jEOtGk5Hin8Wp6xrPcWXTZIf9ISa0XyE/lJluVrRhNk8CDEld+Si9q2 MzQrwqtdlOiIuIi08QWHd/dWs0jilRWhIuY6qNoJY2lFHoO1twsysWbsS4N0FXjA== X-Google-Smtp-Source: AGHT+IGXb+yQoXclj0b19HsbDMfCYnt9Xpj/oanIbUU5itPqm1lthwf6uvz1OWdzvEig234aityGNA== X-Received: by 2002:a05:600c:4e91:b0:477:c37:2ea7 with SMTP id 5b1f17b1804b1-47a8f904609mr201528785e9.21.1766003574227; Wed, 17 Dec 2025 12:32:54 -0800 (PST) Received: from [192.168.20.170] (5D59A51C.catv.pool.telekom.hu. [93.89.165.28]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47be3a6c6ebsm176475e9.4.2025.12.17.12.32.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Dec 2025 12:32:53 -0800 (PST) Message-ID: Date: Wed, 17 Dec 2025 21:32:55 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] regulator: qcom_smd: change MP5496 supply names Content-Language: hu To: Konrad Dybcio , Liam Girdwood , Mark Brown , Varadarajan Narayanan , Devi Priya , Praveenkumar I , Konrad Dybcio , Kathiravan T Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251216-qcom_smd-mp5496-supply-fix-v1-1-f9b5e70536de@gmail.com> <680d3b17-7983-4522-89b9-13ad67f4bfe4@oss.qualcomm.com> From: Gabor Juhos In-Reply-To: <680d3b17-7983-4522-89b9-13ad67f4bfe4@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hi Konrad, 2025. 12. 17. 11:30 keltezéssel, Konrad Dybcio írta: > On 12/16/25 7:38 PM, Gabor Juhos wrote: >> In case of the MP5496 regulators, the driver uses the same name both for >> the regulator and for its supply. Due to this, in some cases the supply >> gets resolved to the regulator itself, and the regulator core code throwns >> an error message. >> >> For example, booting the kernel with the 'ipq9574-rdp433' device tree, >> results in the following message in the log: >> >> [ 1.710392] qcom_rpm_smd_regulator remoteproc:glink-edge:rpm-requests:regulators: Supply for s1 (s1) resolved to itself >> >> Additionally, the driver uses different supply names for the 's2' and for >> the 'l2' regulators which is incorrect. Here is the supply map based on the >> datasheet of the MP5496: >> >> VIN1 -> Buck1 >> VIN2 -> Buck2, LDO2, LDO3 >> VIN3 -> Buck3 >> VIN4 -> Buck4 >> VIN5 -> LDO4, LDO5 > > One thing this reveals is that there's an LDO3 and an LDO4 which > we don't describe today.. The same is true for Buck3 and Buck4 too. > are they managed as power-domains, or are there other other reasons? Unfortunately, I don't know the exact reason. I have no detailed hardware information about the reference boards, but it seems that it depends on what is supported by the actual RPM firmware on the board. For example, currently I have this RPM version on my IPQ9574 based board: # cat /sys/kernel/debug/qcom_socinfo/rpm/name 03:RPM.BF.2.4.1-00116 # cat /sys/kernel/debug/qcom_socinfo/rpm/oem CRM # cat /sys/kernel/debug/qcom_socinfo/rpm/variant CAAAANAAR This version does not even support LDO5. At least, trying to use that results in the following error: [ 2.120281] l5: Bringing 0uV into 1800000-1800000uV [ 2.127721] l5: failed to enable: -ENXIO In this special case, the -ENXIO error code comes from qcom_smd_rpm_callback() and it means that the resource does not exists. So my guess is that the undescribed regulators are simply not used on the boards supported currently. Regards, Gabor