From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C7BC18E361 for ; Mon, 13 Jan 2025 13:05:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736773549; cv=none; b=LpVLojIuj5IIBzyq9H9y8TAdL5gQKG+nR3/W0U3Dlt6aoHznvqQQCW3TAxMcbdJahjOZTJi9PWWgkLI2I6hHoCpbn5ieWcJa9WmUUaLP08FolhdN4ABMllQtmMD728bEE8DpCjkPHQsX1qjywic8X2LTWJt25MTnRXQXMTuXpM8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736773549; c=relaxed/simple; bh=bqOeFlRj4R9EheREIUE4oRKEkY0+D53ky232IREJVX0=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=Sxk1z+ONugvQ5KY28gIfJPDUN5znx6nVvY98laqcIS7aC04vOgCyvpBw9Yuxr8SG1TJXFrWKQ0Zo2qvYxsdXcs/rcuoAc1BvE46BzTocxwzpwDqxSLhgzzaZD95W37IZnlaEHmnSHuqAmwHFG0xy7mA+Jp6iCb0ZcFXopCCGUOE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=kRA83pLZ; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="kRA83pLZ" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-436246b1f9bso5674515e9.1 for ; Mon, 13 Jan 2025 05:05:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1736773546; x=1737378346; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=kWJosQxppl/LButOmLsCXsOURqYTt3fhYwtWT4WdU2Y=; b=kRA83pLZ+y5u+apGmy4PRONyB9x9uChON0MxXPmnsD6fvQAtmSMiFanC00AoTV+QLK MKAbTbp/AJMiD6qfdgb+Q+vTzGoQoCx4ljSTMIqgtJHv4/DcFtX9Wvs+Vt58Nf3lGeWN aD/A0OlN2667fJ3EoF9xdTcUcIB6vhZ4b5C/eV5YW+nakGG9KTy3rpXWYUT94920GcRL fY7QUzgbksFJD3vnDJx07wGlK+wFkl6bkz8Ac/0sbBbhNx/7yMqG0Dh+mlEkX6HsOTf7 xMa/ehwrGK0uU33ImyzVHBPygOAPpP/wMBCAY1z3PBD77+Xvbtz6bFfkougAm51c+IHM rQsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736773546; x=1737378346; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kWJosQxppl/LButOmLsCXsOURqYTt3fhYwtWT4WdU2Y=; b=VFpStGs500p8JeCT/4gJ0GcmOJyDPrkmHvH4dbFhaXOAh+NVUbQK/xhB+oiLTFlvEe sA+fuqrrzkeW8eVURrLangSH7HIcz+l559EoLXs4u0YEIMZVUnhhBe+g6M08QGFkId4f B2jbGPrgIMyFQidDXqvb3uibhiooO/G1aS3azrHAl+B3W3e54yBG5L4KS8mqaP+yYaba K+nj9tzQ+/VwixrIZkfkEvA/jtebMFTWz1fKLWcXDeWa8szYP5gKERQex9uf2cRCJwFt lXhguBqKDPfYT9anSKnRStx1b5zscwcNEmvmXmG04h968ivOpxkg0TjiX0Xs1yjcUgDu Xd8A== X-Forwarded-Encrypted: i=1; AJvYcCVma0LBFQHmcCNoqEHljdogtbf3aNg9NgpCNTVzmFhNmSubRX76reEjyGQy2Y0sqyUCYdyAqQ89mhBda/k=@vger.kernel.org X-Gm-Message-State: AOJu0Yw8qNIZEWVq2VejaoJrcw+HIQuuo+m8b5mtx+VFA7YhpYyM61Js Cn7q8DsBwok/qVD7VVFvX1Mv9Q1GQnj5l37GCI73d2/0utBW3B9XqFR5tK7r1x8= X-Gm-Gg: ASbGncuy5PKA2o180FLeyXjlu9nz2FXTqJrOE5faEuQdH+CxRs+h6saACLOB6z6U6ka qRuwFowuUleGtseOoCK6aSfMocjLkAnI7tmvdXTWcJoY47jC4wx375RPVBsDmqUe4baxVJnm9ti wj1t/TkebQjbfODpmUJAL2D8DvWzBHzdNCq7aVT731yVMNIz4pntRPf/A3wEVKv4wIv+/RNO8j8 GTQiRXdJnrnMbWn2uGkLxQJx+5g1KipW69C1juH76Om3XjF+loUXNsaTBvDifYtcbIgx0vWP0n+ X-Google-Smtp-Source: AGHT+IFQoL1eqWZUzLXO8xn5aiYWFXQjNuPE/7Kefiqj01sIwoayBrPT0tSc64kY0x+XJrkSFZxmQg== X-Received: by 2002:a05:600c:1d07:b0:436:1902:23b5 with SMTP id 5b1f17b1804b1-436e26f4abbmr73098815e9.4.1736773546344; Mon, 13 Jan 2025 05:05:46 -0800 (PST) Received: from [192.168.1.20] ([178.197.223.165]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-436e2da66d9sm179163385e9.1.2025.01.13.05.05.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Jan 2025 05:05:45 -0800 (PST) Message-ID: Date: Mon, 13 Jan 2025 14:05:43 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] drm/mediatek/hdmi: Use syscon_regmap_lookup_by_phandle_args To: AngeloGioacchino Del Regno , Chun-Kuang Hu , Philipp Zabel , David Airlie , Simona Vetter , Matthias Brugger , dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20250112134708.46100-1-krzysztof.kozlowski@linaro.org> <516d16e3-6fc6-49ba-a0ce-f451b65a6c1a@collabora.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <516d16e3-6fc6-49ba-a0ce-f451b65a6c1a@collabora.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 13/01/2025 13:41, AngeloGioacchino Del Regno wrote: > Il 12/01/25 14:47, Krzysztof Kozlowski ha scritto: >> Use syscon_regmap_lookup_by_phandle_args() which is a wrapper over >> syscon_regmap_lookup_by_phandle() combined with getting the syscon >> argument. Except simpler code this annotates within one line that given >> phandle has arguments, so grepping for code would be easier. >> >> There is also no real benefit in printing errors on missing syscon >> argument, because this is done just too late: runtime check on >> static/build-time data. Dtschema and Devicetree bindings offer the >> static/build-time check for this already. >> > > I agree with this change but can you please rebase it over [1]? > > The same code got migrated to mtk_hdmi_common.c instead :-) > > [1]: > https://lore.kernel.org/r/20250108112744.64686-1-angelogioacchino.delregno@collabora.com My is 2-patch cleanup, your is 34 patch rework and new features with existing build reports, so rebase is not reasonable. It would make this 2-patch cleanup wait for many cycles. Best regards, Krzysztof