From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: <thierry.reding@gmail.com>, <airlied@linux.ie>, <daniel@ffwll.ch>,
<devicetree@vger.kernel.org>, <tomi.valkeinen@ti.com>,
<robh+dt@kernel.org>, <linux-kernel@vger.kernel.org>,
<dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 4/4] drm/panel: Add OSD101T2587-53TS driver
Date: Wed, 20 Feb 2019 12:39:11 +0200 [thread overview]
Message-ID: <fefcd92c-4171-ed86-28d2-4145d409a73d@ti.com> (raw)
In-Reply-To: <20190215180759.GA26944@ravnborg.org>
Hi Sam,
On 15/02/2019 20.07, Sam Ravnborg wrote:
>> +#include <linux/backlight.h>
>> +#include <linux/module.h>
>> +#include <linux/of.h>
>> +#include <linux/regulator/consumer.h>
>> +
>> +#include <drm/drmP.h>
> Please do not use drmP.h in new drivers - we try to get rid of this file.
...
>> +static int osd101t2587_panel_get_modes(struct drm_panel *panel)
>> +{
>> + struct osd101t2587_panel *osd101t2587 = to_osd101t2587_panel(panel);
>> + struct drm_display_mode *mode;
>> +
>> + mode = drm_mode_duplicate(panel->drm, osd101t2587->default_mode);
>> + if (!mode) {
>> + dev_err(panel->drm->dev, "failed to add mode %ux%ux@%u\n",
drm/drmP.h is needed for this dev_err.
Regards,
- Péter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
next prev parent reply other threads:[~2019-02-20 10:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-15 14:03 [PATCH 0/4] drm/panel: Support for OSD101T2045-53TS and OSD101T2587-53TS Peter Ujfalusi
2019-02-15 14:03 ` [PATCH 1/4] dt-bindings: display: Add bindings for OSD101T2045-53TS Peter Ujfalusi
2019-02-15 14:03 ` [PATCH 2/4] drm/panel: simple: Add support " Peter Ujfalusi
2019-02-15 14:03 ` [PATCH 3/4] dt-bindings: display: Add bindings for OSD101T2587-53TS panel Peter Ujfalusi
2019-02-15 14:03 ` [PATCH 4/4] drm/panel: Add OSD101T2587-53TS driver Peter Ujfalusi
2019-02-15 18:07 ` Sam Ravnborg
2019-02-20 10:34 ` Peter Ujfalusi
2019-02-20 12:41 ` Sam Ravnborg
2019-02-20 10:39 ` Peter Ujfalusi [this message]
2019-02-20 11:52 ` Sam Ravnborg
2019-02-20 12:06 ` Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fefcd92c-4171-ed86-28d2-4145d409a73d@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome