From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06A51145A16 for ; Thu, 23 Jan 2025 11:22:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737631354; cv=none; b=pZX+13vxlU88Hcbpi+rnOVdteZIdINhQaVnXdBRCsMOo/2RwoNevzhwZIJ1sVD9mc4iBij8J2OmwWkN3pdpNuC8rsvLNA7q71Ei5w5fHC/RPRCLKRUhB07v3HdKQV2K8+9xUsWQuhFnSlzf0LKjQQ9gUpszrVho5Jw7XEn87zQw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737631354; c=relaxed/simple; bh=LR5n9GkVxfTaElMok3QnHOYgkrzpHmgjrAqxzgax9wI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=P2HxmL8AVN8YtIXHJ6qdhJLQQfQ2T+Io0sWtHgo8M/hzmil+qBNfWtom7FHW5m7eHcwqO3HVCkzh6PllE1odABQ/RxvNO4pvkf0oBf6Qb8aUiq6+FXNHYNVmkJFBB7e/aZUMlbMoeo9VKwnqLivO3EHTypqdUQZK/1w7Btlna4o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=joON4YHz; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="joON4YHz" Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 50N3oIZI017109; Thu, 23 Jan 2025 11:22:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=LR5n9G kVxfTaElMok3QnHOYgkrzpHmgjrAqxzgax9wI=; b=joON4YHz6ebOzUVJuOrRsG DkxS3E+mhHEuMuTrLsNpXoGT640d2UfyO1Ul6uQY4vhoPPv8npp8X2mOZ9uEr126 ghLAkD/CKN45+QX62ASfoyvBY/jbIu/nCBpOpRMW1LHcbqquPN1MNa/Zz338ojv6 9F/lZvfm20Vxu83SvnNGXwSDGuptAo3w++8gJWDfhn80nC6C/cUoSZAeTuic/4FV eTT8rmV+USxMpVxK2vuTS9FTssWrcLbSMPwN5l0D0qHH69mjRqXFl6ameBaryB5M t6ywnom2cKi6pQRskil2fBBkunlgMWFwRP+LToLyQ7FHjf82uMY+Brkjny7ISzQA == Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 44b3gtvpq9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 23 Jan 2025 11:22:17 +0000 (GMT) Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 50N7fXNx029594; Thu, 23 Jan 2025 11:22:16 GMT Received: from smtprelay04.fra02v.mail.ibm.com ([9.218.2.228]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 448qmnn8vy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 23 Jan 2025 11:22:16 +0000 Received: from smtpav06.fra02v.mail.ibm.com (smtpav06.fra02v.mail.ibm.com [10.20.54.105]) by smtprelay04.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 50NBMCOD19530166 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 23 Jan 2025 11:22:12 GMT Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8A62B20049; Thu, 23 Jan 2025 11:22:12 +0000 (GMT) Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D259520040; Thu, 23 Jan 2025 11:22:10 +0000 (GMT) Received: from [9.109.204.94] (unknown [9.109.204.94]) by smtpav06.fra02v.mail.ibm.com (Postfix) with ESMTP; Thu, 23 Jan 2025 11:22:10 +0000 (GMT) Message-ID: Date: Thu, 23 Jan 2025 16:52:09 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/6] powerpc/kdump: preserve user-specified memory limit To: Hari Bathini , linuxppc-dev@lists.ozlabs.org Cc: Andrew Morton , Baoquan he , Madhavan Srinivasan , Michael Ellerman , kexec@lists.infradead.org, linux-kernel@vger.kernel.org, Mahesh Salgaonkar References: <20250121115442.1278458-1-sourabhjain@linux.ibm.com> <20250121115442.1278458-5-sourabhjain@linux.ibm.com> <43aeaa2c-c266-4d6e-921d-80b99ceb418b@linux.ibm.com> Content-Language: en-US From: Sourabh Jain In-Reply-To: <43aeaa2c-c266-4d6e-921d-80b99ceb418b@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: cmluhe-W408j1Z0_tx81-oGiE3ZSFkxB X-Proofpoint-GUID: cmluhe-W408j1Z0_tx81-oGiE3ZSFkxB X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-01-23_04,2025-01-22_02,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 bulkscore=0 mlxscore=0 malwarescore=0 priorityscore=1501 lowpriorityscore=0 impostorscore=0 mlxlogscore=999 phishscore=0 spamscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2501230084 Hello Hari, On 23/01/25 16:00, Hari Bathini wrote: > > > On 21/01/25 5:24 pm, Sourabh Jain wrote: >> Commit 59d58189f3d9 ("crash: fix crash memory reserve exceed system >> memory bug") fails crashkernel parsing if the crash size is found to be >> higher than system RAM, which makes the memory_limit adjustment code >> ineffective due to an early exit from reserve_crashkernel(). >> >> Regardless lets not violated the user-specified memory limit by > > s/violated/violate/ Noted. It will be fixed in next version. > >> adjusting it. Remove this adjustment to ensure all reservations stay >> within the limit. Commit f94f5ac07983 ("powerpc/fadump: Don't update >> the user-specified memory limit") did the same for fadump. >> > > Acked-by: Hari Bathini Thanks for the Ack! - Sourabh Jain > >> Cc: Andrew Morton >> Cc: Baoquan he >> Cc: Hari Bathini >> CC: Madhavan Srinivasan >> Cc: Michael Ellerman >> Cc: kexec@lists.infradead.org >> Cc: linux-kernel@vger.kernel.org >> Reviewed-by: Mahesh Salgaonkar >> Signed-off-by: Sourabh Jain >> --- >>   arch/powerpc/kexec/core.c | 8 -------- >>   1 file changed, 8 deletions(-) >> >> diff --git a/arch/powerpc/kexec/core.c b/arch/powerpc/kexec/core.c >> index b8333a49ea5d..4945b33322ae 100644 >> --- a/arch/powerpc/kexec/core.c >> +++ b/arch/powerpc/kexec/core.c >> @@ -150,14 +150,6 @@ void __init reserve_crashkernel(void) >>           return; >>       } >>   -    /* Crash kernel trumps memory limit */ >> -    if (memory_limit && memory_limit <= crashk_res.end) { >> -        memory_limit = crashk_res.end + 1; >> -        total_mem_sz = memory_limit; >> -        printk("Adjusted memory limit for crashkernel, now 0x%llx\n", >> -               memory_limit); >> -    } >> - >>       printk(KERN_INFO "Reserving %ldMB of memory at %ldMB " >>               "for crashkernel (System RAM: %ldMB)\n", >>               (unsigned long)(crash_size >> 20), >