From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A6B5C47088 for ; Fri, 2 Dec 2022 22:20:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234828AbiLBWUV (ORCPT ); Fri, 2 Dec 2022 17:20:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234461AbiLBWUU (ORCPT ); Fri, 2 Dec 2022 17:20:20 -0500 Received: from mail-il1-x132.google.com (mail-il1-x132.google.com [IPv6:2607:f8b0:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 09C2BE8E26 for ; Fri, 2 Dec 2022 14:20:19 -0800 (PST) Received: by mail-il1-x132.google.com with SMTP id d14so2647410ilq.11 for ; Fri, 02 Dec 2022 14:20:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ieee.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=XbwRRbO5HZ0texwF0dw1j20ewkIulyg4TI01mh2rWro=; b=UnWWPkF2gG/H6UzceaTgRb3H4v/Sj333aGQxNdrY4fxU0neTBgS3ZijUOjusHqlUcx PRzFvPo6moBkGak0jupft9RW6lA+neAII1uIsya4wAStFRHJYdb2YdjUkoWbiXHDnTla NwgISB3mGIgyfXTKM2/j46dinSLTPjsIIhyus= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XbwRRbO5HZ0texwF0dw1j20ewkIulyg4TI01mh2rWro=; b=sQaWzQNssa5BURnjo0OQqkCBAJXIoATrL6nXp9K6N7gz2P0y7DfUazLfoXf0Jjtdpj WeY4yrqTIXazvR/STMSgp0QHsKRNctCE17Y7daozGSmZrXDmAKYAvh2cTq6/SxmUZ5O8 EHFVq03uBx+JSEQUrRIGEcKQvFEDfsIxPAl0WeEeuCGtrePd81pKhsfNbkl+a+TXyK9r AeuD4xZk1kZLuCiC3M8LlpqGP9nJXRkJYnEDYSMVZpYtDWA2WMU9taYmT46wTc74tEym wNsHuRoOv1/6eIoUMUjMm8QtdRRaOyZqVacXlb9GzauCNM73AHKYspUOPIFRgDZaGx9P WsAQ== X-Gm-Message-State: ANoB5pl64kiuacVUNNcfWSzhl4KOQRt+F5zxowe6Zi8lcxvJx5XSyZbh bwlOtYcMsc3IEI6ID9hhNiigUw== X-Google-Smtp-Source: AA0mqf7OvUqnk6aSmqTB+dIl8bs8dlsLWuzc24wNmTgp6rltz6BAC/fLnhVBabmRTetHJPoniu7Itg== X-Received: by 2002:a92:c5c5:0:b0:303:1215:ea9d with SMTP id s5-20020a92c5c5000000b003031215ea9dmr12824454ilt.242.1670019618260; Fri, 02 Dec 2022 14:20:18 -0800 (PST) Received: from [172.22.22.4] ([98.61.227.136]) by smtp.googlemail.com with ESMTPSA id cn23-20020a0566383a1700b00374bf3b62a0sm3099678jab.99.2022.12.02.14.20.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 Dec 2022 14:20:17 -0800 (PST) Message-ID: Date: Fri, 2 Dec 2022 16:20:16 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] net: ipa: use sysfs_emit() to instead of scnprintf() Content-Language: en-US To: ye.xingchen@zte.com.cn, davem@davemloft.net Cc: elder@kernel.org, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <202212021642142044742@zte.com.cn> From: Alex Elder In-Reply-To: <202212021642142044742@zte.com.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/2/22 2:42 AM, ye.xingchen@zte.com.cn wrote: > From: ye xingchen > > Follow the advice of the Documentation/filesystems/sysfs.rst and show() > should only use sysfs_emit() or sysfs_emit_at() when formatting the > value to be returned to user space. The buffer passed is non-null and the existing code properly limits the buffer to PAGE_SIZE. But... OK. Reviewed-by: Alex Elder > > Signed-off-by: ye xingchen > --- > drivers/net/ipa/ipa_sysfs.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/ipa/ipa_sysfs.c b/drivers/net/ipa/ipa_sysfs.c > index 5cbc15a971f9..14bd2f903045 100644 > --- a/drivers/net/ipa/ipa_sysfs.c > +++ b/drivers/net/ipa/ipa_sysfs.c > @@ -46,7 +46,7 @@ version_show(struct device *dev, struct device_attribute *attr, char *buf) > { > struct ipa *ipa = dev_get_drvdata(dev); > > - return scnprintf(buf, PAGE_SIZE, "%s\n", ipa_version_string(ipa)); > + return sysfs_emit(buf, "%s\n", ipa_version_string(ipa)); > } > > static DEVICE_ATTR_RO(version); > @@ -70,7 +70,7 @@ static ssize_t rx_offload_show(struct device *dev, > { > struct ipa *ipa = dev_get_drvdata(dev); > > - return scnprintf(buf, PAGE_SIZE, "%s\n", ipa_offload_string(ipa)); > + return sysfs_emit(buf, "%s\n", ipa_offload_string(ipa)); > } > > static DEVICE_ATTR_RO(rx_offload); > @@ -80,7 +80,7 @@ static ssize_t tx_offload_show(struct device *dev, > { > struct ipa *ipa = dev_get_drvdata(dev); > > - return scnprintf(buf, PAGE_SIZE, "%s\n", ipa_offload_string(ipa)); > + return sysfs_emit(buf, "%s\n", ipa_offload_string(ipa)); > } > > static DEVICE_ATTR_RO(tx_offload);