From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75CC3C2BA2B for ; Thu, 16 Apr 2020 07:27:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5EDCA21569 for ; Thu, 16 Apr 2020 07:27:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2439203AbgDPH13 (ORCPT ); Thu, 16 Apr 2020 03:27:29 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:39980 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2439002AbgDPH11 (ORCPT ); Thu, 16 Apr 2020 03:27:27 -0400 Received: from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 796BE80FCC6FEDB8FC34; Thu, 16 Apr 2020 15:27:25 +0800 (CST) Received: from [10.134.22.195] (10.134.22.195) by smtp.huawei.com (10.3.19.209) with Microsoft SMTP Server (TLS) id 14.3.487.0; Thu, 16 Apr 2020 15:27:24 +0800 Subject: Re: [PATCH] f2fs: Fix the accounting of dcc->undiscard_blks To: Sahitya Tummala , Jaegeuk Kim , CC: References: <1587017861-6454-1-git-send-email-stummala@codeaurora.org> From: Chao Yu Message-ID: Date: Thu, 16 Apr 2020 15:27:23 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1587017861-6454-1-git-send-email-stummala@codeaurora.org> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/4/16 14:17, Sahitya Tummala wrote: > When a discard_cmd needs to be split due to dpolicy->max_requests, then > for the remaining length it will be either merged into another cmd or a > new discard_cmd will be created. In this case, there is double > accounting of dcc->undiscard_blks for the remaining len, due to which > it shows incorrect value in stats. > > Signed-off-by: Sahitya Tummala Reviewed-by: Chao Yu Thanks,