From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12D61C433F5 for ; Wed, 13 Apr 2022 08:40:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233949AbiDMIm0 (ORCPT ); Wed, 13 Apr 2022 04:42:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51464 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234035AbiDMIlv (ORCPT ); Wed, 13 Apr 2022 04:41:51 -0400 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.154.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 29F3451E4E; Wed, 13 Apr 2022 01:38:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1649839128; x=1681375128; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=3jpw++PisIykZNdamU26KW5ExhnwU6YvVfJwxILHeGY=; b=FQzWivbvpE90ZISCdAmBlXxkoA5KWL67yNp2cDh4a1ZabqsOv2pDCqdY Bh5dW8GfWt5L2SrYP+WJ15WXdVIAPNIx6pPXRfiE3sXqGpUKwo0AQFE5a nEh5W1wDd3qQ0SjjVyiq2Vxt5G852NKT1JerHPZDoLuEIFaAxAb7OZBKD q9z8qwrGHlSuQsgTB9OFC2vtz+JDu27bBKeTnzZYMe3A2URt72T+Wwuq1 a56PCOpmYifHc64eN1IUr8U2l/WxxgKUITtkUY5CHYA+2hhN9k6WGP1CW bP9qWKZUr663V03VIJmXrprtSM0N03JtI4I4NVtr2jFyyq16T/u/QURGC w==; X-IronPort-AV: E=Sophos;i="5.90,256,1643698800"; d="scan'208";a="152490618" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa4.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 13 Apr 2022 01:38:46 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Wed, 13 Apr 2022 01:38:45 -0700 Received: from [10.12.72.146] (10.10.115.15) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server id 15.1.2375.17 via Frontend Transport; Wed, 13 Apr 2022 01:38:43 -0700 Message-ID: Date: Wed, 13 Apr 2022 10:38:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH] ARM: dts: at91: sama7g5ek: enable pull-up on flexcom3 console lines Content-Language: en-US To: Tudor Ambarus - M18064 , "Eugen Hristev - M18282" CC: "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Claudiu Beznea - M18063 , "robh+dt@kernel.org" References: <20220307113827.2419331-1-eugen.hristev@microchip.com> From: Nicolas Ferre Organization: microchip In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/03/2022 at 09:21, Tudor Ambarus - M18064 wrote: > On 3/7/22 13:38, Eugen Hristev wrote: >> Flexcom3 is used as board console serial. There are no pull-ups on these >> lines on the board. This means that if a cable is not connected (that has >> pull-ups included), stray characters could appear on the console as the >> floating pins voltage levels are interpreted as incoming characters. >> To avoid this problem, enable the internal pull-ups on these lines. >> >> Signed-off-by: Eugen Hristev > > Reviewed-by: Tudor Ambarus Acked-by: Nicolas Ferre and queued for "fixes". Thanks! Best regards, Nicolas > >> --- >> arch/arm/boot/dts/at91-sama7g5ek.dts | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm/boot/dts/at91-sama7g5ek.dts b/arch/arm/boot/dts/at91-sama7g5ek.dts >> index 08685a10eda1d..dd047a8523907 100644 >> --- a/arch/arm/boot/dts/at91-sama7g5ek.dts >> +++ b/arch/arm/boot/dts/at91-sama7g5ek.dts >> @@ -495,7 +495,7 @@ pinctrl_flx0_default: flx0_default { >> pinctrl_flx3_default: flx3_default { >> pinmux = , >> ; >> - bias-disable; >> + bias-pull-up; >> }; >> >> pinctrl_flx4_default: flx4_default { > -- Nicolas Ferre