From: Andrew Lunn <andrew@lunn.ch>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next v1 1/1] net: phy: dp83tg720: Add cable testing support
Date: Wed, 7 Aug 2024 15:24:52 +0200 [thread overview]
Message-ID: <ff096c1c-00bf-4e55-9400-fb869749b07f@lunn.ch> (raw)
In-Reply-To: <20240807093251.3308737-1-o.rempel@pengutronix.de>
On Wed, Aug 07, 2024 at 11:32:51AM +0200, Oleksij Rempel wrote:
> Introduce cable testing support for the DP83TG720 PHY. This implementation
> is based on the "DP83TG720S-Q1: Configuring for Open Alliance Specification
> Compliance (Rev. B)" application note.
Does the OA specification describe all these registers? Should we
expect other devices to be identical?
> +/**
> + * dp83tg720_get_fault_type - Convert TDR fault type to ethtool result code.
> + * @fault_type: Fault type value from the PHY.
> + *
> + * Returns: Corresponding ethtool result code.
> + */
> +static int dp83tg720_get_fault_type(int fault_type)
> +{
> + switch (fault_type) {
> + case DP83TG720S_TDR_FAULT_TYPE_SHORT:
> + return ETHTOOL_A_CABLE_RESULT_CODE_SAME_SHORT;
> + case DP83TG720S_TDR_FAULT_TYPE_OPEN:
> + return ETHTOOL_A_CABLE_RESULT_CODE_OPEN;
> + case DP83TG720S_TDR_FAULT_TYPE_NOISE:
> + return ETHTOOL_A_CABLE_RESULT_CODE_UNSPEC;
You could add a new type for this. I think some implementations will
also re-try a few times to see if a quiet period can be found.
Andrew
next prev parent reply other threads:[~2024-08-07 13:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-07 9:32 Oleksij Rempel
2024-08-07 11:10 ` Oleksij Rempel
2024-08-07 13:24 ` Andrew Lunn [this message]
2024-08-08 8:16 ` Oleksij Rempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff096c1c-00bf-4e55-9400-fb869749b07f@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®