From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Mark Brown <broonie@kernel.org>
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Banajit Goswami <bgoswami@quicinc.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/4] ASoC: codecs: wcd9335: Simplify with dev_err_probe
Date: Tue, 18 Apr 2023 15:07:37 +0200 [thread overview]
Message-ID: <ff0f4871-4d26-e671-0239-fa47117381a0@linaro.org> (raw)
In-Reply-To: <63a3b1c7-a68a-496c-99fe-9c936f4ebd94@sirena.org.uk>
On 18/04/2023 14:55, Mark Brown wrote:
> On Tue, Apr 18, 2023 at 09:46:27AM +0200, Krzysztof Kozlowski wrote:
>> Replace dev_err() in probe() path with dev_err_probe() to:
>> 1. Make code a bit simpler and easier to read,
>> 2. Do not print messages on deferred probe.
>
>> */
>> wcd->intr1 = of_irq_get_byname(wcd->dev->of_node, "intr1");
>> - if (wcd->intr1 < 0) {
>> - if (wcd->intr1 != -EPROBE_DEFER)
>> - dev_err(wcd->dev, "Unable to configure IRQ\n");
>> -
>> - return wcd->intr1;
>
> This is already not printing a message on deferred probe.
True, but the other places in the patch don't have such condition.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-04-18 13:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-18 7:46 Krzysztof Kozlowski
2023-04-18 7:46 ` [PATCH v2 2/4] ASoC: codecs: wcd934x: " Krzysztof Kozlowski
2023-04-18 7:46 ` [PATCH v2 3/4] ASoC: codecs: wcd934x: Simplify &pdev->dev in probe Krzysztof Kozlowski
2023-04-18 7:46 ` [PATCH v2 4/4] ASoC: codecs: wcd938x: Simplify with dev_err_probe Krzysztof Kozlowski
2023-04-18 12:55 ` [PATCH v2 1/4] ASoC: codecs: wcd9335: " Mark Brown
2023-04-18 13:07 ` Krzysztof Kozlowski [this message]
2023-04-18 16:21 ` (subset) " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff0f4871-4d26-e671-0239-fa47117381a0@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@quicinc.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®