From: Zijun Hu <zijun_hu@icloud.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jason Gunthorpe <jgg@ziepe.ca>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
"Matthew Wilcox (Oracle)" <willy@infradead.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
linux-kernel@vger.kernel.org, Zijun Hu <quic_zijuhu@quicinc.com>
Subject: Re: [PATCH] linux/container_of.h: Remove redundant type cast in container_of_const()
Date: Fri, 9 Aug 2024 20:04:57 +0800 [thread overview]
Message-ID: <ff11cab0-6dfd-407c-8039-3dfd873e7280@icloud.com> (raw)
In-Reply-To: <ZrX9G2Ol2jt4o-s7@smile.fi.intel.com>
On 2024/8/9 19:27, Andy Shevchenko wrote:
> On Fri, Aug 02, 2024 at 11:15:15PM +0800, Zijun Hu wrote:
>> From: Zijun Hu <quic_zijuhu@quicinc.com>
>>
>> Remove redundant (type *) cast for default branch in container_of_const()
>> since the cast has been done by container_of().
>
> While it might have same effect, the below is explicitly clear about both
> cases. With your patch it will become inconsistent.
>
my change is more obvious to say that container_of_const() is same as
container_of() for none const pointer parameter @ptr. it is simpler and
easier to understand.
> ...
>
>> #define container_of_const(ptr, type, member) \
>> _Generic(ptr, \
>> const typeof(*(ptr)) *: ((const type *)container_of(ptr, type, member)),\
>
> (see, in the above line the cast is still present / required)
>
yes, for above case, (const type *) is suitable and required.
>> - default: ((type *)container_of(ptr, type, member)) \
>> + default: container_of(ptr, type, member) \
>> )
>
next prev parent reply other threads:[~2024-08-09 12:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-02 15:15 Zijun Hu
2024-08-09 11:27 ` Andy Shevchenko
2024-08-09 12:04 ` Zijun Hu [this message]
2024-08-12 14:17 ` Sakari Ailus
2024-08-13 9:17 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff11cab0-6dfd-407c-8039-3dfd873e7280@icloud.com \
--to=zijun_hu@icloud.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jgg@ziepe.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_zijuhu@quicinc.com \
--cc=rafael@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®