mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mimi Zohar <zohar@linux.ibm.com>
To: Cai Xinchen <caixinchen1@huawei.com>,
	roberto.sassu@huawei.com, dmitry.kasatkin@gmail.com,
	eric.snowberg@oracle.com, paul@paul-moore.com, jmorris@namei.org,
	serge@hallyn.com, amir73il@gmail.com
Cc: linux-integrity@vger.kernel.org,
	linux-security-module@vger.kernel.org,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	lujialin4@huawei.com
Subject: Re: [PATCH] ima: initialize the real inode attributes of the iint cache
Date: Mon, 02 Nov 2026 10:03:02 -0500	[thread overview]
Message-ID: <ff1965b1cdaefa0d68b2da6050ebfddbb7b77ec1.camel@linux.ibm.com> (raw)
In-Reply-To: <faee04cc-fb04-4e56-bfe4-1eae5b819137@huawei.com>

On Mon, 2026-11-02 at 20:09 +0800, Cai Xinchen wrote:
> Hi Mimi. Thanks for review.
> 
> I mistakenly used integrity_inode_attrs_store. In the next version, I 
> will directly use
> memset to initialize the real_inode structure.

Sounds good.

> I double checked b836c4d29f27. That commit also added real_ino and 
> real_dev to struct integrity_iinit_cache and started reading them in 
> process_measurement(). However, iinit_init_always() only reset 
> iint->version, leaving real_ino and real_dev stale. After 309e2b775da8, 
> these three variables are encapsulated into integrity_inode_attributes. 
> Therefore, I believe b836c4d29f27 is the appropriate Fixes tag. If I 
> have missed anything, please let me know.

Okay.  In terms of backporting, clearing the field using memset() would work,
but still the field name changed.  So it won't apply cleanly.

Mimi

      reply	other threads:[~2026-11-02 15:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-02  2:47 Cai Xinchen
2026-11-02 11:20 ` Mimi Zohar
2026-11-02 12:09   ` Cai Xinchen
2026-11-02 15:03     ` Mimi Zohar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ff1965b1cdaefa0d68b2da6050ebfddbb7b77ec1.camel@linux.ibm.com \
    --to=zohar@linux.ibm.com \
    --cc=amir73il@gmail.com \
    --cc=caixinchen1@huawei.com \
    --cc=dmitry.kasatkin@gmail.com \
    --cc=eric.snowberg@oracle.com \
    --cc=jmorris@namei.org \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=lujialin4@huawei.com \
    --cc=paul@paul-moore.com \
    --cc=roberto.sassu@huawei.com \
    --cc=serge@hallyn.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®