From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0786B2749E6; Tue, 24 Feb 2026 08:29:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771921780; cv=none; b=nMDOMa3R5n9NiyuagGnTh2mq1jGreklwZJRX65KQXhOxafjJ1YQQoIu13QZwdxfah0mK4Ul/AHfWw4RCZEpUhFH4pXHxOdnTitkjNvcw1d6z6iUpWACh9ir+K66BqnaAYIurnAoPYMjGeUXaYtjOwQ0X+uplSmTcFTGT4HfMraQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771921780; c=relaxed/simple; bh=s889kssXllyZaSNT87Eq7q+8jDDE7Yxpqk+iIio+e2U=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TdSre0DGhszJjbWlbbiNmaKFC5xYCmqUpukhDQan79X18s12QT0r9RhdmJWHLhxkm9TSaPdEEL+AT004rlTmnIdC/A0dh6OAc30cWIM0sXVAYhsdYo6LEt2OksUdU8E6PzXqwPBCGciDQTICB9+vaw7Zi6unWBjGzIzjEC7D8TA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=SNHr9FXZ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="SNHr9FXZ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E0C05C116D0; Tue, 24 Feb 2026 08:29:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1771921779; bh=s889kssXllyZaSNT87Eq7q+8jDDE7Yxpqk+iIio+e2U=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=SNHr9FXZ68PnehoZL3L7xEXBRGUdm+0EhLsocHU+9tirzHDCoLqN3V2QCmwM00mFp 56eX4kO7yFSccVeMpCCHciajM3Exp8jX0CTK437GW390X7hsqkFXgOMqHpzSo9dwOr gAWupmJ7IajiuRhF2F2wvCsyzFNkCXYWPJYSqlW0sxBoOO7rXoeWr/Lrd7Pi+rlqaN uBwxTs8OpkFlRcTp7R8Fk4g1NXn7uLLvkQySG7lSr0UvbIGBeeebslLmBC16yR0B+K ypauaUdj+Vw7FA8SQSuJZm+95Wy19zR4mLaCokOhS0Hp6PJmuRilzyiPWckoq9+kgV Czu3m3TQWWTwA== Message-ID: Date: Tue, 24 Feb 2026 09:29:33 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next] net: fs_enet: allow nvmem to override MAC address To: Rosen Penev , netdev@vger.kernel.org Cc: Pantelis Antoniou , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , "open list:FREESCALE SOC FS_ENET DRIVER" , open list References: <20260224014607.353378-1-rosenp@gmail.com> Content-Language: fr-FR From: "Christophe Leroy (CS GROUP)" In-Reply-To: <20260224014607.353378-1-rosenp@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Le 24/02/2026 à 02:46, Rosen Penev a écrit : > NVMEM typically loads after the ethernet driver and > of_get_ethdev_address returns -EPROBE_DEFER. return in such a case to > allow NVMEM to work. > > Signed-off-by: Rosen Penev > --- > drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c b/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c > index 2cbcc29408e3..d3c772ed5fc9 100644 > --- a/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c > +++ b/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c > @@ -951,7 +951,9 @@ static int fs_enet_probe(struct platform_device *ofdev) > spin_lock_init(&fep->lock); > spin_lock_init(&fep->tx_lock); > > - of_get_ethdev_address(ofdev->dev.of_node, ndev); > + ret = of_get_ethdev_address(ofdev->dev.of_node, ndev); > + if (ret == -EPROBE_DEFER) > + goto out_cleanup_data; What about other error cases ? Shouldn't it exit on all types of errors ? > > ret = fep->ops->allocate_bd(ndev); > if (ret) > -- > 2.53.0 > >