From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7EE3B3976B8 for ; Thu, 26 Mar 2026 10:19:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774520355; cv=none; b=nRpbAeKEjfnaJws234GznxgxlCGWj8JxH5T1r0rSkI9odnGjDVSKvbABMBCmL7Ivr5krS8uX3nHz2Yy6bkSD+yakmfeJ1h+Mb2Dhq95szwkbpZcU3OZAOXW14JHn88/qyZslOb5zhLrcaJGrL6ZyrALVqrtbuF2BHm5fW3seXRU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774520355; c=relaxed/simple; bh=Qae2gKOQfzbdP6PYGh8B/FDl0l8PUDf9Q4RiAP+IZxk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=SOCrFHaTg90bgPN5qqJsgYXRXmO/Gx/2N1j8vSKgrDAENT20zKiXVt7dB8HgcZ4kRG7mYLevtoBP6OVD/z9h4bYdcU4TZM8Ydj1ApX1FNhIbSvaaKujiJF+6pjJPTuSrnmfi7IrPNMFqeCKdAA8DlzSR9BB+u5DnEaYmNPCm30U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=d846WNLZ; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="d846WNLZ" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-48558d6ef83so7084655e9.3 for ; Thu, 26 Mar 2026 03:19:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1774520352; x=1775125152; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=uc5ku6PvKiOyOZH+1palqwgwPAuIYwNWvmlAsBkODIQ=; b=d846WNLZtL9H7vxa2qyw+eYwQD55oGoN6YhgDKJX0fpuieVNgYFbJCv+tOLqREAOhJ Aj3bT/vayYQNWaDAOTIEROEUrILwmxbPmAkUb4LsFnxeAY67HPoMOSOiQrXYtvFxxoF7 v7elVgqaSJXBDutCBpsyiA7aau4vyd4XXivWndembfkX+2W1ixNl9rCO4B0EMFa++A5u BWd4L4OD98YXHSouC6Siih5kvsSjyClL1eU942EClqESQRT7W9+PZgVR0m1Msr14jmYS DBUL8CD3+bSSWFxYukl8YghYNuPhbFPv7YgeKedAoq+Dlxg8xRulUOXZ+/5VSLImmNFB p1BA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774520352; x=1775125152; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=uc5ku6PvKiOyOZH+1palqwgwPAuIYwNWvmlAsBkODIQ=; b=DgPexSKJZk9RKvkS1A7hdhHY+phWwF2z9Yp3CpuBHQa8GpHsDC5YTl3nrLUN9OheNZ QvpJJh2p3cmVYJWZNJkm+SY9CibvFuyWeejKL7BMvw8GHkQc5/OBubaJCPRO546XAEWU hozYH/2I6cfqiIyvMTUsCMvrm3Xy0Wa3EoCGpZH0rMN1XwZ0xt+l9fJj8DxkZh79Ri0q W+tKS7i6wR5Bn1mJa2RDAtRkXxUHGI+xxhB43wnbGzZqHJDicXqaAvOelaKEpmwS3UPE oJazzcw8sRKz20ekP7EZYq+zl7X35LROzFwgFvb/YfFJi0mRVmQjxxAWFyV3YbGmKWuI aS/A== X-Forwarded-Encrypted: i=1; AJvYcCXG75Ln2iHmevUUTjqJI0W7ZjOmB1z8sYwzh0gWV6ZFT/kQ66zhVFo9Zyh7BxFmhtL1WZL5ILEmfJEXJds=@vger.kernel.org X-Gm-Message-State: AOJu0Yx9NOFETZg0pNndic1KEO5IGBJHavVS15WEPCaTxYiV8ochpRFu J5pB0FbmlHA6it+JdcQguYd2iZuA+76++8bmD+pgoULg+w8fZd4NujON67zvjqlQpCs= X-Gm-Gg: ATEYQzwb5ZjdVXKRKmYL1u51z2j9utwob8GM0tNHXTX874i4ZmdBpGAlRTA2Dxtm5AO qZWwJRXFVvwjD8WrxZ7dOFnOyvdRN939TrmAHuSXyhGY9aGkGP9oVl6H8pT5ex4W9VjREmlkl1n c+bpDRDdw8xmaQIzf+hb8TZ2sNL0Xt3H4A8kfjb5qqkpwp0jMD/EWnN8qpLdP7PGhzsK3Av41aD aztdPbvzvrNxiEEcfaJ7iSZjNPiO09TtU3noVY0+ioJHvTHTxQbDF+gSs2AoITSvbq9qwCMktlT r74dghBjkTweOD1Fxcm4kRVV8QM8ua9ZsMBGMGCXTNM1ZP6iy1yFAiFeb1ASe5Bv8y0rJE1/qvy gDxHp2TFSFgBHtY1CxdybvE74Oy1HHLJeimhfi7P9b8EQ4JrAQjIXc8DIHFUqauRAKglfUMxf6S y+dzlaQ4cKClFQ2GrzCF+k3DesPmjwTeyQPXfWoduJOteR3gkP/Qh2IkX3 X-Received: by 2002:a05:600c:a4f:b0:486:fbd1:9dc0 with SMTP id 5b1f17b1804b1-487160350d6mr95710745e9.22.1774520351745; Thu, 26 Mar 2026 03:19:11 -0700 (PDT) Received: from ?IPV6:2a07:de40:a101:3:ce70:3e6f:3b9c:9125? ([2a01:4a0:2e:ffff:ffff:ffff:ffff:ffff]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48722fa8dc6sm38717085e9.1.2026.03.26.03.19.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Mar 2026 03:19:11 -0700 (PDT) Message-ID: Date: Thu, 26 Mar 2026 11:19:10 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 00/13] scsi: Core ALUA driver To: John Garry , Benjamin Marzinski Cc: martin.petersen@oracle.com, james.bottomley@hansenpartnership.com, jmeneghi@redhat.com, linux-scsi@vger.kernel.org, michael.christie@oracle.com, snitzer@kernel.org, dm-devel@lists.linux.dev, linux-kernel@vger.kernel.org References: <20260317120703.3702387-1-john.g.garry@oracle.com> <10aab639-2fe8-47b7-b821-12d21b6af874@oracle.com> <43ca92bc-af38-4833-841c-421997ed90fe@oracle.com> <2f84e35f-3574-45e8-9567-4edcfdbe5a45@oracle.com> Content-Language: en-US From: Hannes Reinecke In-Reply-To: <2f84e35f-3574-45e8-9567-4edcfdbe5a45@oracle.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 3/24/26 16:12, John Garry wrote: > On 24/03/2026 13:58, Benjamin Marzinski wrote: >>>> If it allowed device handlers to get attached, these two >>>> developement efforts (native scsi multipath and refactoring the alua >>>> support) could go on in parallel. >>>> >>>> Or am I missing something here? >>> It just seems to be about this DH stuff is that there is bad history >>> there >>> and no more users are wanted. >> Just to be clear, if the idea was that the Native Multipath code >> shouldn't use include/scsi/scsi_dh.h, I completely agree with that. But >> I don't see why it can't make use of the results of the existing >> implicit ALUA support, since IIUC it doesn't need the scsi_dh interface >> to do that. > > We would need something like the following to ensure that DH ALUA is > present to update sdev access_state: > > @@ -80,6 +80,7 @@ config SCSI_MULTIPATH >         bool "SCSI multipath support" >         depends on SCSI_MOD >         select LIBMULTIPATH > +       select SCSI_DH_ALUA >         help >           This option enables support for native SCSI multipath support > for >           SCSI host. > > And that is even enough, as Kconfigs should only specify build > requirements. > > We really should be also calling something like scsi_dh_attach() for > scsi multipath to ensure that DH is attached (and running to update > sdev->access_state). > > And I am not sure how the dh alua module is even autoloaded. I think > that on my ubuntu machine the multipath-tools.service does it - > something like this would not be nice for native SCSI multipath support. > Gnaa. But then we don't need this patchset at all. Main point was that we _do not_ need to hook into scsi dh for implicit ALUA. Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.com +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich