From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 334A4374184 for ; Mon, 9 Mar 2026 09:03:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773047025; cv=none; b=cjlXc3TF6+TmwVd1kUF4AluSJ5UM+/LXiEZAxaw3Vw23cp2RE3UmxX8vR68JUNC31XW66eY3DhHlQ2SgNs+C7E/3GS6Mck2auSOmI0UiffdQCPO2hTRxZG/oXXAELzkhDvAjS+KWSHjTC+QW3i5US9F+PFX75085tf87Ciqvtbs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773047025; c=relaxed/simple; bh=8fUvoibV26HMwm4SZo08XfvSd2z8XvjOMt5GVhz9Rts=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jKgLyVnqtZ00OWJt4wpXCzj+FvAv/d4LpjIu1olwFbupNfQC9sEb1myX722NayJJt4KFkNnr/loxs38vTmILdDWFgxnOm8Pvl5ONdF49S5jXhfU46C+IgphQLLsuivvpPJJ8PksQSKZ8k1GX9Pe2hK4TFTF1yZwJ35uUXfG4lfU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=XdbrpCNu; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=NywW0NjC; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="XdbrpCNu"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="NywW0NjC" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6293lsD01128815 for ; Mon, 9 Mar 2026 09:03:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= LFgh6PWkU285cJ6bI3mPDffcunh/9afis7R4F55H8mM=; b=XdbrpCNuJ186PiNB U0A27Tm9S312pqZ48fIR/jd+5bmvTCwpnVA4VZKct8jSLQwQvhfF8yPXPwRMG2Ev 5u3JHaO8BKiEpliFW6YnHzgqpsD4RPaFQExFAMIMcJ1P3T5bQDTmSX/LxElP2nRD mMDq61Nvqo4YlM4DZnjzHJZn/6dUeL+LBsleDpcfFqihFIXzT6RKG8Hnl4LJRKdJ RqpjCR67Bkz3Sp7tdrSTKwv19K5jqLZ2Lef6ae9fZLpni5N8nAbwSL8zy3IZJ/Ld r1oiVMFQ/4N5MoSTRGEop/a+UoXQnchTOsIK2CqVej4q2Tv81IKfqB39rkg1Zxil XToGrw== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4crcd8ck5e-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 09 Mar 2026 09:03:42 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-c738662b963so2997228a12.0 for ; Mon, 09 Mar 2026 02:03:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773047021; x=1773651821; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=LFgh6PWkU285cJ6bI3mPDffcunh/9afis7R4F55H8mM=; b=NywW0NjCE0pWyeYq+d85CaPVbnHzOcKUf2l6FoL4XoDYhz9+znn3gOuJxDLYERA2Aa 7wUYbiFma8L4bnzqRzlXAXioHrPylAF2WUb5pD08tyo32Z5VCpimF6hb/nMbhXAXWi6+ D4EZI8TeWycLON7SfuU8yD7izGbCaH72zkXviktFvZIkfh7LmvmYC+irhKKQK5EEbx47 FJA9D3gTuYbtVto/eZqz++qil/O78gLk+/I+XG0Dk91cLWDeusprBEeYdu2ZHMkqIqSL 89/9Bl4bSVm3ieJw+GE1MCG2xrbG4LR/6yN5alnSd4aLVasCQU1Nwj4U1QFjjTItNwbP MDAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773047021; x=1773651821; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LFgh6PWkU285cJ6bI3mPDffcunh/9afis7R4F55H8mM=; b=XfikUY+gxcMuUgGaMeNANQShrtgcfyDuwSN9szu4X8iKiO8WHf/2n9kj04U0qqSoFz zmQWwV0tUvHE6O4wIkgCeN2UXB7UnGx2xj3UlHg0TMRzhIl7yWSyntsdDZMNnVqXIQuM VxXhBIxAmPPYNxWRy5e2iizrmgxjHh0dI4DGCcfQKuL+TuyFHDxP0bVhEvQtC/D5YjKP aczZDDnm8HmGISAm1S7tcBcZTFMKzzjzb061LE4uqMwLSgzKPeF/RzX7k3ADiiTTl1Nv hmmQaOH0iBaasrp77pavmLGCZdDSZe++xhZ+rnYtRGHAFIHBS6GW94zS4PgI3CQ7xG6m mIXQ== X-Forwarded-Encrypted: i=1; AJvYcCWmSpRbm9/EPTq0QnYWBlGHp7pdpwoRn/5XyO4xCwjei5KMSct1k3XblujhISQnmdyi+t6+Ru5u8uws43w=@vger.kernel.org X-Gm-Message-State: AOJu0Yxau2T8YRGw4coDlvrrgdmqvpWs6e1IlggUIM7O2R550apJVzDk zehsrVjMKfVt4NC4NYNGQCEoj1LunYMFJtZe3ooo0htGu9uCyyC/ZG6WP5bgOX7ErVUPZ235XQI rVn+qkNLIEJr4au/xmXVwB2BY5ER8UtOBxvwtcM8VmR8KvqeRMjsP26Sc8gaUUCPfnNQ= X-Gm-Gg: ATEYQzy36nn5fCB2T1XtU7bchGYqjOXK92i8Iv2seQqAQR093BV3q8NcYOPp8NK1+bS g/Pr5+DqlC+CipVmUOiK2qmUGJIxaVVFwH7FiAYnJEfLrUdDcuFV7g/Jrikz9s1+5VGVyjHC+G9 OLjeRZzhLzpG3kVbZLhm4joJDvGooPuYWZAG0DsEcz1A4htUlODMDCly6YQFp503AZHpwG9VnQF hFpwEqg3LSdhbb8oHps5hMJqPESmK0dLhz1mO1GMPYfQya+hTbZxmQefFf3xqAMdt8HyAkuI4/Y 5PSB4t3+xddIku0xUD6VKkPilk8GTkWH/EVtUAkPmFSW757mCsKebWvVxI2F3OwHg83GHlzzi1N CQJ33vElOxk0ozt9VajWZlNUBqQQyOhiJJ0uEXR6q3oaVmFK91vX5H4gq60lnZnDcfZGv/og/Lf MzhZ4R4uOYf7CYn+WJfS50YHTvUSrCO4S5/AR3N6E= X-Received: by 2002:a05:6a20:c786:b0:398:a216:2425 with SMTP id adf61e73a8af0-398a2163a0dmr435095637.65.1773047021032; Mon, 09 Mar 2026 02:03:41 -0700 (PDT) X-Received: by 2002:a05:6a20:c786:b0:398:a216:2425 with SMTP id adf61e73a8af0-398a2163a0dmr435038637.65.1773047020367; Mon, 09 Mar 2026 02:03:40 -0700 (PDT) Received: from [10.190.200.237] (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com. [103.229.18.19]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c739e194f74sm8523530a12.30.2026.03.09.02.03.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Mar 2026 02:03:39 -0700 (PDT) Message-ID: Date: Mon, 9 Mar 2026 14:33:34 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V3 4/5] arm64: dts: qcom: x1-crd: Add Embedded controller node To: Krzysztof Kozlowski Cc: robh@kernel.org, krzk+dt@kernel.org, andersson@kernel.org, konradybcio@kernel.org, bryan.odonoghue@linaro.org, ilpo.jarvinen@linux.intel.com, hansg@kernel.org, conor+dt@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org References: <20260308233646.2318676-1-sibi.sankar@oss.qualcomm.com> <20260308233646.2318676-5-sibi.sankar@oss.qualcomm.com> <20260309-festive-prudent-ibex-f8b601@quoll> Content-Language: en-US From: Sibi Sankar In-Reply-To: <20260309-festive-prudent-ibex-f8b601@quoll> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: XQYegPeR0UzuSVPWKiq9UdbOXI9LBY34 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA5MDA4MyBTYWx0ZWRfX5rMav3IsZ88i joXvG1uwMuCs8ZcSnG4bYMDhGc3czU0yo3wMgKdQUt+/DQnIAMjjN/8UEwSyBUaVfbCj/xzq++g abNSADTJgbjrkqYcI9oJjZNhkNF86LsbciAjPNAavjixxM/VxJ+k+ZVN48pIxWvQARwsl3w42Bn ID46NGef6Lu0FS2v78/a1hRUXRDpj1Cf3xSGn+bEZ7cvdHK+Edxa9IMZVpNkEZlAznmvq67tKcX ClEXYUWsn6l/Ny4pP/nuRdVfi5pfDlM3KOMSwF3VEjKNIN/mxydfomLar7P7znV6ddHWb9GjcBd ABK1BydjowRuHBW8r1cZp2JIcEbk40qTn1x/wwvMI9xmGpQ6hHl5MwcHTU0eAXQdhVYVWTp2jjq vuM3iw+C3Q3XYdoWHZ4CnP85RsVC9cI3SGxRZPThhc0hoCgcdSARxMaS/OxfeWMC1RGKAV8GtDe 1S+7OBBzqjZb1sX9+hg== X-Authority-Analysis: v=2.4 cv=O/w0fR9W c=1 sm=1 tr=0 ts=69ae8cee cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=Ou0eQOY4+eZoSc0qltEV5Q==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=PRai1pm7VL3AQe0GFXUA:9 a=QEXdDO2ut3YA:10 a=x9snwWr2DeNwDh03kgHS:22 X-Proofpoint-GUID: XQYegPeR0UzuSVPWKiq9UdbOXI9LBY34 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-09_03,2026-03-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 clxscore=1015 spamscore=0 phishscore=0 priorityscore=1501 lowpriorityscore=0 adultscore=0 impostorscore=0 bulkscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603090083 On 3/9/2026 12:55 PM, Krzysztof Kozlowski wrote: > On Mon, Mar 09, 2026 at 05:06:45AM +0530, Sibi Sankar wrote: >> Add embedded controller node for Hamoa/Purwa CRDs which adds fan control, >> temperature sensors, access to EC internal state changes and suspend >> entry/exit notifications to the EC. >> >> Signed-off-by: Sibi Sankar >> --- >> arch/arm64/boot/dts/qcom/x1-crd.dtsi | 16 ++++++++++++++++ >> 1 file changed, 16 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/x1-crd.dtsi b/arch/arm64/boot/dts/qcom/x1-crd.dtsi >> index ded96fb43489..29a1aeb98353 100644 >> --- a/arch/arm64/boot/dts/qcom/x1-crd.dtsi >> +++ b/arch/arm64/boot/dts/qcom/x1-crd.dtsi >> @@ -1042,6 +1042,16 @@ eusb6_repeater: redriver@4f { >> >> #phy-cells = <0>; >> }; >> + >> + embedded-controller@76 { >> + compatible = "qcom,hamoa-it8987-ec", "qcom,hamoa-ec"; > I don't see updates to other x1e boards, thus my arguments from v2 stay > valid. It's wrong to call it "hamoa-ec" since only one Hamoa board has > it. All of other Hamoa boards apparently do not have it. Hey Krzysztof, Thanks for taking time to review the series :) What other Hamoa boards are you referring to? The series mentions that the driver and bindings is meant for Qualcomm Hamoa/Purwa/Glymur "reference" devices, so it only covers CRD and IOT-EVK. It definitely does not cover all Hamoa boards boards like you are assuming. > Best regards, > Krzysztof >