From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D18BEC43334 for ; Mon, 6 Jun 2022 09:20:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232736AbiFFJUw (ORCPT ); Mon, 6 Jun 2022 05:20:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37964 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232720AbiFFJUu (ORCPT ); Mon, 6 Jun 2022 05:20:50 -0400 X-Greylist: delayed 308 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Mon, 06 Jun 2022 02:20:46 PDT Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 97D7C37014 for ; Mon, 6 Jun 2022 02:20:46 -0700 (PDT) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 1FB226601F9F; Mon, 6 Jun 2022 10:20:44 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1654507245; bh=hOGlwtWXwq/KtQAdrBRHTu7hvquStP9tnqCCNREO+V4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=IeyJ67nKKhOvCq/O2roO/wRtNVHTWD0XYD1151pb1McHjwXiU06LB6usFcfbKoM1o I8zysIJNhvPsf+Zi8MB/0WLaNdorX7cEalKI16lHP8AlUGM1qONwSUeiVIpRAdhHqi fDr6jcSHWxRHwoJwqDYNcGEPoDUDkHqlCYkR7SlxwDhvpQpYHxCEna4LgJc7+cQCI6 RhDZLvioI4NmNLHcyP4IdSUbBNUqd9kWBXwFpgI36hcOWcLEwMiGT76siTOCA0tKZJ 2xjqba7WNUDIG3F6tV9sNwKrkqky+ijsXYSLg09HIZL/af0y6w+gHOG2OmJcdpe9HS O8ojqBgXiCOxw== Message-ID: Date: Mon, 6 Jun 2022 11:20:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v3 8/8] drm/mediatek: Config orientation property if panel provides it Content-Language: en-US To: Hsin-Yi Wang , Chun-Kuang Hu Cc: Hans de Goede , Thierry Reding , Sam Ravnborg , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Philipp Zabel , David Airlie , Daniel Vetter , Matthias Brugger , dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, Rob Clark , Stephen Boyd , Douglas Anderson , Rob Herring , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220606044720.945964-1-hsinyi@chromium.org> <20220606044720.945964-9-hsinyi@chromium.org> From: AngeloGioacchino Del Regno In-Reply-To: <20220606044720.945964-9-hsinyi@chromium.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 06/06/22 06:47, Hsin-Yi Wang ha scritto: > Panel orientation property should be set before drm_dev_register(). > Mediatek drm driver calls drm_dev_register() in .bind(). However, most > panels sets orientation property relatively late, mostly in .get_modes() > callback, since this is when they are able to get the connector and > binds the orientation property to it, though the value should be known > when the panel is probed. > > Let the drm driver check if the remote end point is a panel and if it > contains the orientation property. If it does, set it before > drm_dev_register() is called. > > Signed-off-by: Hsin-Yi Wang > Reviewed-by: Hans de Goede Reviewed-by: AngeloGioacchino Del Regno