Re: [PATCH v6 0/1] KVM: SEV: Add KVM_SEV_SNP_HV_REPORT_REQ command

[Tom Lendacky <thomas.lendacky@amd.com>]

On 1/28/26 13:49, Thomas Courrege wrote:
> Overview
> --------
> The SEV-SNP Firmware ABI allows the hypervisor to request an
> attestation report via the SEV_CMD_SNP_HV_REPORT_REQ firmware command.

The code looks good to me, but you might want to reply to your cover
letter with more of an explanation as to why this is important to
include in KVM.

Thanks,
Tom
> 
> Testing
> -------
> For testing this via QEMU, please use the following tree:
>         https://github.com/Th0rOnDoR/qemu
> 
> Patch History
> -------------
> v5 -> v6:
> Fix typos issues in documentation
> 
> v4 -> v5:
> Set variables in reverse christmas tree order
> Fix and clean the rsp_size logic
> 
> v3 -> v4:
> Add newline in documentation to avoid a warning
> Add base commit
> 
> v2 -> v3:
> Add padding to structure, code format
> Write back the full MSG_REPORT_RSP structure
> Remove the memzero_explicit for the report
> 
> v1 -> v2:
> Renaming, code format
> Zeroes the report before returning
> 
> 
> Any feedback is appreciated.
> 
> Thanks,
> Thomas
> 
> 
> Thomas Courrege (1):
>   KVM: SEV: Add KVM_SEV_SNP_HV_REPORT_REQ command
> 
>  .../virt/kvm/x86/amd-memory-encryption.rst    | 28 +++++++++
>  arch/x86/include/uapi/asm/kvm.h               |  9 +++
>  arch/x86/kvm/svm/sev.c                        | 63 +++++++++++++++++++
>  drivers/crypto/ccp/sev-dev.c                  |  1 +
>  include/linux/psp-sev.h                       | 31 +++++++++
>  5 files changed, 132 insertions(+)
> 
> 
> base-commit: e89f0e9a0a007e8c3afb8ecd739c0b3255422b00