From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pegase1.c-s.fr (pegase1.c-s.fr [93.17.236.30]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E623726158B; Tue, 8 Apr 2025 07:20:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=93.17.236.30 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744096838; cv=none; b=pr4U1pln6V8f5ZnM+8AnVDA7A832OYJaX5hdUCKzFfi2csSrhJlfii47BYqo7g9ltM1+r1jMgS1f3fOWUZC+m/xQ71G24ytIOLLUP0A1JpIhr7pYgyu/uQpFagfqLO6k7CRTNoit1AooW/mScwlK1As7f1ZtuCd0TXKk9FSlMNY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744096838; c=relaxed/simple; bh=leAZBUvTDieNUCTCUQ6Z093axNVZ+MVhp4DKPjyWQPA=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=Q43beue9AVbejRT1Xp7biP/ZfZsIpDEVWoTOrkB6MIGhTraCCk64yyo5fQisocNpjPjyJbv3OzUjzd5pfjeB519RWpeXKMEN5v0fG9aWzPkZMhVrNMNC2jPHEiCpJxwNAEG9lfnfRl0J2x/HpGL0bQePQEcNZQOBespijRndrEY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=csgroup.eu; spf=pass smtp.mailfrom=csgroup.eu; arc=none smtp.client-ip=93.17.236.30 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=csgroup.eu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=csgroup.eu Received: from localhost (mailhub3.si.c-s.fr [192.168.12.233]) by localhost (Postfix) with ESMTP id 4ZWw9N4Zhgz9vkq; Tue, 8 Apr 2025 07:48:24 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id N6upf-zRu5gv; Tue, 8 Apr 2025 07:48:24 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 4ZWw9N26zXz9vkm; Tue, 8 Apr 2025 07:48:24 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 320D88B768; Tue, 8 Apr 2025 07:48:24 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id NWUepSYaoFfZ; Tue, 8 Apr 2025 07:48:24 +0200 (CEST) Received: from [192.168.235.99] (unknown [192.168.235.99]) by messagerie.si.c-s.fr (Postfix) with ESMTP id DC9078B767; Tue, 8 Apr 2025 07:48:21 +0200 (CEST) Message-ID: Date: Tue, 8 Apr 2025 07:48:22 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 09/13] arch, mm: set max_mapnr when allocating memory map for FLATMEM From: Christophe Leroy To: Mike Rapoport , Andrew Morton Cc: Alexander Gordeev , Andreas Larsson , Andy Lutomirski , Ard Biesheuvel , Arnd Bergmann , Borislav Petkov , Brian Cain , Catalin Marinas , Dave Hansen , "David S. Miller" , Dinh Nguyen , Geert Uytterhoeven , Gerald Schaefer , Guo Ren , Heiko Carstens , Helge Deller , Huacai Chen , Ingo Molnar , Jiaxun Yang , Johannes Berg , John Paul Adrian Glaubitz , Madhavan Srinivasan , Mark Brown , Matt Turner , Max Filippov , Michael Ellerman , Michal Simek , Palmer Dabbelt , Peter Zijlstra , Richard Weinberger , Russell King , Stafford Horne , Thomas Bogendoerfer , Thomas Gleixner , Vasily Gorbik , Vineet Gupta , Will Deacon , linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org References: <20250313135003.836600-1-rppt@kernel.org> <20250313135003.836600-10-rppt@kernel.org> <4b9627f2-65ff-4baf-931f-4e23b5732e6b@csgroup.eu> Content-Language: fr-FR In-Reply-To: <4b9627f2-65ff-4baf-931f-4e23b5732e6b@csgroup.eu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Mike, Le 14/03/2025 à 10:25, Christophe Leroy a écrit : > > > Le 13/03/2025 à 14:49, Mike Rapoport a écrit : >> From: "Mike Rapoport (Microsoft)" >> >> max_mapnr is essentially the size of the memory map for systems that use >> FLATMEM. There is no reason to calculate it in each and every >> architecture >> when it's anyway calculated in alloc_node_mem_map(). >> >> Drop setting of max_mapnr from architecture code and set it once in >> alloc_node_mem_map(). > > As far as I can see alloc_node_mem_map() is called quite late. > > I fear that it will regress commit daa9ada2093e ("powerpc/mm: Fix boot > crash with FLATMEM") > > Can you check ? I see this patch is now merged into mainline (v6.15-rc1). Have you been able to check and/or analyse whether it doesn't regress the fix in commit daa9ada2093e ("powerpc/mm: Fix boot crash with FLATMEM") ? Thanks Christophe