From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECC86C43334 for ; Sat, 2 Jul 2022 11:33:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231540AbiGBLdC (ORCPT ); Sat, 2 Jul 2022 07:33:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52668 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229468AbiGBLdB (ORCPT ); Sat, 2 Jul 2022 07:33:01 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id B77D516596 for ; Sat, 2 Jul 2022 04:33:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1656761579; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+/CG7OlSvFtvPwBtKbOScoNNsNb5w33jEJ9roT+riGE=; b=FzJ286yJKDiIKtk3SqvCGauI3vQBpLtqS6TXf2z0r4JVfCxY6N0UauC4kL2g3pciwI7WIH 8THS0RU5HVScaFdOQ+6qpK7BgmV7lCgOnGDHmvEh6Np971glCqxzVdsXRFMAf84MBCZgjP wJFezK/wkVs++pqcYxzlTy7d49RYrdo= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-518-N3Xw3OpzMYCQAgAJYFAF5Q-1; Sat, 02 Jul 2022 07:32:56 -0400 X-MC-Unique: N3Xw3OpzMYCQAgAJYFAF5Q-1 Received: by mail-wm1-f71.google.com with SMTP id n18-20020a05600c501200b003a050cc39a0so2045356wmr.7 for ; Sat, 02 Jul 2022 04:32:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=+/CG7OlSvFtvPwBtKbOScoNNsNb5w33jEJ9roT+riGE=; b=4/C7qYjrfNUFsuv+2ah3V2dS6lcDWpiv+RqLiuGDKp0OkbVaCmJi6eO893R3zhnEPU TbA/uW5NyMvRVgMOWp41CA3J591FdhKn+ln86XHn5bYy7KeZJTA5Se+Z4DWcJg38vEGE VigN6talOEAOl90cJ9J2wvDlGPMfCS8Z0tnu/lC009FwhuRVj5jFISyijmQ+I1XTkADU 4M5InmWzeSV5KKRW87FS1B0ZZm3Qe7b3gz41jFk96NeyYQT2oSWcUu6eO13LweEKWRNT ZpFKpkp5c58asO7nk63hB6E8nQYbRKYBk0lb33Y6kYacrGcHUV4fUocsnBejDNKPtG3N PytQ== X-Gm-Message-State: AJIora+OGoAzFhat+05DngZKDfwGeDtWugJaMiYF/TWjipVl8y9qovRA uhoUIXp6JmSX3PXXN40QSWMrMp9xNYdlb079WJWS7yFxJCOdV/IBc9DN8Xp275tJDImC6a2e6Q3 QzIt1D8PrwBQ17edr97E0pWwt X-Received: by 2002:a05:600c:2051:b0:3a0:3c58:6ff6 with SMTP id p17-20020a05600c205100b003a03c586ff6mr22334052wmg.98.1656761575581; Sat, 02 Jul 2022 04:32:55 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uK7lyTTBd7+vx/Qhs8VIxakL50jdfDusliR+VYkqGsWVRmfyQsHe77h/XIU94xnlgnS61zoQ== X-Received: by 2002:a05:600c:2051:b0:3a0:3c58:6ff6 with SMTP id p17-20020a05600c205100b003a03c586ff6mr22334016wmg.98.1656761575330; Sat, 02 Jul 2022 04:32:55 -0700 (PDT) Received: from [192.168.1.129] (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id y15-20020adff14f000000b0021d2f322e50sm9308324wro.41.2022.07.02.04.32.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 02 Jul 2022 04:32:54 -0700 (PDT) Message-ID: Date: Sat, 2 Jul 2022 13:32:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v3 1/9] drm: selftest: convert drm_damage_helper selftest to KUnit Content-Language: en-US To: =?UTF-8?Q?Ma=c3=adra_Canal?= , Isabella Basso , magalilemes00@gmail.com, tales.aparecida@gmail.com, mwen@igalia.com, andrealmeid@riseup.net, siqueirajordao@riseup.net, Trevor Woerner , leandro.ribeiro@collabora.com, n@nfraprado.net, Daniel Vetter , Shuah Khan , David Airlie , Maxime Ripard , Thomas Zimmermann , michal.winiarski@intel.com, =?UTF-8?B?Sm9zw6kgRXhww7NzaXRv?= , David Gow , Daniel Latypov , brendanhiggins@google.com Cc: kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Arthur Grillo References: <20220630004611.114441-1-maira.canal@usp.br> <20220630004611.114441-2-maira.canal@usp.br> From: Javier Martinez Canillas In-Reply-To: <20220630004611.114441-2-maira.canal@usp.br> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Maíra, Thanks a lot for your patch. On 6/30/22 02:46, Maíra Canal wrote: > Considering the current adoption of the KUnit framework, convert the > DRM damage helper selftest to the KUnit API. > > Acked-by: Daniel Latypov > Tested-by: David Gow > Co-developed-by: Arthur Grillo > Signed-off-by: Arthur Grillo > Signed-off-by: Maíra Canal I believe the order of the tags should be chronological. That is, Daniel and David tags should be after your Co-developed-by and Signed-off-by tags. [...] > +++ b/drivers/gpu/drm/tests/drm_damage_helper_test.c > @@ -0,0 +1,634 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Test case for drm_damage_helper functions > + */ > + > +#include Please add a blank line here to separate non-DRM headers include from DRM headers. > +#include > +#include > +#include > +#include > + I haven't looked at the KUnits tests in detail since Daniel and David already reviewed them. But from a quick glance, the tests look good to me as well. Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Linux Engineering Red Hat