From: Alex Elder <elder@ieee.org>
To: Rhys Tumelty <rhys@tumelty.co.uk>,
Viresh Kumar <vireshk@kernel.org>,
Johan Hovold <johan@kernel.org>, Alex Elder <elder@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: greybus: remove unused macro CAP_TIMEOUT_MS
Date: Thu, 11 Jun 2026 09:24:53 -0500 [thread overview]
Message-ID: <ff3cfa53-b385-4c3b-aab0-6402ecc23249@ieee.org> (raw)
In-Reply-To: <20260610173026.1105803-1-rhys@tumelty.co.uk>
On 6/10/26 12:30 PM, Rhys Tumelty wrote:
> The macro CAP_TIMEOUT_MS is defined but never used anywhere
> in the kernel tree. Remove it to clean up code.
>
> Signed-off-by: Rhys Tumelty <rhys@tumelty.co.uk>
Looks good.
Reviewed-by: Alex Elder <elder@riscstar.com>
> ---
> drivers/staging/greybus/authentication.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/staging/greybus/authentication.c b/drivers/staging/greybus/authentication.c
> index 97b9937bbdc1..d8f2cd43201f 100644
> --- a/drivers/staging/greybus/authentication.c
> +++ b/drivers/staging/greybus/authentication.c
> @@ -15,8 +15,6 @@
> #include "greybus_authentication.h"
> #include "firmware.h"
>
> -#define CAP_TIMEOUT_MS 1000
> -
> /*
> * Number of minor devices this driver supports.
> * There will be exactly one required per Interface.
prev parent reply other threads:[~2026-06-11 14:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-10 17:30 Rhys Tumelty
2026-06-11 14:24 ` Alex Elder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff3cfa53-b385-4c3b-aab0-6402ecc23249@ieee.org \
--to=elder@ieee.org \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=rhys@tumelty.co.uk \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®