From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7180F41C311 for ; Thu, 5 Feb 2026 15:03:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770303826; cv=none; b=Af1R+AdMpx07eUvdSBjiZpRMp9SbeQYIRnkewrV1LlQ3ZCaOa/yuACkkR7NzR8prQzwwrNKntcJOup4xXNpV5Pn9Qud86A6ve7JfCeSmIQ1si+W77m5Qp23KMo11ii/maN8U2/fkCL3Z4lFOVxluuRLXe49BCvOHMeVZYwjPYWc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770303826; c=relaxed/simple; bh=QDt+IVdx40jFCSq5PK6HDvUBfE75fBxnDd2zJEdpf10=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=lw76xHZDFVS741RGyy1B+s5cDMAYBpIRoPh0UtUGiVel+fNsMUvE2FMBbJ19WeC6yuqnVeH0CNFsfuxY5o07Vms8umufYNd0Vz5ybRpFNjADV1M5wUzAWzmNYTxZw6YQV3GvJx44jPMq27MrrIbKokATQH4MzZq+0NF6CUaqY38= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=cogentembedded.com; spf=pass smtp.mailfrom=cogentembedded.com; dkim=pass (2048-bit key) header.d=cogentembedded-com.20230601.gappssmtp.com header.i=@cogentembedded-com.20230601.gappssmtp.com header.b=h86aNLGO; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=cogentembedded.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cogentembedded.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cogentembedded-com.20230601.gappssmtp.com header.i=@cogentembedded-com.20230601.gappssmtp.com header.b="h86aNLGO" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-4806d23e9f1so11829135e9.2 for ; Thu, 05 Feb 2026 07:03:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cogentembedded-com.20230601.gappssmtp.com; s=20230601; t=1770303825; x=1770908625; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=lZ+H0eQdVfdIdysvIL1NJVX7+mMSZtddMzAlKVyZ/Bw=; b=h86aNLGOFWd07IDnZe3EAN19Ers9TXbmAam+RREIJM4ct7PjANLJJBsaXPOE1Qcyv8 JyzGPON+np0cipWDXkAEUOaZnwL2GSgZqAotEfpVc+UU4pgfcoufolwXc+DVm5eKb4uL nMpnhUKMJaC5QG44C7VLeZyw1TeBgVTwyzz6WwQuYSCb93labNV5+n5CyO+LpDOu0mWm A+DwIra3q+3oH33CqASKwVlrSPXirGUvtE1Lyni06ZvAkDokqQ8i2ukIDL5lx7dSWyZU rBC13fFMJXhau+i08AQ7PQpB4esrAh7LGpNuNzTPhlvs64b6DYNAqJKIbBYdq8GbZJf7 XU1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770303825; x=1770908625; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lZ+H0eQdVfdIdysvIL1NJVX7+mMSZtddMzAlKVyZ/Bw=; b=nBTqTU3ATJFj3xLRbvw1gwZPLNcrZdEupaPAgm3Qre4HS8y4zDPiSTFP5Ejxe9IU/g IEY3870QO9xx5vUxeQtiHtViBRmKrHfCNWppqD6VkskHO9AgpGmLEfRJuS3LyQY2NCrr ZWcfEk8H+d6x6Z6jhlZtyazOSyOrj3sGD7YQLqM0aliYwJ1lrWzYFfiy3LKwZ608Laj9 8z0tmRaxBZAPS+AGlJkLhO/185iIZTGvpAixeRY99Mm/4D/WFmoHcMrgj8umJpqPvCS2 ubVIfQQgeWnytibDsYqkgiPXP1kNslJEZjAltP7wUJk/F8t9Ufdh3S5zzk8l5EbDuMVJ +daA== X-Forwarded-Encrypted: i=1; AJvYcCWwlysjqCnjK/gtDjgdshmysYFAIyUoSRxXxaVKUfzIimZWD3UBLbRFJhEqlhQtLD02NmcWSJswrFLge54=@vger.kernel.org X-Gm-Message-State: AOJu0YxdPlXgOqxQnGdu1jDkxhVVnlk8YiI8rWM7y+xhK78HYqVeMh3z WVIGyTjDjf602PT8gT4U5iXBUiBeW6NxBFOIDavpRPtUksSpP8/tU4seF3QjEGCjOmE= X-Gm-Gg: AZuq6aJbpDQNG7K5u/EVDRi9XClyWU5Ww8/P/A7Zhs+lYPwElRlUECQqmEXxaxnF5fL HLG8VIPWplI0/Tzda4dLXnzUAxQajN/nrTATKF7i7P1IAz8pxc9o60MUsL4tLX4R+1iVikyRS8h TQSS6cmS68LeVJ+XHFgvU5B6ZGSLyxhdc+FGSWUexJcDjBW6aUVuyKqB+4Ckz6UrY3mhDmJplaZ tlyoR2eVXwqZqC0zo6HVkAPBEzT/+YwgEmDIOD3QzJEu1V8A2DXdHe5cDf87QkZTwLLcEnVOs8J jXmTIUMFvLk6rn1+7Zx02v1N2vEwrgg964hpOwsIxbrwcjEa0wWQbK4jq85bT9dOg6+Y0niBpCa ya0yMpVHHNxwD6ayyX2wLC6TNKrOEuz1Et58UVRFbzAw2JJ7Quwt6NBGPVu7onL7TjMCaPh16bP hoEcvlFy+XDwhDBtR/8R+pGjfxKnbM7hJEXQJee53qqkH3BLM= X-Received: by 2002:a05:600c:8b63:b0:477:98f7:2aec with SMTP id 5b1f17b1804b1-4830e93ea19mr102464055e9.3.1770303824859; Thu, 05 Feb 2026 07:03:44 -0800 (PST) Received: from ?IPV6:2a02:810a:b98:a000::159a? ([2a02:810a:b98:a000::159a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43617e25e8csm12978285f8f.1.2026.02.05.07.03.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Feb 2026 07:03:44 -0800 (PST) Message-ID: Date: Thu, 5 Feb 2026 16:03:43 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net] net: renesas: rswitch: fix forwarding offload statemachine From: Nikita Yushchenko To: Michael Dege , Yoshihiro Shimoda , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: "netdev@vger.kernel.org" , "linux-renesas-soc@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <20260205-fix-offloading-statemachine-v1-1-640224a531d0@renesas.com> <3b1405cd-6c7f-4883-95fb-151cab223a68@cogentembedded.com> <25ff0841-545b-433a-8e88-6e463ea718e7@cogentembedded.com> <237bee8b-a7cf-4c14-9946-8bf72dbddde5@cogentembedded.com> Content-Language: en-US, ru-RU In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit >>> The driver was originally designed to enable hardware forwarding when not less than two ports are in >>> forwarding state. When only one port has hw forwarding, there is no destination to forward. >>> >>> Nikita >>> >> >> The current driver allows Linux to use the bridge port as local port to the bridge. The offloading >> Also supports switching traffic to Linux through the bridge port. Therefore, the offloading shouldn't >> Be dropped if only one external port is up on the bridge. > > "Offloading" means - forward a frame from one hw port to other hw port without inserting it into CPU > queue. Offloaded frame is never visible to software bridge. > > There is code that allows offload only if the linux bridge device used to connect rswitch ports does not > have anything else.  If it has something else, offloading is disabled (because there is no way to know > when a frame can be processed within rswitch hw without sending it to cpu). Ah I see the code that explicitly enabled l2 offload only when at least two ports are active is not in mainline. Still, l2 offload requires at least two ports participating, by definition. When there is only one port with hw forwarding enabled, it will get empty allowed forward destination mask.