From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF5702E65D for ; Mon, 2 Feb 2026 12:45:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770036356; cv=none; b=RkwGRw15g1QgSnlIfvxIklEN6jU1Woj3nGdxyHqFWT3YGVf2EmpaRB+FgcqLqwkvD4+zTAOmGhTP2QjZKOnTihEK+W5h2mJ312xBlWbXtf6bg4kBwY5SZAA9/4R52vnSe0v7ZmJiquRr0/7KeXF+/z4HlcnZtE0UVvgpaFUC20E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770036356; c=relaxed/simple; bh=oEe+hWNQu1xV5jz8E3DiDvg9mYL/B8S9c2As5/0PdA4=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=e7tfNKBrmja4bNh/tLUmgmHtwc/nJ7o8EdRG5gWgk7N3wY1ZGJkhZk1TqcTE3kEps6NBN2BgAQxwlccR/EUysWQzsOMvTTV2PTokEIa7y3VxSJ7neFX6NOuJzDINBlmb87fINdCOYWV3L26saLKrLGl7g181eE/6L6f4DoXafO4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=nlLAE4wV; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="nlLAE4wV" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 27BD14E423BA; Mon, 2 Feb 2026 12:45:52 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id F0C7660767; Mon, 2 Feb 2026 12:45:51 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 264E3119A8888; Mon, 2 Feb 2026 13:45:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1770036351; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=vfqffI0PSjnSTnsWU7z9LKCNNAy2Pw0spoRY3R9EZE4=; b=nlLAE4wVWiyctO3wzm/0R5UM16KEdx1iaje2nsBQEhJhs33AlwRKRyeQUKLzg6K4kHiarT SMI+KNd0ytNMq1gWSwYEoSx+MBYzL0PMxwMwHs3XS6tbIR67p7mlWF9IcVh9zLMExd34Th lPFnwFtYm0xRimwXCG+OsYlB3s6rk2wap9WEaBESydY5v1ZTp9cw/7UDjKtoBmrpdyxUhr 9yRRa9kUVzSI7VNNBcoG+zFdsKpAKnt//uG0Z0qW8CH1A+jiWYOUdDmvHQLYiP7JUIDmQl hFIQ5fxO7qlFZMtWHBTsORAGOFDIJrVbdBku/2fYFsMeTt7kWMwSXilOl2slmw== Message-ID: Date: Mon, 2 Feb 2026 13:46:14 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/vkms: Add YUV410, YUV411, YVU410, and YVU411 support From: Louis Chauvet To: Renjun Wang , hamohammed.sa@gmail.com, simona@ffwll.ch, melissa.srw@gmail.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Last-TLS-Session-Version: TLSv1.3 On 2/2/26 13:14, Louis Chauvet wrote: > > > On 2/1/26 15:02, Renjun Wang wrote: >> Add support for the following planar YUV formats: >> - DRM_FORMAT_YUV410 >> - DRM_FORMAT_YUV411 >> - DRM_FORMAT_YVU410 >> - DRM_FORMAT_YVU411 >> >> These formats are handled by the existing planar_yuv_read_line() >> function, which correctly handles the subsampling defined in each >> format's drm_format_info. >> >> The YVU variants (YVU410, YVU411) are also added to >> get_conversion_matrix_to_argb_u16() to ensure the U and V columns >> are swapped correctly in the conversion matrix. >> >> Signed-off-by: Renjun Wang > > This patch seems correct, so you can add my: > > Acked-by: Louis Chauvet > > But how did you test it? I don't see the support in IGT. You have an > other application / use-case? I revert my Acked-by for this patch. It looks like the list in vkms_config.c wasn’t updated, which means the format won’t be usable by userspace. Could you also add support in IGT so that kms_plane can test it? From what I recall, this shouldn’t be much more complex than the VKMS implementation—just a few switches to handle the proper conversions. Thanks, Louis Chauvet > Thanks, > Louis Chauvet > >> --- >>   drivers/gpu/drm/vkms/vkms_formats.c | 6 ++++++ >>   1 file changed, 6 insertions(+) >> >> diff --git a/drivers/gpu/drm/vkms/vkms_formats.c b/drivers/gpu/drm/ >> vkms/vkms_formats.c >> index dfb8e13cba87..5ef5d49a44ef 100644 >> --- a/drivers/gpu/drm/vkms/vkms_formats.c >> +++ b/drivers/gpu/drm/vkms/vkms_formats.c >> @@ -730,9 +730,13 @@ pixel_read_line_t >> get_pixel_read_line_function(u32 format) >>       case DRM_FORMAT_P012: >>       case DRM_FORMAT_P016: >>           return &YUV161616_semiplanar_read_line; >> +    case DRM_FORMAT_YUV410: >> +    case DRM_FORMAT_YUV411: >>       case DRM_FORMAT_YUV420: >>       case DRM_FORMAT_YUV422: >>       case DRM_FORMAT_YUV444: >> +    case DRM_FORMAT_YVU410: >> +    case DRM_FORMAT_YVU411: >>       case DRM_FORMAT_YVU420: >>       case DRM_FORMAT_YVU422: >>       case DRM_FORMAT_YVU444: >> @@ -921,6 +925,8 @@ void get_conversion_matrix_to_argb_u16(u32 format, >>       memcpy(matrix, matrix_to_copy, sizeof(*matrix_to_copy)); >>       switch (format) { >> +    case DRM_FORMAT_YVU410: >> +    case DRM_FORMAT_YVU411: >>       case DRM_FORMAT_YVU420: >>       case DRM_FORMAT_YVU422: >>       case DRM_FORMAT_YVU444: >