From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DAA89445AD0 for ; Fri, 24 Jul 2026 17:27:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784914031; cv=none; b=YyYWPgyXQPzDRWYoj9N0L6h6hk4RT34+9bEq4zK5fomxVUXAV3OUjJzYt57tbMXy2KDmgUXHwfo3Cj+4mFwZddWSKBFnn0ktJ+5C/QjzJJ4ptKW2TZdJuhovAvW538yacmNB3ADz4t/jx1Iey3r7lruPzC9PyR7XDoJ8iocuqy4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784914031; c=relaxed/simple; bh=7/2f7PPDnywk//9ri199+3+jB563CTBa1UTHshm9lEw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=m6kGlM19yaxiWHM3iruQ+cSykPa6ZkDudmHRMWXfF6rq+6F/RZZ3vKujEE56KJkjjHGIzlvtu2DRwbIg7Xa/qkVLa6poOZhnx4ytYS6s1s6i10MEfXx1NYoJt5ewhoqmhGPFxvEFSxgNgXxVH4EkNnyB1yVBrGZPkaTAvmLu3w0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kXTEdlON; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kXTEdlON" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-8487b7b3fc8so743722b3a.3 for ; Fri, 24 Jul 2026 10:27:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784914025; x=1785518825; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:sender:from:to:cc :subject:date:message-id:reply-to:content-type; bh=U26xbPdFXYP/dp7KbvYNjIdHJ0Q5KZ3g0wD5029039Y=; b=kXTEdlONs7ay7JjThyas2ZWACxH6wqfR4gRleUJ/nom6Nx51Fm/FAbFGrDd06/KKqA r2izXs8Zuo4G52TDij254xKO/PWBdZcS7azvVkzPO+PkyD6E4phyNLrPYW42RcaI5bYp HLzVXsKH+VrXDAdF4dfGmPYIjrVqIwfGjWsYGhJFx61p2b+Ke51o3t8fh6j7Cs1cbZ9U QLuaL0JWl4chTY7Jr7gkQtsaieegNsoGNvpiEk/BL+RZXo6QcxqXKxtmF93xEkmoo2xq G9X5ers1gRDXeKvhAhMmIQB/R/SOHdevXENglJT7Drlmaw6eJ5TgRpWtFmEk+Q41g8Lq QBsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784914025; x=1785518825; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:sender:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=U26xbPdFXYP/dp7KbvYNjIdHJ0Q5KZ3g0wD5029039Y=; b=QwG1IyAxhIg8bzmKQSPLtjWcqKSaqJHsoE5ZzZgnPkOflDRyvw/4gChI3yhNWX1ahb u6SXnUveImeqvXQ2rG77qcFconb33g5zuNp2rGZnspOijWc6EwG7LjQlC7o00tuEKnFt oz1eKXz388IVbqHx9uXJRD946J+gQBwmeAx6BXPk0/fU8csAR8M+WPK7hbqjOiUNmW1Z BFsASOWgCZFxR7DUTwueQ5hTaWgQj8ep/uSHHGBYLZvVQxmm86VRBOcp7YXdVzNSwACD c3Da5tv6FLShKN8SQjzKIhQTKVw9jBLa8V7bbeaTes6XMW67DJkE4EIdIHVH85CWnbau gVlg== X-Forwarded-Encrypted: i=1; AHgh+RounyR344pdzQPGKz6ws8+qm19CWf2pQR9YQCKBhwrD1InbUP5wZXmnkM3MbWl0a2ZevmgRRtuWOYcMVLE=@vger.kernel.org X-Gm-Message-State: AOJu0YxrGt5CUL6+uZGmlvBmcgSju343pzovtKUHxo1NkxnTINZdy4yV cNVxUTOn8/x25JC/GQ/RQyk+FmawKioQsd1UGKdliS3EEqRQ7SH6//aq X-Gm-Gg: AR+sD13MKwnpeYMtAzE+76A32nPvJGH2OTmrRT32zjMnP7Bih7PTm9lyk9vFQqpJuCy LX2I2B5H56kj3rdytVLyFRF2oXoMOeALSkJrWg2+vHmUhpRLOhTOW6Tz4GLJiWLoJf1oJWXON0m KHIYJ+3UMjxKJuj8cKytPXJ90GfZVwUpMsfXljJ+DzKzCO+HlmvnQ1ZsfUPZGqoz2C65maQpRTv HiPwJAa1LYOmtMVjvDxS3pwmgkLjB5tdOMTaFVegpxmKwqBL+naE/eDlQK360VsW8NQm67UoSfD ZTSMRlHEG/CFxC6BF3y49OPwjkfRU/fEQr9B7HFjQ82QPw8lZ4nBbakBNAGsWra8vWULAsbAKti I7W5hi/1eB6FkPTM6tjCjCqWnXd6hdQ5TIX/j0decHPh/kzFJsb7nBdlcTjOuZd7N7vC/PVKrrb 4HjbSnlx7w6TBe9MA= X-Received: by 2002:a05:6a00:4b51:b0:847:8f8a:a05d with SMTP id d2e1a72fcca58-84e2bc6b53dmr8461030b3a.29.1784914025173; Fri, 24 Jul 2026 10:27:05 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84e53258428sm229838b3a.12.2026.07.24.10.27.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2026 10:27:04 -0700 (PDT) Sender: Guenter Roeck Date: Fri, 24 Jul 2026 10:27:03 -0700 From: Guenter Roeck To: "Pradhan, Sanman" Cc: "linux-hwmon@vger.kernel.org" , "robh@kernel.org" , "krzk+dt@kernel.org" , "krzk@kernel.org" , "conor+dt@kernel.org" , "corbet@lwn.net" , "skhan@linuxfoundation.org" , "devicetree@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Sanman Pradhan , Georgi Vlaev , Dhruva Devineni , Debjit Ghosh , Jawahar Balaji Thirumalaisamy , Avadhut Naik , Santhanakrishnan Balraj , Brian Mak Subject: Re: [PATCH v3 2/2] hwmon: (pmbus/vt7505) Add driver for Analog Devices MAX16545/MAX16550 and Volterra VT7505 Message-ID: References: <20260724164919.247162-1-sanman.pradhan@hpe.com> <20260724164919.247162-3-sanman.pradhan@hpe.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260724164919.247162-3-sanman.pradhan@hpe.com> On Fri, Jul 24, 2026 at 04:50:00PM +0000, Pradhan, Sanman wrote: > From: Georgi Vlaev > > Add a PMBus driver for the Analog Devices MAX16545 and MAX16550, and the > Volterra VT7505 controllers. The driver reports input/output voltage, > input/output current, input power and temperature over PMBus. All values > use the direct data format. Peak input voltage, output voltage, output > current, input power and temperature readings are exposed and can be > reset. > > The reported current and power depend on the external current-report > resistor connected to the ILOAD pin, which can be provided through the > "adi,rload-ohms" device tree property. > > On the MAX16550 and VT7505, the severe-OCP deglitch time can optionally > be configured with the "adi,ocp-severe-filter-us" device tree property. > When omitted, the existing hardware setting is left unchanged. > ... > +static void vt7505_set_m(int *m, u32 rload) > +{ > + u64 val = (u64)*m * rload; > + > + /* Make sure m fits the s32 type */ > + *m = DIV_ROUND_CLOSEST_ULL(val, 1000); The largest possible value of m is 7578. That means that this _will_ overflow if rload >= 283383960 because 283383960 * 7578 / 1000 = 2147483648.88, rounded up to to 2147483649 == 0x80000001. Please add a range check in the probe function. Thanks, Guenter