From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752449AbcHHJin (ORCPT ); Mon, 8 Aug 2016 05:38:43 -0400 Received: from hqemgate14.nvidia.com ([216.228.121.143]:19714 "EHLO hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751280AbcHHJim (ORCPT ); Mon, 8 Aug 2016 05:38:42 -0400 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Mon, 08 Aug 2016 02:35:27 -0700 Subject: Re: [Regression] "irqdomain: Don't set type when mapping an IRQ" breaks nexus7 gpio buttons To: John Stultz , Thomas Gleixner References: <20160805181253.GA18546@buildbox> CC: Marc Zyngier , lkml , Bjorn Andersson , Linus Walleij From: Jon Hunter Message-ID: Date: Mon, 8 Aug 2016 10:04:58 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160805181253.GA18546@buildbox> X-Originating-IP: [10.26.11.212] X-ClientProxiedBy: UKMAIL102.nvidia.com (10.26.138.15) To UKMAIL101.nvidia.com (10.26.138.13) Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/08/16 19:12, John Stultz wrote: > On Sat, Jul 30, 2016 at 1:07 AM, Thomas Gleixner wrote: >> On Fri, 29 Jul 2016, John Stultz wrote: >>> Hey Jon, >>> So after rebasing my nexus7 patch stack onto pre-4.8-rc1 tree, I >>> noticed the power/volume buttons stopped working. >>> >>> I did a manual rebased bisection and chased it down to your commit >>> 1e2a7d78499e ("irqdomain: Don't set type when mapping an IRQ"). >>> >>> Reverting that patch makes things work again, so I wanted to see if >>> there was any debugging info I could provide to try to help narrow >>> down the problem here. (Sorry, I'd tinker myself with it some and try >>> to debug the issue, but after burning my friday night on this, I'm >>> eager to get away from the keyboard for the weekend). >> >> dmesg should contain debug output which yells about non matching types. Can >> you provide that? > > I'm not seeing anything about problematic type matching in the dmesg. > > I've also added LinusW's patches but that didn't seem to help either. > > dmesg attached. I am wondering if it is related to ... [ 1.678160] apq8064-pinctrl 800000.pinctrl: pin GPIO_16 already requested by 16540000.serial; cannot claim for 16580000.i2c [ 1.678207] apq8064-pinctrl 800000.pinctrl: pin-16 (16580000.i2c) status -22 [ 1.678362] 1-0010 supply vcc33 not found, using dummy regulator [ 1.678779] 1-0010 supply vccio not found, using dummy regulator [ 1.702427] apq8064-pinctrl 800000.pinctrl: could not request pin 16 (GPIO_16) from group gpio16 on device 800000.pinctrl Cheers Jon -- nvpublic