From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH 3/8] staging: rtl8192e: Remove unused variable bShift
Date: Wed, 21 Feb 2024 22:45:07 +0100 [thread overview]
Message-ID: <ff505fd05683a59b02ac2e3da115718d8a22735b.1708461563.git.philipp.g.hortmann@gmail.com> (raw)
In-Reply-To: <cover.1708461563.git.philipp.g.hortmann@gmail.com>
Remove unused variable bShift as it is set and never evaluated.
Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
---
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 4 ----
drivers/staging/rtl8192e/rtllib.h | 1 -
2 files changed, 5 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
index 59110da6c4f3..aeff01e921e4 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
+++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
@@ -1649,7 +1649,6 @@ bool rtl92e_get_rx_stats(struct net_device *dev, struct rtllib_rx_stats *stats,
stats->bHwError |= 1;
if (stats->bHwError) {
- stats->bShift = false;
return false;
}
@@ -1672,9 +1671,6 @@ bool rtl92e_get_rx_stats(struct net_device *dev, struct rtllib_rx_stats *stats,
stats->TimeStampLow = pDrvInfo->TSFL;
stats->TimeStampHigh = rtl92e_readl(dev, TSFR + 4);
- if ((stats->RxBufShift + stats->RxDrvInfoSize) > 0)
- stats->bShift = 1;
-
stats->RxIs40MHzPacket = pDrvInfo->BW;
_rtl92e_translate_rx_signal_stats(dev, skb, stats, pdesc, pDrvInfo);
diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
index bc4479f7d089..1949fad401d0 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -487,7 +487,6 @@ struct rtllib_rx_stats {
u16 Decrypted:1;
u32 TimeStampLow;
u32 TimeStampHigh;
- bool bShift;
bool bIsQosData;
u8 RxDrvInfoSize;
--
2.43.2
next prev parent reply other threads:[~2024-02-21 21:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-21 21:44 [PATCH 0/8] Remove unused variables from rtllib_rx_stats Philipp Hortmann
2024-02-21 21:44 ` [PATCH 1/8] staging: rtl8192e: Remove variables tsf, beacon_time and Antenna Philipp Hortmann
2024-02-21 21:44 ` [PATCH 2/8] staging: rtl8192e: Remove variables Wakeup, Reserved0 and AGC Philipp Hortmann
2024-02-21 21:45 ` Philipp Hortmann [this message]
2024-02-21 21:45 ` [PATCH 4/8] staging: rtl8192e: Remove variables bIsQosData and RxIs40MHzPacket Philipp Hortmann
2024-02-21 21:45 ` [PATCH 5/8] staging: rtl8192e: Remove variables fraglength and packetlength Philipp Hortmann
2024-02-21 21:45 ` [PATCH 6/8] staging: rtl8192e: Remove unused variables nic_type and RxPower Philipp Hortmann
2024-02-21 21:45 ` [PATCH 7/8] staging: rtl8192e: Remove unused variables bShortPreamble and fragoffset Philipp Hortmann
2024-02-21 21:46 ` [PATCH 8/8] staging: rtl8192e: Remove unused variables ntotalfrag and Seq_Num Philipp Hortmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff505fd05683a59b02ac2e3da115718d8a22735b.1708461563.git.philipp.g.hortmann@gmail.com \
--to=philipp.g.hortmann@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®