mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Nirmoy Das <nirmoyd@nvidia.com>, axboe@kernel.dk
Cc: ming.lei@redhat.com, hare@suse.de, dwagner@suse.de,
	linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH] blk-mq: clear stale inactive flag on hctx reuse
Date: Tue, 20 Oct 2026 07:13:46 -0700	[thread overview]
Message-ID: <ff516ed8-d4b0-463d-952b-14cf110ec8da@acm.org> (raw)
In-Reply-To: <20261020125129.430600-1-nirmoyd@nvidia.com>

On 10/20/26 5:51 AM, Nirmoy Das wrote:
> diff --git a/block/blk-mq.c b/block/blk-mq.c
> index 025a799f35b924d..00b75eb95dd943a 100644
> --- a/block/blk-mq.c
> +++ b/block/blk-mq.c
> @@ -4002,6 +4002,7 @@ static int blk_mq_init_hctx(struct request_queue *q,
>   		goto fail;
>   
>   	hctx->queue_num = hctx_idx;
> +	clear_bit(BLK_MQ_S_INACTIVE, &hctx->state);
>   
>   	hctx->tags = set->tags[hctx_idx];

Why clear_bit() instead of __clear_bit()?

Thanks,

Bart.



  reply	other threads:[~2026-10-20 14:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-20 12:51 Nirmoy Das
2026-10-20 14:13 ` Bart Van Assche [this message]
2026-10-20 14:28   ` Nirmoy Das
2026-10-20 14:39   ` Jens Axboe
2026-10-20 14:40 ` Jens Axboe
2026-10-20 14:43   ` Nirmoy Das

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ff516ed8-d4b0-463d-952b-14cf110ec8da@acm.org \
    --to=bvanassche@acm.org \
    --cc=axboe@kernel.dk \
    --cc=dwagner@suse.de \
    --cc=hare@suse.de \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ming.lei@redhat.com \
    --cc=nirmoyd@nvidia.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®