From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17F27C10DCE for ; Thu, 7 Dec 2023 09:16:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378484AbjLGJQT (ORCPT ); Thu, 7 Dec 2023 04:16:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52198 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230145AbjLGJQQ (ORCPT ); Thu, 7 Dec 2023 04:16:16 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 280971AD; Thu, 7 Dec 2023 01:16:21 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3B38012FC; Thu, 7 Dec 2023 01:17:07 -0800 (PST) Received: from [10.57.6.119] (unknown [10.57.6.119]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 876463F6C4; Thu, 7 Dec 2023 01:16:19 -0800 (PST) Message-ID: Date: Thu, 7 Dec 2023 09:17:20 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH] thermal/debugfs: Add thermal debugfs information Content-Language: en-US To: "Rafael J. Wysocki" , Daniel Lezcano Cc: rjw@rjwysocki.net, rui.zhang@intel.com, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org References: <20231110181123.2389186-1-daniel.lezcano@linaro.org> From: Lukasz Luba In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/6/23 21:43, Rafael J. Wysocki wrote: > On Fri, Nov 10, 2023 at 8:37 PM Daniel Lezcano > wrote: >> [snip] >> diff --git a/drivers/thermal/thermal_core.h b/drivers/thermal/thermal_core.h >> index 0a3b3ec5120b..809d37d0aa28 100644 >> --- a/drivers/thermal/thermal_core.h >> +++ b/drivers/thermal/thermal_core.h >> @@ -13,6 +13,7 @@ >> #include >> >> #include "thermal_netlink.h" >> +#include "thermal_debugfs.h" >> >> /* Default Thermal Governor */ >> #if defined(CONFIG_THERMAL_DEFAULT_GOV_STEP_WISE) > > The change below is large and rather hard to grasp as a whole. > > It would be easier to process if it is split into a few smaller > changes building on top of each other IMO. > > Personally, I would start with stubs of the functions that are called > from the core and subsequently add more and more code to them. I agree, for this approach for this patch. Also we implicitly agreed that this CONFIG_THERMAL_DEBUG can fly upstream. What would be built on top in the framework and in governors, could be developed in steps, IMO. Thanks for starting this debugfs support.