From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754120AbdEQLIo (ORCPT ); Wed, 17 May 2017 07:08:44 -0400 Received: from mail1.skidata.com ([91.230.2.99]:11713 "EHLO mail1.skidata.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751974AbdEQLIn (ORCPT ); Wed, 17 May 2017 07:08:43 -0400 X-Greylist: delayed 600 seconds by postgrey-1.27 at vger.kernel.org; Wed, 17 May 2017 07:08:42 EDT X-IronPort-AV: E=Sophos;i="5.38,353,1491256800"; d="scan'208";a="4059698" To: Linux USB List , "linux-kernel@vger.kernel.org" CC: Greg Kroah-Hartman , Krzysztof Kozlowski , Javier Martinez Canillas , Richard Leitner , Stephen Boyd From: Richard Leitner Subject: Microchip USB Hub Driver Harmonization Message-ID: Date: Wed, 17 May 2017 12:58:38 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [172.16.60.30] X-ClientProxiedBy: sdex1srv.skidata.net (172.16.10.92) To sdex2srv.skidata.net (172.16.10.93) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, due to the fact (all?) the Microchip (former SMSC) USB hubs share the same I2C configuration interface, I'm currently working on harmonizing those USB Hub drivers. Currently this affects the usb251xb, usb3503 and usb4604 drivers. To avoid preventable efforts (and patch versions) I have some question on the preferred implementation: 1. Currently usb251xb uses i2c_smbus_*, usb3503 uses regmap_* and usb4604 uses i2c_master_* functions for the hub configuration. What would be the preferred solution? 2. What would be a good prefix for common headers/functions/macros/etc.? I thought of "mcusbhub"... Would that be OK? Or are there any conventions/better proposals on that? 3. Currently only usb3503 supports "platform data". Is this still needed or may it be removed? Thanks & kind regards, RichardL