From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04896C47255 for ; Mon, 11 May 2020 13:43:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D51F0206B7 for ; Mon, 11 May 2020 13:43:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="BFToSqLl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730162AbgEKNn2 (ORCPT ); Mon, 11 May 2020 09:43:28 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:31112 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729279AbgEKNn1 (ORCPT ); Mon, 11 May 2020 09:43:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589204606; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2B7uPape2I014WfjGR+zUrOyLplbfNy3rAyirYvotDU=; b=BFToSqLl4bXIvCnlbtGGUXNabFio9BKuEWz5nPBWiewMcrI/RUnvT2UWLUJjwnL0V1C6OH QIvPJEzV8p7Wo6LX1kCUH6/3fKxp9KGXb5xQvW8pIpK35RpJVlaAAkFykfCliCe/NUnkiO iDPKv6CK8rz9tAb5wEYy659Y2QoSs3c= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-506-SgIWMMZ0NyOVZPUX71462A-1; Mon, 11 May 2020 09:43:15 -0400 X-MC-Unique: SgIWMMZ0NyOVZPUX71462A-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0A95B107ACF3; Mon, 11 May 2020 13:43:14 +0000 (UTC) Received: from [10.3.128.27] (unknown [10.3.128.27]) by smtp.corp.redhat.com (Postfix) with ESMTP id 156965C1D3; Mon, 11 May 2020 13:43:11 +0000 (UTC) Subject: Re: Failure to shutdown/reboot with intel_iommu=on To: Joerg Roedel , =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= Cc: linux-kernel@vger.kernel.org, rafael.j.wysocki@intel.com, tglx@linutronix.de, x86@kernel.org, Lu Baolu References: <20200506144558.GA4019@taurus.defre.kleine-koenig.org> <20200508150734.GP8135@suse.de> From: Lenny Szubowicz Message-ID: Date: Mon, 11 May 2020 09:43:11 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200508150734.GP8135@suse.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/8/20 11:07 AM, Joerg Roedel wrote: > + Baolu, Maintainer of Intel IOMMU > > Baolu, does that ring any bells? > > On Wed, May 06, 2020 at 04:46:02PM +0200, Uwe Kleine-König wrote: >> Hello, >> >> On my Lenovo T460p I cannot shutdown and reboot when the iommu is >> enabled. This is using linux 5.2.7 as provided by Debian, 5.6.4 has the >> same problem. Suspend/resume also fails; I suspect this is the same >> issue. >> >> When requesting power off the kernel messages just end with: >> >> sd 0:0:0:0: [sda] Synchronizing SCSI cache >> sd 0:0:0:0: [sda] Stopping disk >> e1000e: EEE TX LPI TIMER: 00000011 >> ACPI: Preparing to enter system sleep state S5 >> reboot: Power down >> acpi_power_off called >> >> (photo at https://www.kleine-koenig.org/tmp/uklsiommu.jpg in case I >> mistyped something. Full dmesg and lspci -vvv at >> https://www.kleine-koenig.org/tmp/uklsiommu.tar.gz with and without >> iommu enabled.) >> >> With the iommu disabled (CONFIG_INTEL_IOMMU_DEFAULT_ON unset or >> intel_iommu=off on cmdline) the machine just works as expected >> (including working suspend/resume). >> >> I already talked to tglx on irc but unfortunately no new insights >> resulted from that. >>> Any ideas how to fix or continue debugging the issue? >> >> Best regards >> Uwe > > I suspect that you have TPM 2.x functionality enabled in the BIOS/firmware. Unless you are actually using the TPM, try setting it to TPM 1.2 mode. I've seen an incompatiblity on other Lenovo laptops between using the IOMMU, TPM 2.x implementation in firmware, and shutdown/suspend. -Lenny.