From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 810F91547E4 for ; Fri, 3 Jan 2025 23:33:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.165.32 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735947220; cv=fail; b=BavNr3mpAl7uzbYkJdPg13VEVTg+r0WLULuQR2XCBXz0q2Wan1LAJ620/yyo2k/AwSPjic942F+MJ/NmTyQawK3iUILfaTR0KKo+59eqhMd2hQe/Kty1iK100qGyl1hYbXS+N+vBpyI+dCSPtzfA8HWRLa6nRX2tlv52j3a2BN0= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735947220; c=relaxed/simple; bh=nHRTjcpvN5cKmZMEeEE4uxhLnvjtVo4kpTnS8yNXqYc=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=HcI4kDoraB8ncHjk2yp5vYsyiFopYmlerHrePeFwIbEZ3JI6H7vRtzj18ApaoeSZnfxBHffrDlVJQJVhi5pa4HMkMokBSboRO5Dydxp/76CMcd6z4Su4iGv9qqlFDR4TzlBiGJR6e7DB0InggfdNjv66e+v2tN3k6w7g1DUFfoI= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=ggNBQr91; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b=Vdvp0Wqc; arc=fail smtp.client-ip=205.220.165.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="ggNBQr91"; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b="Vdvp0Wqc" Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 503NVWCT024192; Fri, 3 Jan 2025 23:33:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2023-11-20; bh=8KXf8i1Ep/4qcyrLrG kr1agY5Oed2B3kU+3jq+hI8Cg=; b=ggNBQr912LvCj9psDemVnwUkO8H4F7c+0A niGgvpWYadL8SkFDwglKCb75+5ILwzVBWZObzLxyw/VjYpEQCUW9WDLR90lV3r8T y7l3GMxVlJpKL9/HvGQFGpaJ2spvSjp7KXJAZ9OzJ4fJ8gqUsbNKp0dgqsp+4H4i G9XuWk8zpJT/nUc4G56T4q5dMvl/16RofHB+xJkJpYBErGawl0z2oNFaC6iHfQiH pS8sxoJvy8bAniRfQq2DJ2h6+ouCsEKzSQ356kRB3UbHoHFbzpHcWJ/vz/RH+4wa xArRJmnIbMbSuaqM3/l2uplvTFmm8hGqBmyoMn39XPKENYclzO+A== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 43t978rspw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 03 Jan 2025 23:33:30 +0000 (GMT) Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 503N4GaD012329; Fri, 3 Jan 2025 23:33:29 GMT Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2042.outbound.protection.outlook.com [104.47.55.42]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 43t7sa5urv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 03 Jan 2025 23:33:29 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=jVQdhXo2YPfoqnRfq6N05aGUbGV8xVTC5UyjqozeC9llI5yzFOyQ0py/zbau6UBjnRxQRoWxKK+aAvNaAP6IgcRiIwPBzDqYXoeBHxNcWVME3ig/yU68R200T4IswayUqH4a73Hhx2Hbbt3EwJAGOgoZ88k3qK+fNM+f9SNgiDfkACu2ji7C5grHC0I2AEAdsgdg2THb0Nj9E2JuJmdFlZMr0K5Sst449OfJ4+fhqsSW0niLjBaNdua9pa7fuFNtvye0Ev15OcPMrocUbdEP2LIgWj16Eyyx0p8oaznDvN3MGztO8Sm+NjmeZ0RSMNFwkN8u6o3hXL+GV5Kch0lJDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8KXf8i1Ep/4qcyrLrGkr1agY5Oed2B3kU+3jq+hI8Cg=; b=i9TaFxFdVPDwaQ/24XjuY4nVURiZ+5NnvCxI5VxFOSbHYwMUdOS4npoyURjLBxtK4r/nuDPyRSkvlF5GKTCPnRXqAmRTMLJR5xESIf5kNUH60WU+D/BmZln3muCX5F+OHpbBHC9Dp39xBNl7B10WYxAm7yuA0gXu6yV83lVhwF/gO3ko4PUHUj2Vw8WQ++XXHpippM6btaKOn3kkKkyRP49fsyclr3+KnHKUGmaG6qwo5rxxgWfKHR3rzt91zGJNnyGF4z072+emsbVfqqIqkusxnCUUYgf9G597XyFTRnI+1vJmoeM+CY0+7SGibkrg1rP6Jz69S6OQirrLb7lERg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8KXf8i1Ep/4qcyrLrGkr1agY5Oed2B3kU+3jq+hI8Cg=; b=Vdvp0WqcBicLs5wkmk4k38peGYqnfSlvKf0/rg78qr97GkrQUb4mB31HosiOIPGUDvYu1j8b7h+VxXHYZxgx0yECCMICWLwEuknryFkY+CEX778ZaBNNR42IYExhvWGffKVXofJdSINJCsMwlUIm6N3/yVpfMe0w0MAEq9MDR1c= Received: from BYAPR10MB3366.namprd10.prod.outlook.com (2603:10b6:a03:14f::25) by PH7PR10MB6106.namprd10.prod.outlook.com (2603:10b6:510:1fa::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8314.13; Fri, 3 Jan 2025 23:33:23 +0000 Received: from BYAPR10MB3366.namprd10.prod.outlook.com ([fe80::baf2:dff1:d471:1c9]) by BYAPR10MB3366.namprd10.prod.outlook.com ([fe80::baf2:dff1:d471:1c9%4]) with mapi id 15.20.8314.012; Fri, 3 Jan 2025 23:33:23 +0000 Date: Fri, 3 Jan 2025 23:33:19 +0000 From: Lorenzo Stoakes To: Koichiro Den Cc: linux-mm@kvack.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] vmstat: disable vmstat_work on vmstat_cpu_down_prep() Message-ID: References: <20241221033321.4154409-1-koichiro.den@canonical.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241221033321.4154409-1-koichiro.den@canonical.com> X-ClientProxiedBy: LO2P123CA0093.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:139::8) To BYAPR10MB3366.namprd10.prod.outlook.com (2603:10b6:a03:14f::25) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR10MB3366:EE_|PH7PR10MB6106:EE_ X-MS-Office365-Filtering-Correlation-Id: dc670a0b-446e-4478-78db-08dd2c4f034d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?bl6xsiNaubSBQyXD2BJopPLvlAUMEAq3la2J2aYwMf/md+8uHnszqa8BHKTm?= =?us-ascii?Q?3aME3WzjWjzTbnf6s+P23Rp+s1UAxZhTXmZO42wJZrOrm8SNOPO0eupzYWgo?= =?us-ascii?Q?IchbWa52JBLqlSWO3n8y3t48QPJ07AsPNrtGf5K7NmQF8pQiibjVfxLM9Ika?= =?us-ascii?Q?Afdw/eu3BRbnTDa5qCTk5wDdKDU5dDSBmF5x+w2X4nmuERjS82hfkKlWpO4P?= =?us-ascii?Q?N+trJEfk4ej13m6tKbj6nxUzdF49tBPUGiCIw0DJpQno1fckQRIz49PzTdcN?= =?us-ascii?Q?0J8C7+WLJs05JR73zCoe0HjtL3l3JYF90D+qbFjrXQVYvEU8wzfJH/X2hz5F?= =?us-ascii?Q?Fu/b5gSCLUaDE/3YXU89BDJJ5StCGxbyG1ugxch9YssFn8hzGhiDTZYBsET+?= =?us-ascii?Q?O+OEHUybhCg/ycYiwFkVknIH0nU94b90YMV/zYFwk1vyYxDaKwXmiQKyD7gB?= =?us-ascii?Q?NREFJZ18xLgfqmzDfXSJimKor2e5TDDgPQ1N/J7CsS134LpvYyUo00OwkaXq?= =?us-ascii?Q?f9ROOohoPuKNhxMVDr+kB2+pztysaF8V5/HGVPn4uAdAoRIKB/24jvy4CWoL?= =?us-ascii?Q?eYOjNMMV7cUCajKkrv44HY1mRn7juZm7y0kb/nwQeDI6BkntraPJjUlY96wh?= =?us-ascii?Q?AoqSNJq0KlRfXvw3D+cZtPc4bri9U5FwAdXc3ZR+knLmTxAtS5/kkMT+Tv/T?= =?us-ascii?Q?ZzNtRHBCzRPr1+rfdcon47IaFcVCmaGXVdsiU0mDY48QIEEa3iPYk5S+Q6ki?= =?us-ascii?Q?wzd9MYEbzgm6cJijVBR+NRnUg7pu0BV8N4IH7Qby4XMn8AGw2u8NZu1hgggf?= =?us-ascii?Q?ouXSd7LFiGj8QyWWTGO79Ncdw0Wkomn9TDY1QaLTxAGG/fJfbrMITTj6GPz6?= =?us-ascii?Q?k1aXVfTy7/o7u6SDV9jQQG+9j2LBai58E/wuxnXG5wZpaFfl6atgFrEK+5fg?= =?us-ascii?Q?Su9wGZ43xF3cBUJtb4S+MLA1N7Xd0kU3xYODTCfEMpp26crWIkKTsJYLPPpz?= =?us-ascii?Q?RFxltAlYzYf3IAH8Nk2T7Mpe5ip4fHxrKDvbOEXm5oQUpsoxLYoAhiStZkHw?= =?us-ascii?Q?01Yub6o6PtJ0SNMn0k72HcS/ZONXgDB2VGP4If++gJmYFdYPg2dysC+lGK/i?= =?us-ascii?Q?BAoL3WIgxXtWM2nd/sb3BiAmvJ/bMMxT+U5tqIHm5nyCqjjElwEe9RFqeUXH?= =?us-ascii?Q?+HA9MQD6PsIEdzEYjU2k1V2hyV9FWoPj32yNfs8ashuDFherGWHYa5oULLBz?= =?us-ascii?Q?J0BTjKqMfzqilICaChct//h/u+w/JHo4qrxTelHrY0L0orxv+yU+h0CW1xmK?= =?us-ascii?Q?L08+zFaXniuCrcltdTn6nka8egmc2TCYNmQAuD1WvI+ow0XGcfDBRy6JWXzd?= =?us-ascii?Q?lg4uF0s8LKP5yg4JLBQwugr7fg3c?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB3366.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(1800799024)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?S2chqqiaq17r/MQ3keDne+PoqTU7pCJaqjwnOwJ9TYUWgAF/iqltJahph4WW?= =?us-ascii?Q?ZGd+QhvaDNjOSXoSsRQVXx92EMfz8VFDW4ss8RB/7bbETIgrPiRY/eb/S6Up?= =?us-ascii?Q?2XD5YLYmhIo8mlgKWl/4j1EL9llZv6aMcK86QktIM6zawSG/e1xaf5rm9mZT?= =?us-ascii?Q?TjWnR0YiKhfBUsriIOyHP58YzTBZZJ38VzSLjKCmi8GaLItl5ebpTNTmw/7b?= =?us-ascii?Q?NLST9RGInIb0Man7AuM8nRg0MBm2tZmhvaMNdztZU1Dwrvggtxa3LkAl+soh?= =?us-ascii?Q?BGPLGx9yYCnHGYNSd/CuWJKIBRW6+Wn5JMQp+WPpFM5o45GLmoeWcEKTH4mJ?= =?us-ascii?Q?NHTcKS9v+Q5Uy4lR9ckSYQdgOdBuLL/crjPqJuBiSDt7ZxgiWhpfvGZhA0vy?= =?us-ascii?Q?M7gdDe4/o9km9YEILx98lKEcVMwnv7tDwKtgCJIgzA8pDFOqw3pgpqYlFtQP?= =?us-ascii?Q?llkXDsq4PHt7X2OMMJVdSU6+aLRGVaGBazO0HdSWZnjWwmqlnZB+g5uDpI/2?= =?us-ascii?Q?C5q65LFmYv6ZT5b1iraHHjqWe2fkIndzY4IUuadJk/LVmhBR2o7ZSrcOAAPB?= =?us-ascii?Q?aEoaAbFcah9ZG6x3HH65Owxp5R5T8LvAzkYcoTSoo2i1M1/8P/MR/KqB22+G?= =?us-ascii?Q?KgAmtoksDfmlinxCiBJQV4j6uSY6K8hzXUZE56NdjFfr0VuTYRFlfpbflzUx?= =?us-ascii?Q?rxf21rZWtUQvxi/w37+ZUWkbjjnl8JEozEcpbKjKrlh1BAsfZP8T+FXOeJ7d?= =?us-ascii?Q?YfOTKDuxIthAcg49ga3d1s6noPnLjqWUKgHFUcisRI1XQNiHkXeqVk8+8DDu?= =?us-ascii?Q?sfsS8aL96nMWMkt8wMalPGfpvBNj9fcwkALE8mGcnoJJrVaMU2j1YfkI7avN?= =?us-ascii?Q?vbK65SHJt+v4SK4cdFwcFsCEMoovHO8bPFXIVWl3fWCkJQqvCP/v9NXiBdKR?= =?us-ascii?Q?NvdP8rnmyMyZvXBOs/62DYS4whyoDoe5oLCnbzFGf1Z1VEu8E5CE5zq2oeVS?= =?us-ascii?Q?5d9pVM3z55XP4q+JKpw42tcsA62cfdKJKXWecvXHFT1DAccXHGr8wFMkwZLw?= =?us-ascii?Q?b1/p7vC85uFZ/KGQ2blPrgOPuoYhHFZWPdBF68DwihwNeeIqrsRSHVoC0889?= =?us-ascii?Q?3WmQTpBaq7uJT1mHhrbQ0FsLotUrfnPA8YVzsKjgLKDUBB993eIHBZcfx4t/?= =?us-ascii?Q?HZ0gjnNWwLIsR0+t3v3BWI9HM1C7zu9n4ulVaqBdEe7ewAlwNqv2H45QiPit?= =?us-ascii?Q?HR6Q/kgjDtrrYW2wo0e1yB7iGeVNonfHi0CilU1Ha/K2z6NFaCpsiePFghl0?= =?us-ascii?Q?9WZ4+OHmUE1R1rtFvBZ43ah5oXpT1vkjuEbD1NaFUHaCRoIWWZ/VWZymY/WG?= =?us-ascii?Q?w1xdnH5u1Vhn9Q5R0e+0+taUx094x7KMmdJy1ju0b4nYfG7S5yltVeBSdd4r?= =?us-ascii?Q?WXfKEAuboNvfoIsUrSuU9YUsIadhwTTYXkq0sBzb0ZhyRcNncjV/eWv8FVDY?= =?us-ascii?Q?Vr15AsxCb5dwjszvEDF2X5zOtpLcZO4Q6ZqJ/Kolq9SkwtlyRMWDOd+4VgiD?= =?us-ascii?Q?acu98FT9Lo2N0DbTuZOyh8iqWnNBCXNnvOEw9QqKDGuAkZeo0K1a4r9eyy95?= =?us-ascii?Q?sQ=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: eb7gF459WGG9R2fABGvDxBos0fpkvYnJsraqnmxPIloCGiOVjtte3TTqjn60yJBG/orWujOR9iGCPAgGbPDlHeyFecq8AAOgPBpg/ossr5ow9mGOR13PF2r9NzxcF6MYOAH8If4rlUWyTThjw/UKRvsuTBAW31nbkh0m4BQIboNkExHayAO1c3rr4KksqPhUb8UqE174O5y+3cnajCGOxSNJq6iEhYpHYPOvZf913RGDo3U+XdfglHdvRmZ1y2+4/Vel+QSGnHBhYZmN19Yz/2q5/H83cEqFH1LqVQHTdMzVAQDebTKajiyyef7yDLSkqRX2wJ0LXeQ0Kpv+MSuiIxbg00SNNpuXmVhfWyhQz0c5fYUKJEJfOSwfxDy71XkQaB6aDy5qpXfPr7MHUGuvm94HR6x46e1DTVtJl/eju1OHZYAupUKYVZDbl35K8VNjUoS9JX7jTeHJmDYTPnbhTZ72UAqbT4fVzO8jCeeRYp0GNOfymNy3YGwzORGfyTf0BqrT7sjnuzatHQh6ZOUPintbm+pVHrwpaho05yqpLfLpmdfDtsC0w0VejvoyE/S7LDF7cidXJoRK1GYi9jB6d0wddw0zzzDfT9I7sI8uQn8= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: dc670a0b-446e-4478-78db-08dd2c4f034d X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB3366.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jan 2025 23:33:22.9396 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7+7wp2Fnpx39MseRQoQ8yHivDPZlDbbvvN76c2IDhBAhtwuv4Oa61hE2Yrrw0ixixBetdZ5noqIaf6rC26J5djvnNk/WNKq1mPBd33gaDkI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB6106 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-01-02_03,2025-01-02_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 spamscore=0 bulkscore=0 mlxscore=0 mlxlogscore=778 adultscore=0 suspectscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2411120000 definitions=main-2501030209 X-Proofpoint-ORIG-GUID: E65P8zUjztwDFxHOuUtS1hRbFsifiElD X-Proofpoint-GUID: E65P8zUjztwDFxHOuUtS1hRbFsifiElD On Sat, Dec 21, 2024 at 12:33:20PM +0900, Koichiro Den wrote: > Even after mm/vmstat:online teardown, shepherd may still queue work for > the dying cpu until the cpu is removed from online mask. While it's > quite rare, this means that after unbind_workers() unbinds a per-cpu > kworker, it potentially runs vmstat_update for the dying CPU on an > irrelevant cpu before entering atomic AP states. > When CONFIG_DEBUG_PREEMPT=y, it results in the following error with the > backtrace. > > BUG: using smp_processor_id() in preemptible [00000000] code: \ > kworker/7:3/1702 > caller is refresh_cpu_vm_stats+0x235/0x5f0 > CPU: 0 UID: 0 PID: 1702 Comm: kworker/7:3 Tainted: G > Tainted: [N]=TEST > Workqueue: mm_percpu_wq vmstat_update > Call Trace: > > dump_stack_lvl+0x8d/0xb0 > check_preemption_disabled+0xce/0xe0 > refresh_cpu_vm_stats+0x235/0x5f0 > vmstat_update+0x17/0xa0 > process_one_work+0x869/0x1aa0 > worker_thread+0x5e5/0x1100 > kthread+0x29e/0x380 > ret_from_fork+0x2d/0x70 > ret_from_fork_asm+0x1a/0x30 > > > So, for mm/vmstat:online, disable vmstat_work reliably on teardown and > symmetrically enable it on startup. > > Signed-off-by: Koichiro Den Hi, I observed a warning in my qemu and real hardware, which I bisected to this commit: [ 0.087733] ------------[ cut here ]------------ [ 0.087733] workqueue: work disable count underflowed [ 0.087733] WARNING: CPU: 1 PID: 21 at kernel/workqueue.c:4313 enable_work+0xb5/0xc0 This is: static void work_offqd_enable(struct work_offq_data *offqd) { if (likely(offqd->disable > 0)) offqd->disable--; else WARN_ONCE(true, "workqueue: work disable count underflowed\n"); <-- this line } So (based on this code) presumably an enable is only required if previously disabled, and this code is being called on startup unconditionally without the work having been disabled previously? I'm not hugely familiar with delayed workqueue implementation details. [ 0.087733] Modules linked in: [ 0.087733] CPU: 1 UID: 0 PID: 21 Comm: cpuhp/1 Not tainted 6.13.0-rc4+ #58 [ 0.087733] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Arch Linux 1.16.3-1-1 04/01/2014 [ 0.087733] RIP: 0010:enable_work+0xb5/0xc0 [ 0.087733] Code: 6f b8 01 00 74 0f 31 d2 be 01 00 00 00 eb b5 90 0f 0b 90 eb ca c6 05 60 6f b8 01 01 90 48 c7 c7 b0 a9 6e 82 e8 4c a4 fd ff 90 <0f> 0b 90 90 eb d6 0f 1f 44 00 00 90 90 90 90 90 90 90 90 90 90 90 [ 0.087733] RSP: 0018:ffffc900000cbe30 EFLAGS: 00010092 [ 0.087733] RAX: 0000000000000029 RBX: ffff888263ca9d60 RCX: 0000000000000000 [ 0.087733] RDX: 0000000000000001 RSI: ffffc900000cbce8 RDI: 0000000000000001 [ 0.087733] RBP: ffffc900000cbe30 R08: 00000000ffffdfff R09: ffffffff82b12f08 [ 0.087733] R10: 0000000000000003 R11: 0000000000000002 R12: 00000000000000c4 [ 0.087733] R13: ffffffff81278d90 R14: 0000000000000000 R15: ffff888263c9c648 [ 0.087733] FS: 0000000000000000(0000) GS:ffff888263c80000(0000) knlGS:0000000000000000 [ 0.087733] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 0.087733] CR2: 0000000000000000 CR3: 0000000002a2e000 CR4: 0000000000750ef0 [ 0.087733] PKRU: 55555554 [ 0.087733] Call Trace: [ 0.087733] [ 0.087733] ? enable_work+0xb5/0xc0 [ 0.087733] ? __warn.cold+0x93/0xf2 [ 0.087733] ? enable_work+0xb5/0xc0 [ 0.087733] ? report_bug+0xff/0x140 [ 0.087733] ? handle_bug+0x54/0x90 [ 0.087733] ? exc_invalid_op+0x17/0x70 [ 0.087733] ? asm_exc_invalid_op+0x1a/0x20 [ 0.087733] ? __pfx_vmstat_cpu_online+0x10/0x10 [ 0.087733] ? enable_work+0xb5/0xc0 [ 0.087733] vmstat_cpu_online+0x5c/0x70 [ 0.087733] cpuhp_invoke_callback+0x133/0x440 [ 0.087733] cpuhp_thread_fun+0x95/0x150 [ 0.087733] smpboot_thread_fn+0xd5/0x1d0 [ 0.087734] ? __pfx_smpboot_thread_fn+0x10/0x10 [ 0.087735] kthread+0xc8/0xf0 [ 0.087737] ? __pfx_kthread+0x10/0x10 [ 0.087738] ret_from_fork+0x2c/0x50 [ 0.087739] ? __pfx_kthread+0x10/0x10 [ 0.087740] ret_from_fork_asm+0x1a/0x30 [ 0.087742] [ 0.087742] ---[ end trace 0000000000000000 ]--- > --- > v1: https://lore.kernel.org/all/20241220134234.3809621-1-koichiro.den@canonical.com/ > --- > mm/vmstat.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/mm/vmstat.c b/mm/vmstat.c > index 4d016314a56c..0889b75cef14 100644 > --- a/mm/vmstat.c > +++ b/mm/vmstat.c > @@ -2148,13 +2148,14 @@ static int vmstat_cpu_online(unsigned int cpu) > if (!node_state(cpu_to_node(cpu), N_CPU)) { > node_set_state(cpu_to_node(cpu), N_CPU); > } > + enable_delayed_work(&per_cpu(vmstat_work, cpu)); Probably needs to be 'if disabled' here, as this is invoked on normal startup when the work won't have been disabled? Had a brief look at code and couldn't see how that could be done however... and one would need to be careful about races... Tricky! > > return 0; > } > > static int vmstat_cpu_down_prep(unsigned int cpu) > { > - cancel_delayed_work_sync(&per_cpu(vmstat_work, cpu)); > + disable_delayed_work_sync(&per_cpu(vmstat_work, cpu)); > return 0; > } > > -- > 2.43.0 > > Let me know if you need any more details, .config etc. I noticed this warning on a real box too (in both cases running akpm's mm-unstable branch), FWIW.