From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_RED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F011AC4320A for ; Tue, 3 Aug 2021 05:41:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CC66960F70 for ; Tue, 3 Aug 2021 05:41:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233827AbhHCFlj (ORCPT ); Tue, 3 Aug 2021 01:41:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42178 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229507AbhHCFli (ORCPT ); Tue, 3 Aug 2021 01:41:38 -0400 Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D29A2C06175F; Mon, 2 Aug 2021 22:41:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :In-Reply-To:MIME-Version:Date:Message-ID:From:References:To:Subject:Sender: Reply-To:Cc:Content-ID:Content-Description; bh=uwAkekVM3YUihzDR1kquqE04ZiF9bUkpWcr7bm0ku1c=; b=an7jhKrep5fjlnXrbAgvOtNqTo Pa+gpw2pMXTpDnI1mi1Poh3vO3mzOdDihRcH7SrRaMppCQs8ZH/ZbXob2LrWKpL3x1NGVFYsLvFc8 WOmWfig5EdLAX0zloaTkZvDaIJhpjyCRII7VNSEWCHjUcn7wIrKS1dHNpf09SThogXYsJwpvfzjKN clvgA4cGLF3xdrA8rlWOjBHPopUjlBpzY3VFy71mP9vuFna+Dj8Z8cGpflgOwdw1xMa75Fn8kBnYd BilXhRw3bgMlQ+4Ia6TNxj2UFsPhySoUcIVCgtF015bi5ajJM/SveTU8GhMX2TYTskyoHafjqW1wY Etbawong==; Received: from [2601:1c0:6280:3f0::aa0b] by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1mAnB1-005Kyq-Ew; Tue, 03 Aug 2021 05:41:20 +0000 Subject: Re: mmotm 2021-08-02-18-51 uploaded (struct user_struct when CONFIG_EPOLL is not set) To: akpm@linux-foundation.org, broonie@kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-next@vger.kernel.org, mhocko@suse.cz, mm-commits@vger.kernel.org, sfr@canb.auug.org.au, Nicholas Piggin References: <20210803015202.vA3c5O7uP%akpm@linux-foundation.org> From: Randy Dunlap Message-ID: Date: Mon, 2 Aug 2021 22:41:15 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210803015202.vA3c5O7uP%akpm@linux-foundation.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/2/21 6:52 PM, akpm@linux-foundation.org wrote: > The mm-of-the-moment snapshot 2021-08-02-18-51 has been uploaded to > > https://www.ozlabs.org/~akpm/mmotm/ > > mmotm-readme.txt says > > README for mm-of-the-moment: > > https://www.ozlabs.org/~akpm/mmotm/ > > This is a snapshot of my -mm patch queue. Uploaded at random hopefully > more than once a week. > > You will need quilt to apply these patches to the latest Linus release (5.x > or 5.x-rcY). The series file is in broken-out.tar.gz and is duplicated in > https://ozlabs.org/~akpm/mmotm/series > > The file broken-out.tar.gz contains two datestamp files: .DATE and > .DATE-yyyy-mm-dd-hh-mm-ss. Both contain the string yyyy-mm-dd-hh-mm-ss, > followed by the base kernel version against which this patch series is to > be applied. > I am seeing build errors on i386 or x86_64 when CONFIG_EPOLL is not set: ../kernel/user.c: In function ‘free_user’: ../kernel/user.c:141:30: error: ‘struct user_struct’ has no member named ‘epoll_watches’; did you mean ‘nr_watches’? percpu_counter_destroy(&up->epoll_watches); ^~~~~~~~~~~~~ nr_watches In file included from ../include/linux/sched/user.h:7:0, from ../kernel/user.c:17: ../kernel/user.c: In function ‘alloc_uid’: ../kernel/user.c:189:33: error: ‘struct user_struct’ has no member named ‘epoll_watches’; did you mean ‘nr_watches’? if (percpu_counter_init(&new->epoll_watches, 0, GFP_KERNEL)) { ^ ../include/linux/percpu_counter.h:38:25: note: in definition of macro ‘percpu_counter_init’ __percpu_counter_init(fbc, value, gfp, &__key); \ ^~~ ../kernel/user.c:203:33: error: ‘struct user_struct’ has no member named ‘epoll_watches’; did you mean ‘nr_watches’? percpu_counter_destroy(&new->epoll_watches); ^~~~~~~~~~~~~ nr_watches In file included from ../include/linux/sched/user.h:7:0, from ../kernel/user.c:17: ../kernel/user.c: In function ‘uid_cache_init’: ../kernel/user.c:225:37: error: ‘struct user_struct’ has no member named ‘epoll_watches’; did you mean ‘nr_watches’? if (percpu_counter_init(&root_user.epoll_watches, 0, GFP_KERNEL)) ^ ../include/linux/percpu_counter.h:38:25: note: in definition of macro ‘percpu_counter_init’ __percpu_counter_init(fbc, value, gfp, &__key); \ ^~~ -- ~Randy