From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751457AbdJ1Q4b (ORCPT ); Sat, 28 Oct 2017 12:56:31 -0400 Received: from mail-yw0-f193.google.com ([209.85.161.193]:44835 "EHLO mail-yw0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751230AbdJ1Q40 (ORCPT ); Sat, 28 Oct 2017 12:56:26 -0400 X-Google-Smtp-Source: ABhQp+QGT/42BOktOnZO5KNH//GCjFPpExjLvPhtY9Wg7o4mq6F5WyLkcYuHXczk/HTfJAHavuYpxg== Subject: Re: [PATCH v2 6/7] gpio: brcmstb: consolidate interrupt domains To: Doug Berger , Gregory Fong Cc: Linus Walleij , Brian Norris , Florian Fainelli , bcm-kernel-feedback-list@broadcom.com, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20171024195451.30535-1-opendmb@gmail.com> <20171024195451.30535-7-opendmb@gmail.com> From: Florian Fainelli Message-ID: Date: Sat, 28 Oct 2017 09:56:22 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171024195451.30535-7-opendmb@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/24/2017 12:54 PM, Doug Berger wrote: > The GPIOLIB IRQ chip helpers were very appealing, but badly broke > the 1:1 mapping between a GPIO controller's device_node and its > interrupt domain. > > When another device-tree node references a GPIO device as its > interrupt parent, the irq_create_of_mapping() function looks for > the irq domain of the GPIO device and since all bank irq domains > reference the same GPIO device node it always resolves to the irq > domain of the first bank regardless of which bank the number of > the GPIO should resolve. This domain can only map hwirq numbers > 0-31 so interrupts on GPIO above that can't be mapped by the > device-tree. > > This commit effectively reverts the patch from Gregory Fong [1] > that was accepted upstream and replaces it with a consolidated > irq domain implementation with one larger interrupt domain per > GPIO controller instance spanning multiple GPIO banks based on > an earlier patch [2] also submitted by Gregory Fong. > > [1] https://patchwork.kernel.org/patch/6921561/ > [2] https://patchwork.kernel.org/patch/6347811/ > > Fixes: 19a7b6940b78 ("gpio: brcmstb: Add interrupt and wakeup source support") > Signed-off-by: Doug Berger Reviewed-by: Florian Fainelli -- Florian