From: Michal Simek <michal.simek@xilinx.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>,
Navid Emamdoost <navid.emamdoost@gmail.com>,
Michal Simek <michal.simek@xilinx.com>
Cc: Navid Emamdoost <emamd001@umn.edu>,
Thomas Gleixner <tglx@linutronix.de>,
linux-arm-kernel@lists.infradead.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] clocksource/drivers: Fix error handling in ttc_setup_clocksource
Date: Tue, 17 Dec 2019 16:09:53 +0100 [thread overview]
Message-ID: <ff7aa6a0-3cfd-dab3-f187-7b93131378db@xilinx.com> (raw)
In-Reply-To: <26da3a6b-60f3-d09b-6eff-7a3db8234d64@linaro.org>
On 16. 12. 19 14:41, Daniel Lezcano wrote:
>
> Hi Navid,
>
> On 14/12/2019 23:54, Navid Emamdoost wrote:
>> Would you review this patch, please?
>
> please fix the version number, send without in-reply-to.
>
> Do the same for the other patch:
>
> clocksource/drivers: Fix memory leak in ttc_setup_clockevent
>
> It is a bit confuse what patch is ok or not.
+1 on this. And patch looks good to me but as I said before the same
changes should be done also in ttc_setup_clockevent. It means v2 with
these two things together is the best way to go.
Thanks,
Michal
next prev parent reply other threads:[~2019-12-17 15:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-21 20:18 [PATCH] clocksource/drivers: Fix memory leak in ttc_setup_clockevent Navid Emamdoost
2019-10-22 8:26 ` Markus Elfring
2019-10-22 8:51 ` Michal Simek
2019-10-23 4:31 ` [PATCH v2] " Navid Emamdoost
2019-10-23 7:32 ` Michal Simek
2019-10-23 8:00 ` Markus Elfring
2019-10-23 4:47 ` [PATCH] clocksource/drivers: Fix error handling in ttc_setup_clocksource Navid Emamdoost
2019-10-23 7:24 ` Markus Elfring
2019-10-23 8:20 ` Markus Elfring
2019-10-23 10:31 ` Markus Elfring
2019-12-14 22:54 ` Navid Emamdoost
2019-12-16 13:41 ` Daniel Lezcano
2019-12-17 15:09 ` Michal Simek [this message]
2019-10-23 4:50 ` [PATCH] clocksource/drivers: Fix memory leak in ttc_setup_clockevent Navid Emamdoost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff7aa6a0-3cfd-dab3-f187-7b93131378db@xilinx.com \
--to=michal.simek@xilinx.com \
--cc=daniel.lezcano@linaro.org \
--cc=emamd001@umn.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=navid.emamdoost@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®