From: Nicolai Buchwitz <nb@tipi-net.de>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Ovidiu Panait <ovidiu.panait.rb@renesas.com>,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, shuah@kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net-next v2 3/3] selftests: drv-net: Add VLAN test
Date: Sat, 19 Sep 2026 23:43:15 +0200 [thread overview]
Message-ID: <ff8435132a6b0fbc0f92187e1d9b0f18@tipi-net.de> (raw)
In-Reply-To: <20260918151225.304410cf@kernel.org>
On 19.9.2026 00:12, Jakub Kicinski wrote:
> On Fri, 18 Sep 2026 14:04:13 +0200 Nicolai Buchwitz wrote:
>> > +LOCAL_IP = os.environ.get("VLAN_LOCAL_V4", "198.51.100.1")
>> > +REMOTE_IP = os.environ.get("VLAN_REMOTE_V4", "198.51.100.2")
>>
>> LOCAL_IP = "198.51.100.1"
>> REMOTE_IP = "198.51.100.2"
>
> LOCAL_IP / REMOTE_IP are in the default network segment (vlan 0)
> Here we need some "unused" IP subnet that we can assign without
> conflicts. Getting it from the config would indeed be good, but
> since this is the first use perhaps we should defer until it actually
> bothers someone?
Fine with me. Having the the selftest in place is probably more useful
than re-spinning for sole config issues. Let's fix this once someone
needs it.
> [...]
Reviewed-by: Nicolai Buchwitz <nb@tipi-net.de>
Thanks,
Nicolai
prev parent reply other threads:[~2026-09-19 21:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-18 11:25 [PATCH net-next v2 0/3] " Ovidiu Panait
2026-09-18 11:25 ` [PATCH net-next v2 1/3] selftests: drv-net: Move _set_ethtool_feat() into lib Ovidiu Panait
2026-09-18 11:25 ` [PATCH net-next v2 2/3] selftests: drv-net: Check the features set by set_ethtool_feat() Ovidiu Panait
2026-09-18 11:51 ` Nicolai Buchwitz
2026-09-18 11:25 ` [PATCH net-next v2 3/3] selftests: drv-net: Add VLAN test Ovidiu Panait
2026-09-18 12:04 ` Nicolai Buchwitz
2026-09-18 22:12 ` Jakub Kicinski
2026-09-19 21:43 ` Nicolai Buchwitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff8435132a6b0fbc0f92187e1d9b0f18@tipi-net.de \
--to=nb@tipi-net.de \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ovidiu.panait.rb@renesas.com \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®