From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4A49C6FA82 for ; Wed, 21 Sep 2022 03:04:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229471AbiIUDEx (ORCPT ); Tue, 20 Sep 2022 23:04:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33858 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229818AbiIUDEr (ORCPT ); Tue, 20 Sep 2022 23:04:47 -0400 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA79E101DE; Tue, 20 Sep 2022 20:04:43 -0700 (PDT) Received: from dggpeml500026.china.huawei.com (unknown [172.30.72.57]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4MXNWD2JDTzHpcr; Wed, 21 Sep 2022 11:02:32 +0800 (CST) Received: from dggpeml100012.china.huawei.com (7.185.36.121) by dggpeml500026.china.huawei.com (7.185.36.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 21 Sep 2022 11:04:41 +0800 Received: from [10.67.103.212] (10.67.103.212) by dggpeml100012.china.huawei.com (7.185.36.121) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 21 Sep 2022 11:04:41 +0800 Subject: Re: [PATCH v8 2/3] Documentation: add a isolation strategy sysfs node for uacce To: Greg KH References: <20220902031304.37516-1-yekai13@huawei.com> <20220902031304.37516-3-yekai13@huawei.com> <45a50cf5-7416-4fcf-925b-ecca787425a5@huawei.com> CC: , , , , From: "yekai (A)" Message-ID: Date: Wed, 21 Sep 2022 11:04:41 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.103.212] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpeml100012.china.huawei.com (7.185.36.121) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/9/19 17:34, Greg KH wrote: > On Mon, Sep 19, 2022 at 11:21:30AM +0800, yekai (A) wrote: >> >> On 2022/9/9 16:27, Greg KH wrote: >>> On Fri, Sep 02, 2022 at 03:13:03AM +0000, Kai Ye wrote: >>>> Update documentation describing sysfs node that could help to >>>> configure isolation strategy for users in the user space. And >>>> describing sysfs node that could read the device isolated state. >>>> >>>> Signed-off-by: Kai Ye >>>> --- >>>> Documentation/ABI/testing/sysfs-driver-uacce | 26 ++++++++++++++++++++ >>>> 1 file changed, 26 insertions(+) >>>> >>>> diff --git a/Documentation/ABI/testing/sysfs-driver-uacce b/Documentation/ABI/testing/sysfs-driver-uacce >>>> index 08f2591138af..af5bc2f326d2 100644 >>>> --- a/Documentation/ABI/testing/sysfs-driver-uacce >>>> +++ b/Documentation/ABI/testing/sysfs-driver-uacce >>>> @@ -19,6 +19,32 @@ Contact: linux-accelerators@lists.ozlabs.org >>>> Description: Available instances left of the device >>>> Return -ENODEV if uacce_ops get_available_instances is not provided >>>> >>>> +What: /sys/class/uacce//isolate_strategy >>>> +Date: Sep 2022 >>>> +KernelVersion: 6.0 >>>> +Contact: linux-accelerators@lists.ozlabs.org >>>> +Description: (RW) Configure the frequency size for the hardware error >>>> + isolation strategy. This size is a configured integer value. >>>> + The default is 0. The maximum value is 65535. This value is a >>>> + threshold based on your driver strategies. >>> I do not understand what the units are here. >>> >>> How is anyone supposed to know what they are? >> This unit is the number of times. Number of occurrences in a period, also means threshold. >> If the number of device pci AER error exceeds the threshold in a time window, the device is >> isolated. > Please document this very very well. > >>>> + For example, in the hisilicon accelerator engine, first we will >>>> + time-stamp every slot AER error. Then check the AER error log >>>> + when the device AER error occurred. if the device slot AER error >>>> + count exceeds the preset the number of times in one hour, the >>>> + isolated state will be set to true. So the device will be >>>> + isolated. And the AER error log that exceed one hour will be >>>> + cleared. Of course, different strategies can be defined in >>>> + different drivers. >>> So this file can contain values of different units depending on the >>> different driver that creates it? How is anyone supposed to know what >>> it is and what it should be? >>> >>> This feels very loose, please define this much better so that it can be >>> understood and maintained properly. >>> >>> thanks, >>> >>> greg k-h >>> . >>> >> Yes, We started out with the idea of not restricting the different drive, only specifying the input and output. >> Because we think different drivers require different processing strategy. > What different drivers? You only have one! And why do you need a > framework for only one driver? You should only add that when you have > multiple users to ensure you got the framework correct otherwise you do > not know how it will be used. > > thanks, > > greg k-h > . > ok . I will move isolation strategy from qm to uacce in the next version. it can be understood and maintained properly. thanks Kai