From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 368A4E80AA0 for ; Wed, 27 Sep 2023 07:33:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229995AbjI0HdG (ORCPT ); Wed, 27 Sep 2023 03:33:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50180 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229499AbjI0HdC (ORCPT ); Wed, 27 Sep 2023 03:33:02 -0400 Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C00E2126 for ; Wed, 27 Sep 2023 00:33:00 -0700 (PDT) Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-5331059360fso2361340a12.0 for ; Wed, 27 Sep 2023 00:33:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1695799979; x=1696404779; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=N6pnQ/nkWf6SlVjQP06zaUKvsstL6MZ5VotIaFF9d2I=; b=uRt/ZFptGMXXYi70mRQrFk8G/hEjGXSLfR2cj4d8jUrNA2tYDlwMTHKC2bpR49wzdC mrHNZWYwsfiaDEwlIuZDRmxtHIlKrhEJ4ZVConR5WXAwT9aAtRhLeibWbUZD3yOy7+kC O8HkrmdJQm2r4oU/uahfC/O+pe9dnMp+CONofJjZunsDW/v8b6yE50NAxgHtVahGrYXU UZ3OVEnXNsEIdS6bsJve2EGmjWGAJYNyxmNcWn0X8i3oAhNj0MwYIwq7DN2Il/aV7gWw 9h08d2oIVZbWNZ4IW2GR3KbtfR8JYk/HXzWQ/ZV+NLle5O265a7t9ASuqEpl7wDIkfVn DS1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695799979; x=1696404779; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=N6pnQ/nkWf6SlVjQP06zaUKvsstL6MZ5VotIaFF9d2I=; b=nszAR47U/v0qNXH8xWqJN3K10ewVm/Xb0mWf+HhOFmw49jJRWVW/YP/h/lAYjTainJ mPajwnUH/QhvNjmIUXyUaKPWpx3KQSb7euVFO31dD5QyIvfRZfMI9CeoYWMFcX+Hmkqg YVGeqfa4nhzNvrGTuUeKZx431F/kFPJZ16xWrnwXso5y28TwkU3zU6dT9Ta1CT1vUsuV 0GI2dv+t6PZ0K1TyJUsxTLi8n/Mk5B0ThaJCl2T+eDrW3rb3oDGzncMlW2HDde1RzmL+ wl4tl/feKWHR31x9t2Gl5WLLeT9nXKa8rUo61O7PmLEHE3CvVtpYhG/vb20l8BTwApSG N2Ng== X-Gm-Message-State: AOJu0YzPDAwlbzyA1Whmuvlb25o6xJwn86h/vsaAVmGN0AIE+Cp8+zcx ix6QVLT4qfWNoxp8uxmGdXRQMw== X-Google-Smtp-Source: AGHT+IGl72HpxcGf5R00MKAx7plEYQqRg+QmVRuv6Lb/FKmepMGYWsDUH1yEvJs+hzYAD7rsBF42tA== X-Received: by 2002:a05:6402:4409:b0:523:4069:182c with SMTP id y9-20020a056402440900b005234069182cmr1224456eda.2.1695799978682; Wed, 27 Sep 2023 00:32:58 -0700 (PDT) Received: from [172.20.13.88] ([45.147.210.162]) by smtp.gmail.com with ESMTPSA id w22-20020a056402071600b0052e1783ab25sm7692376edx.70.2023.09.27.00.32.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Sep 2023 00:32:57 -0700 (PDT) Message-ID: Date: Wed, 27 Sep 2023 01:32:56 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] eventfd: move 'eventfd-count' printing out of spinlock Content-Language: en-US To: wenyang.linux@foxmail.com, Alexander Viro , Christian Brauner Cc: Christoph Hellwig , Dylan Yudaken , David Woodhouse , Matthew Wilcox , Eric Biggers , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org References: From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/26/23 8:05 AM, wenyang.linux@foxmail.com wrote: > From: Wen Yang > > It is better to print debug messages outside of the wqh.lock > spinlock where possible. Does it really matter for fdinfo? Your commit message is a bit light, so I'm having to guess whether this is fixing a real issue for you, or if it's just a drive-by observation. -- Jens Axboe