mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: "Lukas K." <kernel@0x83.eu>
Cc: Thorsten Leemhuis <regressions@leemhuis.info>,
	linux-kernel@vger.kernel.org, krzk@kernel.org,
	regressions@lists.linux.dev, netdev@vger.kernel.org,
	Michael Thalmeier <michael.thalmeier@hale.at>
Subject: Re: [REGRESSION] NFC broken on Thinkpad T14 Gen since 9c328f5
Date: Sat, 7 Feb 2026 01:38:47 +0100	[thread overview]
Message-ID: <ff97b58a-f422-4f15-99d3-cbf60bf90583@lunn.ch> (raw)
In-Reply-To: <d73ccfcf-507c-4c22-beeb-efc24f671626@0x83.eu>

On Sat, Feb 07, 2026 at 01:25:29AM +0100, Lukas K. wrote:
> On 06.02.26 17:24, Thorsten Leemhuis wrote:
> > On 2/6/26 16:15, Lukas K. wrote:
> > > 
> > > from 6.17.2 to 6.17.3, the integrated NFC reader (driver: nxp-nci_i2c)
> > > in the Thinkpad T14 Gen 4 (AMD) stopped detecting tags. This can be
> > > tested by running
> > > 
> > > sudo nfctool -1 -p -d nfc0
> > > 
> > > Looking at the commits between 6.17.2 and 6.17.3, 9c328f5 (net: nfc:
> > > nci: Add parameter validation for packet data) was the only one related
> > > to NFC.
> > > 
> > > To see if that commit indeed was the culprit, I reverted it on 6.18.7
> > > and nfctool is detecting tags again.
> > > 
> > > Since the offending commit merely adds some bounds checks, the root
> > > cause may very well be in another driver in the NFC stack.
> > 
> > Thx for the report. Seems Michael (now CCed) also ran into problems and
> > tried to fix them, but looks like that effort stalled; but might be good
> > to know if this fixes your problem, too:
> > 
> > https://lore.kernel.org/all/20260112124819.171028-1-michael.thalmeier@hale.at/
> 
> Hi Thorsten,
> 
> thanks for the pointer. Tried the patch you linked to and it works for me.
> 
> Don't know how to reply to the linked mail as I'm new to LKML, but one thing
> caught my eye:

If you look at the page you will see:

Message-ID: <20260112124819.171028-1-michael.thalmeier@hale.at>

You can take the message ID and give it to b4:

$ b4 mbox 20260112124819.171028-1-michael.thalmeier@hale.at
Looking up https://lore.kernel.org/r/20260112124819.171028-1-michael.thalmeier%40hale.at
Grabbing thread from lore.kernel.org/all
2 messages in the thread
Saved ./20260112124819.171028-1-michael.thalmeier@hale.at.mbx

You can then open
20260112124819.171028-1-michael.thalmeier@hale.at.mbx in a mail client
as a mailbox and hit group reply to one of the messages.

    Andrew

  reply	other threads:[~2026-02-07  0:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-06 15:15 Lukas K.
2026-02-06 16:24 ` Thorsten Leemhuis
2026-02-07  0:25   ` Lukas K.
2026-02-07  0:38     ` Andrew Lunn [this message]
2026-02-18  0:21     ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ff97b58a-f422-4f15-99d3-cbf60bf90583@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=kernel@0x83.eu \
    --cc=krzk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.thalmeier@hale.at \
    --cc=netdev@vger.kernel.org \
    --cc=regressions@leemhuis.info \
    --cc=regressions@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®