From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1017CC4332F for ; Wed, 13 Dec 2023 10:34:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233242AbjLMKeq (ORCPT ); Wed, 13 Dec 2023 05:34:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55046 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235168AbjLMKej (ORCPT ); Wed, 13 Dec 2023 05:34:39 -0500 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 473CD10C for ; Wed, 13 Dec 2023 02:34:39 -0800 (PST) Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-40c3f68b69aso39065105e9.1 for ; Wed, 13 Dec 2023 02:34:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702463677; x=1703068477; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :references:cc:to:content-language:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=C4iHwSi1orpKZdBjvEhFkZBhQdysnUmpyPPK1U/Sy2c=; b=IzZGiDPbU/3QLPcAtg85PkEWB92UT8LPC5kCFBsg+F7zgFFnSP36e3HpvaH8Iq6MVM xinhFqjrUgTQunqHx03jbdnASS6eyvrFvRxxITYw5ltbhY7zNLTW8GJc+MQaxu9lVpdO ecLEBzLgJUzvIxSgx6IoS6j+iaEFvbo95jZIQLIDe0ktlEY9U+l+fybR5A1mqj9Pt/Zh 1UDXbQivx+8QLcebhriCcpNyxidU88hrFcFPbOZ6vuhSCqfAsPtmO+tpfEgL1uSoO7/f zhdUE8WKugKcDMZgZwp+UaEDHefgbeDInfGcxYHY700JUKny6iWq+/Eb/QGKY17U2gFJ JjZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702463677; x=1703068477; h=content-transfer-encoding:in-reply-to:organization:autocrypt :references:cc:to:content-language:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=C4iHwSi1orpKZdBjvEhFkZBhQdysnUmpyPPK1U/Sy2c=; b=AjbLezd/UKPkuTGmSoCGVYwT1l83gb3SS+/tYs/PyhP2wzjFfioG+10w0IWoy+YgpE p/3Y2JXvb4Pebo7Pp7zIKNNqDlj/lph4i9pYqb1IbNbh1A1Rb/ZxyEakEwyIWeKr+EOq CWJwlnpQs8HV6AhyUTlLspK44nCVicXc2sgr5Q9GTCywe3KBp8phvnEezqnkjdbFxp40 J7htX9L7XrR/k8F4hSBmJFFY0wxK7UdX0fHoUO9Eg72lfis6u5Tn6Xme1ZS8U97/8NDT W3S6DZpoFiyLuUvtQclWxskUTKjIR3l34OBdzSfatfQHXwwNqe769ulPI2boOVXUYQBy +www== X-Gm-Message-State: AOJu0YzIGAM2fqBd0x4ovtdfeU+v2E2FcWqmVLVRx0Dg6oNu7D0V7ubD h7/DkY45xYCvXassDSOJNq2fRwnGttvSVYbW5SJ9bE2C X-Google-Smtp-Source: AGHT+IEWrQvGXDSyxXqaXF1f+EAzOJFKjPH7ZFU/HjQgMdjslGSprih7nNhvsmKw57QCZClYojIO8g== X-Received: by 2002:a1c:7916:0:b0:40c:55a7:7735 with SMTP id l22-20020a1c7916000000b0040c55a77735mr1160485wme.118.1702463677504; Wed, 13 Dec 2023 02:34:37 -0800 (PST) Received: from ?IPV6:2a01:e0a:982:cbb0:596e:6d4f:fc0a:ec65? ([2a01:e0a:982:cbb0:596e:6d4f:fc0a:ec65]) by smtp.gmail.com with ESMTPSA id o3-20020a05600c4fc300b004042dbb8925sm22075386wmq.38.2023.12.13.02.34.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Dec 2023 02:34:37 -0800 (PST) Message-ID: Date: Wed, 13 Dec 2023 11:34:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH 1/3] soc: qcom: pmic_pdcharger_ulog: Search current directory for headers Content-Language: en-US, fr To: Andrew Halaney , Andy Gross , Bjorn Andersson , Konrad Dybcio , Dmitry Baryshkov Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20231205-pmicpdcharger-ulog-fixups-v1-0-71c95162cb84@redhat.com> <20231205-pmicpdcharger-ulog-fixups-v1-1-71c95162cb84@redhat.com> Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro Developer Services In-Reply-To: <20231205-pmicpdcharger-ulog-fixups-v1-1-71c95162cb84@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/12/2023 00:05, Andrew Halaney wrote: > As specified in samples/trace_events/Makefile: > > If you include a trace header outside of include/trace/events > then the file that does the #define CREATE_TRACE_POINTS must > have that tracer file in its main search path. This is because > define_trace.h will include it, and must be able to find it from > the include/trace directory. > > Without this the following compilation error is seen: > > CC drivers/soc/qcom/pmic_pdcharger_ulog.o > In file included from drivers/soc/qcom/pmic_pdcharger_ulog.h:36, > from drivers/soc/qcom/pmic_pdcharger_ulog.c:15: > ./include/trace/define_trace.h:95:42: fatal error: ./pmic_pdcharger_ulog.h: No such file or directory > 95 | #include TRACE_INCLUDE(TRACE_INCLUDE_FILE) > | ^ > compilation terminated. > > Fixes: 086fdb48bc65 ("soc: qcom: add ADSP PDCharger ULOG driver") > Signed-off-by: Andrew Halaney > --- > drivers/soc/qcom/Makefile | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/soc/qcom/Makefile b/drivers/soc/qcom/Makefile > index 110108e23669..05b3d54e8dc9 100644 > --- a/drivers/soc/qcom/Makefile > +++ b/drivers/soc/qcom/Makefile > @@ -10,6 +10,7 @@ obj-$(CONFIG_QCOM_PDR_HELPERS) += pdr_interface.o > obj-$(CONFIG_QCOM_PMIC_GLINK) += pmic_glink.o > obj-$(CONFIG_QCOM_PMIC_GLINK) += pmic_glink_altmode.o > obj-$(CONFIG_QCOM_PMIC_PDCHARGER_ULOG) += pmic_pdcharger_ulog.o > +CFLAGS_pmic_pdcharger_ulog.o := -I$(src) > obj-$(CONFIG_QCOM_QMI_HELPERS) += qmi_helpers.o > qmi_helpers-y += qmi_encdec.o qmi_interface.o > obj-$(CONFIG_QCOM_RAMP_CTRL) += ramp_controller.o > I was able to reproduced it, and it only happens when we build in-tree, and checked over the tree and indeed all the other trace drivers uses this flag to compile: Reviewed-by: Neil Armstrong Thanks for the fix! Neil