From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f51.google.com (mail-dl1-f51.google.com [74.125.82.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 326462C375E for ; Wed, 20 May 2026 13:37:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779284280; cv=none; b=DCCjmEpRGHJDKxz+pEf7e+C+ExUjxCCce9FCKH6B2zDOC+tAaBUwViELQv0gJ/JDbKKnteVBHu6BIz1TpFddI0wQWlt3oRhEBYTUSzLFRcfvEpXW7LPuKsbND8LK16Fh5CyfgQsu7feyBBCLF7E7KaEz5gca/za6vPjAbFfu4qQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779284280; c=relaxed/simple; bh=XH63ct7iIhKeSOJDhAToPMJ7pAUUY4007bR5OMXx2+8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Co+TsdpCRXl7pQvW2puyRdwAWhqykEhAMsHwfrrnJnhZrBBirljQe8WMMQ5G0AijyQkOfRh/BEDas0Gf0GXemPsDhvzyGOc/aJIhx/xJT013XII6vLtzpurIXOObtlqtgrTbIGmmgk4PC3UxXcCcALqhTHBGTObB0nA/vTYar3s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nT/k6g+F; arc=none smtp.client-ip=74.125.82.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nT/k6g+F" Received: by mail-dl1-f51.google.com with SMTP id a92af1059eb24-12c8f9846c8so5695892c88.0 for ; Wed, 20 May 2026 06:37:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779284278; x=1779889078; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=v8AkZpbZCTo7d3LdnWMBBV6pSxnl3OrCMz1va21zOtM=; b=nT/k6g+FYzyaEatJYQhAFvrc3oHiKf8UfzLfnGZFA7q2iGgesFToZx+Bk492i99mN9 6ojQBvb7Zuyog18oJyYUk4BKf9Q+mffHwJKMjGx+ePwVEFyG8F2lpsxV5l1VrtnMyOlK B25JMTOL7l+3/p5lavppNMvFbzkN1sHi9oQZsMNGPiCP3GXqKQgsbTawjFEeD0tcZUD1 8+PGTyNYS457M6qXhd/RWB1IqEbCd17c0ZrhH2KzEN6JaepXp9qIxxjtawUuXtenZ7bj FyPOkTV+kuMCvGv957s/EakWLqrN9RnARWbp72tZqhxBcpCm6wpXWipEkUdd0FnPDIQd yRJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779284278; x=1779889078; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=v8AkZpbZCTo7d3LdnWMBBV6pSxnl3OrCMz1va21zOtM=; b=g45Ouaae+9230w0CINpYog2VLWESd3/LBVvwiQjrw+A8i1yZyxiioUONFZm6EjUoeL KJ4nZkS2F7mS63NfiN8I9sTrMVmxcPbx+L1S0OohXU/0goOmkvRar1kyYc8AN1HFPfjR c/e/SI7Uf/9YhzaWS9iDEqstaaww19p/82Wex3PRBk9oQFykhVSGVSQoZSU4gg6/2KGi KvDV+i4KYSvX9yO0bsvIkRPq/5jL3v/hKrC/rqudWwNCGvZ0R+16/lCp/Aj5x6p2BBfF K3p1wQZD6rsxJ3qlqayfNt8qJVFa5qnwmAEWw/w1R9hJb6zz8SK4Jgu8NZoxGJUJxzet F1pA== X-Forwarded-Encrypted: i=1; AFNElJ+WQ5e/88Vvm+FFmopbkCqh1Xkk7xyUYNVxLL+F0tOwvcLCw/XwOmFisYbsBZsW6iXu/3QNl9QbgchHeoI=@vger.kernel.org X-Gm-Message-State: AOJu0YyepHIAoSrXHB/spU56BdPgPfYjs8IrOYPXOqxSFXO1hDEsUtFE ZcObSZUAEv5QCt/DhRU4nY+zNxfgK7b5kW5oo6oOFVlF4BkfOC9rS5+W X-Gm-Gg: Acq92OFwTHwA/O9SOTf5G9sdSSUyMqQIOSs1JFYkxTS95fZCwxb8aT9wAAKNV1DOm9j M5l8++e1n6Vy71fqxJbb/vrnjyaJJztje+CEULmUd1D+bjQs+hX9r5rDUNErogmPBISnh7D1Ez8 Q8dh0jQACE/gN3I588gymbo0LM0ie0NCpdocnpPRCvmxQ5bY+IAAb1A5J78fBLcEhRyyPvsJST2 /S5zzP4FFbETP3lt4pH5L9cUscKEWknbfzGDArUNWbKfnmfzUdLvAv9QAqRY+v27JfYM4DiMrCw WM5d1LKPtsaLUSrdMD1/gm8gtKXXLdjn+KCzVIscM/G+WPVuXReO1aTBSvx1T/0h8tQk8m5VYko 5i4c3g3j6drDcg5alPlnTt5ucRG+CnlL8qSFoHOv1PZ3wSKWnNu/1fo1x+x6ZMsDARto8GfIVW7 xN19JjTv2IPN4t+SsMZ5r5D/8LW+JDF7DRZIp9L+njHV4JraI= X-Received: by 2002:a05:7300:6429:b0:2d9:2b54:ea9c with SMTP id 5a478bee46e88-3039867e6efmr12060147eec.18.1779284277938; Wed, 20 May 2026 06:37:57 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-302944ffb85sm19200837eec.7.2026.05.20.06.37.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2026 06:37:57 -0700 (PDT) Sender: Guenter Roeck Date: Wed, 20 May 2026 06:37:56 -0700 From: Guenter Roeck To: Shubham Chakraborty Cc: Florian Fainelli , Jonathan Corbet , Shuah Khan , Broadcom internal kernel review list , Ray Jui , Scott Branden , linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/3] hwmon: raspberrypi: Add voltage input support Message-ID: References: <20260516164407.25255-1-chakrabortyshubham66@gmail.com> <20260517080445.103962-1-chakrabortyshubham66@gmail.com> <20260517080445.103962-3-chakrabortyshubham66@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260517080445.103962-3-chakrabortyshubham66@gmail.com> On Sun, May 17, 2026 at 01:34:44PM +0530, Shubham Chakraborty wrote: > Extend the raspberrypi-hwmon driver to expose firmware-provided > voltage measurements through the hwmon subsystem. > > The driver now exports the following voltage inputs: > > - in0_input (core) > - in1_input (sdram_c) > - in2_input (sdram_i) > - in3_input (sdram_p) > > Voltage values returned by firmware are converted from microvolts > to millivolts as expected by the hwmon subsystem. > > Update the documentation related to it. > > The existing undervoltage sticky alarm handling is preserved and > associated with the first voltage channel. > > Tested in - > - Raspberry Pi 3b+ (Linux raspberrypi 6.12.75+rpt-rpi-v8 #1 SMP PREEMPT > Debian 1:6.12.75-1+rpt1 (2026-03-11) aarch64 GNU/Linux) > > Signed-off-by: Shubham Chakraborty > Reviewed-by: Florian Fainelli Applied, after fixing: WARNING: Missing a blank line after declarations #207: FILE: drivers/hwmon/raspberrypi-hwmon.c:74: + int ret; + ret = rpi_firmware_property(data->fw, RPI_FIRMWARE_GET_VOLTAGE, Please run checkpatch on your patches. Thanks, Guenter