From: Helge Deller <deller@gmx.de>
To: Alex Guo <alexguo1023@gmail.com>
Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fbdev: pm3fb: Fix potential divide by zero
Date: Sun, 8 Jun 2025 15:12:15 +0200 [thread overview]
Message-ID: <ffaead6b-e9d9-46cf-ad08-aa6a46dbe74a@gmx.de> (raw)
In-Reply-To: <20250607194959.2457473-1-alexguo1023@gmail.com>
On 6/7/25 21:49, Alex Guo wrote:
> variable var->pixclock can be set by user. In case it equals to
> zero, divide by zero would occur in pm3fb_check_var. Similar
> crashes have happened in other fbdev drivers. There is no check
> and modification on var->pixclock along the call chain to
> pm3fb_check_var. So we fix this by checking whether 'pixclock'
> is zero.
>
> Similar commit: commit 16844e58704 ("video: fbdev: tridentfb:
> Error out if 'pixclock' equals zero")
>
> Signed-off-by: Alex Guo <alexguo1023@gmail.com>
> ---
> drivers/video/fbdev/pm3fb.c | 3 +++
> 1 file changed, 3 insertions(+)
applied.
Thanks!
Helge
next prev parent reply other threads:[~2025-06-08 13:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-07 19:49 Alex Guo
2025-06-08 13:12 ` Helge Deller [this message]
2025-06-10 7:42 ` Geert Uytterhoeven
2025-06-11 16:12 ` Alex Guo
2025-06-12 9:29 ` Geert Uytterhoeven
2025-07-27 18:17 ` Helge Deller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ffaead6b-e9d9-46cf-ad08-aa6a46dbe74a@gmx.de \
--to=deller@gmx.de \
--cc=alexguo1023@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®