From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754065AbbGWTPA (ORCPT ); Thu, 23 Jul 2015 15:15:00 -0400 Received: from mail.kernel.org ([198.145.29.136]:34362 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753985AbbGWTOr (ORCPT ); Thu, 23 Jul 2015 15:14:47 -0400 From: Andy Lutomirski To: X86 ML , linux-kernel@vger.kernel.org Cc: Brian Gerst , Steven Rostedt , Willy Tarreau , Borislav Petkov , Thomas Gleixner , Peter Zijlstra , Linus Torvalds , Andy Lutomirski Subject: [PATCH v2] x86/entry/32: Remove duplicate initialization of tss.ss1 Date: Thu, 23 Jul 2015 12:14:41 -0700 Message-Id: X-Mailer: git-send-email 2.4.3 In-Reply-To: <690f0c629a1085d054e2d1ef3da073cfb3f7db92.1437678821.git.luto@kernel.org> References: <690f0c629a1085d054e2d1ef3da073cfb3f7db92.1437678821.git.luto@kernel.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It's statically initialized, so we don't need to dynamically initialize it too. Reported-by: Brian Gerst Signed-off-by: Andy Lutomirski --- Changes since v1: Delete the code :) arch/x86/kernel/cpu/common.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c index e2ed2513a51e..e08eee98a5f8 100644 --- a/arch/x86/kernel/cpu/common.c +++ b/arch/x86/kernel/cpu/common.c @@ -1005,14 +1005,6 @@ void enable_sep_cpu(void) if (IS_ENABLED(CONFIG_X86_32) && !boot_cpu_has(X86_FEATURE_SEP)) goto out; -#ifdef CONFIG_X86_32 - /* - * We cache MSR_IA32_SYSENTER_CS's value in the TSS's ss1 field -- - * see the big comment in struct x86_hw_tss's definition. - */ - tss->x86_tss.ss1 = __KERNEL_CS; -#endif - wrmsrl_safe(MSR_IA32_SYSENTER_CS, __KERNEL_CS); wrmsrl_safe(MSR_IA32_SYSENTER_ESP, (unsigned long)tss + -- 2.4.3