From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 304C8C11F69 for ; Wed, 30 Jun 2021 17:29:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 177C361474 for ; Wed, 30 Jun 2021 17:29:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232605AbhF3Rbe (ORCPT ); Wed, 30 Jun 2021 13:31:34 -0400 Received: from foss.arm.com ([217.140.110.172]:42988 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229573AbhF3Rbd (ORCPT ); Wed, 30 Jun 2021 13:31:33 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 302C36D; Wed, 30 Jun 2021 10:29:04 -0700 (PDT) Received: from [10.57.10.3] (unknown [10.57.10.3]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2D4243F718; Wed, 30 Jun 2021 10:29:01 -0700 (PDT) Subject: Re: [PATCH 1/3] sched/fair: Prepare variables for increased precision of EAS estimated energy To: "Rafael J. Wysocki" , Peter Zijlstra Cc: Linux Kernel Mailing List , Chris Redpath , Dietmar Eggemann , Morten Rasmussen , Quentin Perret , Linux PM , "Rafael J. Wysocki" , Viresh Kumar , Vincent Guittot , Ingo Molnar , Juri Lelli , Steven Rostedt , segall@google.com, Mel Gorman , Daniel Bristot de Oliveira , CCj.Yeh@mediatek.com References: <20210625152603.25960-1-lukasz.luba@arm.com> <20210625152603.25960-2-lukasz.luba@arm.com> From: Lukasz Luba Message-ID: Date: Wed, 30 Jun 2021 18:28:58 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/30/21 6:01 PM, Rafael J. Wysocki wrote: > On Fri, Jun 25, 2021 at 5:26 PM Lukasz Luba wrote: >> >> The Energy Aware Scheduler (EAS) tries to find best CPU for a waking up >> task. It probes many possibilities and compares the estimated energy values >> for different scenarios. For calculating those energy values it relies on >> Energy Model (EM) data and em_cpu_energy(). The precision which is used in >> EM data is in milli-Watts (or abstract scale), which sometimes is not >> sufficient. In some cases it might happen that two CPUs from different >> Performance Domains (PDs) get the same calculated value for a given task >> placement, but in more precised scale, they might differ. This rounding >> error has to be addressed. This patch prepares EAS code for better >> precision in the coming EM improvements. >> >> Signed-off-by: Lukasz Luba > > If you want me to pick up this series, this patch requires an ACK from > the scheduler maintainers. > It would be great, if you could take it after e.g. Peter ACK it. Peter could you have a look at it, please? In this patch 1/3 we have only variables upgrade. Regards, Lukasz