From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Arnd Bergmann <arnd@kernel.org>,
Nipun Gupta <nipun.gupta@amd.com>,
Nikhil Agarwal <nikhil.agarwal@amd.com>
Cc: "Thomas Gleixner" <tglx@linutronix.de>,
"Marc Zyngier" <maz@kernel.org>, "Arnd Bergmann" <arnd@arndb.de>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Thomas Weißschuu" <linux@weissschuh.net>,
"Qiu-ji Chen" <chenqiuji666@gmail.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Rob Herring (Arm)" <robh@kernel.org>,
"Robin Murphy" <robin.murphy@arm.com>,
"Abhijit Gangurde" <abhijit.gangurde@amd.com>,
"Nathan Chancellor" <nathan@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cdx: don't select CONFIG_GENERIC_MSI_IRQ
Date: Wed, 6 Aug 2025 14:42:33 +0200 [thread overview]
Message-ID: <ffd07f38-670e-45f1-96df-60b2d38ff185@linaro.org> (raw)
In-Reply-To: <20250805161059.4006484-1-arnd@kernel.org>
On 05/08/2025 18:10, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> x86 does not use CONFIG_GENERIC_MSI_IRQ, and trying to enable it anyway
> results in a build failure:
>
> In file included from include/linux/ssb/ssb.h:10,
> from drivers/ssb/pcihost_wrapper.c:18:
> include/linux/gpio/driver.h:41:33: error: field 'msiinfo' has incomplete type
> 41 | msi_alloc_info_t msiinfo;
> | ^~~~~~~
> In file included from include/linux/kvm_host.h:19,
> from arch/x86/events/intel/core.c:17:
> include/linux/msi.h:528:33: error: field 'alloc_info' has incomplete type
> 528 | msi_alloc_info_t alloc_info;
>
> Change the driver to actually build without this symbol and remove the
> incorrect 'select' statements.
>
Maybe also original reported-by credits?
https://lore.kernel.org/all/20250717091053.129175-2-krzysztof.kozlowski@linaro.org/
And cc-stable and fixes.
I started working on this and had similar fix, but then I got impression
the CDX people will fix that:
https://lore.kernel.org/all/BL1PR12MB5333449243C7FE258728C8E39D5EA@BL1PR12MB5333.namprd12.prod.outlook.com/
so I stopped working.
Shall CDX maintainers entry be changed to Odd Fixes?
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-08-06 12:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-05 16:10 Arnd Bergmann
2025-08-06 12:37 ` Robin Murphy
2025-08-06 12:42 ` Krzysztof Kozlowski [this message]
2025-08-06 19:44 ` kernel test robot
2025-08-11 10:02 ` Agarwal, Nikhil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ffd07f38-670e-45f1-96df-60b2d38ff185@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=abhijit.gangurde@amd.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=chenqiuji666@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=maz@kernel.org \
--cc=nathan@kernel.org \
--cc=nikhil.agarwal@amd.com \
--cc=nipun.gupta@amd.com \
--cc=peterz@infradead.org \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®