From: Shuah Khan <skhan@linuxfoundation.org>
To: "Thomas Weißschuh" <thomas.weissschuh@linutronix.de>,
"Shuah Khan" <shuah@kernel.org>, "Willy Tarreau" <w@1wt.eu>,
"Thomas Weißschuh" <linux@weissschuh.net>
Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v2 03/32] selftests: harness: Ignore unused variant argument warning
Date: Thu, 10 Apr 2025 09:33:16 -0600 [thread overview]
Message-ID: <ffd1f317-f4d9-4a39-ae6c-04afd7fddc0f@linuxfoundation.org> (raw)
In-Reply-To: <20250407-nolibc-kselftest-harness-v2-3-f8812f76e930@linutronix.de>
On 4/7/25 00:52, Thomas Weißschuh wrote:
> For tests without fixtures the variant argument is unused.
> This is intentional, prevent to compiler from complaining.
>
Include the warning in the change log for reference.
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
> ---
> tools/testing/selftests/kselftest_harness.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/kselftest_harness.h b/tools/testing/selftests/kselftest_harness.h
> index bac4327775ea65dbe977e9b22ee548bedcbd33ff..2b350ed60b2bf1cbede8e3a9b4ac5fe716900144 100644
> --- a/tools/testing/selftests/kselftest_harness.h
> +++ b/tools/testing/selftests/kselftest_harness.h
> @@ -174,7 +174,7 @@
> static void test_name(struct __test_metadata *_metadata); \
> static inline void wrapper_##test_name( \
> struct __test_metadata *_metadata, \
> - struct __fixture_variant_metadata *variant) \
> + struct __fixture_variant_metadata __attribute__((unused)) *variant) \
> { \
> _metadata->setup_completed = true; \
> if (setjmp(_metadata->env) == 0) \
>
thanks,
-- Shuah
next prev parent reply other threads:[~2025-04-10 15:33 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 6:52 [PATCH v2 00/32] kselftest harness and nolibc compatibility Thomas Weißschuh
2025-04-07 6:52 ` [PATCH v2 01/32] selftests: harness: Add harness selftest Thomas Weißschuh
2025-04-10 15:19 ` Shuah Khan
2025-04-07 6:52 ` [PATCH v2 02/32] selftests: harness: Use C89 comment style Thomas Weißschuh
2025-04-10 15:33 ` Shuah Khan
2025-04-07 6:52 ` [PATCH v2 03/32] selftests: harness: Ignore unused variant argument warning Thomas Weißschuh
2025-04-10 15:33 ` Shuah Khan [this message]
2025-04-07 6:52 ` [PATCH v2 04/32] selftests: harness: Mark functions without prototypes static Thomas Weißschuh
2025-04-07 6:52 ` [PATCH v2 05/32] selftests: harness: Remove inline qualifier for wrappers Thomas Weißschuh
2025-04-07 6:52 ` [PATCH v2 06/32] selftests: harness: Remove dependency on libatomic Thomas Weißschuh
2025-04-07 6:52 ` [PATCH v2 07/32] selftests: harness: Implement test timeouts through pidfd Thomas Weißschuh
2025-04-07 6:52 ` [PATCH v2 08/32] selftests: harness: Don't set setup_completed for fixtureless tests Thomas Weißschuh
2025-04-07 6:52 ` [PATCH v2 09/32] selftests: harness: Always provide "self" and "variant" Thomas Weißschuh
2025-04-07 6:52 ` [PATCH v2 10/32] selftests: harness: Move teardown conditional into test metadata Thomas Weißschuh
2025-04-07 6:52 ` [PATCH v2 11/32] selftests: harness: Add teardown callback to " Thomas Weißschuh
2025-04-07 6:52 ` [PATCH v2 12/32] selftests: harness: Stop using setjmp()/longjmp() Thomas Weißschuh
2025-04-07 6:52 ` [PATCH v2 13/32] selftests: harness: Guard includes on nolibc Thomas Weißschuh
2025-04-07 6:52 ` [PATCH v2 14/32] tools/nolibc: handle intmax_t/uintmax_t in printf Thomas Weißschuh
2025-04-07 6:52 ` [PATCH v2 15/32] tools/nolibc: use intmax definitions from compiler Thomas Weißschuh
2025-04-07 6:52 ` [PATCH v2 16/32] tools/nolibc: use pselect6_time64 if available Thomas Weißschuh
2025-04-07 6:52 ` [PATCH v2 17/32] tools/nolibc: use ppoll_time64 " Thomas Weißschuh
2025-04-07 6:52 ` [PATCH v2 18/32] tools/nolibc: add tolower() and toupper() Thomas Weißschuh
2025-04-07 6:52 ` [PATCH v2 19/32] tools/nolibc: add _exit() Thomas Weißschuh
2025-04-07 6:52 ` [PATCH v2 20/32] tools/nolibc: add setpgrp() Thomas Weißschuh
2025-04-07 6:52 ` [PATCH v2 21/32] tools/nolibc: implement waitpid() in terms of waitid() Thomas Weißschuh
2025-04-07 6:52 ` [PATCH v2 22/32] Revert "selftests/nolibc: use waitid() over waitpid()" Thomas Weißschuh
2025-04-07 6:52 ` [PATCH v2 23/32] tools/nolibc: add dprintf() and vdprintf() Thomas Weißschuh
2025-04-07 6:52 ` [PATCH v2 24/32] tools/nolibc: add getopt() Thomas Weißschuh
2025-04-07 6:52 ` [PATCH v2 25/32] tools/nolibc: allow different write callbacks in printf Thomas Weißschuh
2025-04-07 6:52 ` [PATCH v2 26/32] tools/nolibc: allow limiting of printf destination size Thomas Weißschuh
2025-04-07 6:52 ` [PATCH v2 27/32] tools/nolibc: add snprintf() and friends Thomas Weißschuh
2025-04-07 6:52 ` [PATCH v2 28/32] selftests/nolibc: use snprintf() for printf tests Thomas Weißschuh
2025-04-07 6:52 ` [PATCH v2 29/32] selftests/nolibc: rename vfprintf test suite Thomas Weißschuh
2025-04-07 6:52 ` [PATCH v2 30/32] selftests/nolibc: add test for snprintf() truncation Thomas Weißschuh
2025-04-07 6:52 ` [PATCH v2 31/32] tools/nolibc: implement width padding in printf() Thomas Weißschuh
2025-04-07 6:52 ` [PATCH v2 32/32] HACK: selftests/nolibc: demonstrate usage of the kselftest harness Thomas Weißschuh
2025-04-10 15:19 ` [PATCH v2 00/32] kselftest harness and nolibc compatibility Shuah Khan
2025-04-10 20:01 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ffd1f317-f4d9-4a39-ae6c-04afd7fddc0f@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=shuah@kernel.org \
--cc=thomas.weissschuh@linutronix.de \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®